From ab84481c02dcc0e31569034e072d1301fef33c3e Mon Sep 17 00:00:00 2001 From: sanjayl Date: Wed, 30 Mar 2016 22:36:57 -0400 Subject: [PATCH] Let sync op failures use stacktrace viewer This lets sync ops use the stacktrace viewer, just like how async ops currently do. Requires some changes to the CIDER-nREPL code as well which were submitted as CIDER-nREPL PR 327 https://github.com/clojure-emacs/cider-nrepl/pull/327. --- CHANGELOG.md | 1 + nrepl-client.el | 6 +----- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 156e1e70e..968b5aa53 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,7 @@ ### Bugs fixed +* [#1420](https://github.com/clojure-emacs/cider/issues/1420): Show stacktrace buffers for sync requests errors. * [#1632](https://github.com/clojure-emacs/cider/pull/1632): Redefining a function correctly updates eldoc. * [#1630](https://github.com/clojure-emacs/cider/pull/1630): The debugger no longer gets confused inside `@` redefs. * [#1599](https://github.com/clojure-emacs/cider/pull/1599): Don't error when test makes 0 assertions. diff --git a/nrepl-client.el b/nrepl-client.el index 1952bb3b5..c6b493676 100644 --- a/nrepl-client.el +++ b/nrepl-client.el @@ -968,11 +968,7 @@ sign of user input, so as not to hang the interface." ;; so we have to handle them differently until this is resolved (if (member "eval-error" status) (funcall nrepl-err-handler) - ;; dump the stacktrace in the REPL - ;; TODO: This has to be replaced with rendering of the - ;; standard stacktrace buffer - (cider-repl-emit-interactive-stderr err) - (switch-to-buffer-other-window connection))) + (cider--render-stacktrace-causes (nrepl-dict-get response "pp-stacktrace")))) (when-let ((id (nrepl-dict-get response "id"))) (with-current-buffer connection (nrepl--mark-id-completed id)))