Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flame: v8 log conversion failed #55

Closed
ttessarolo opened this issue Sep 18, 2018 · 5 comments
Closed

Flame: v8 log conversion failed #55

ttessarolo opened this issue Sep 18, 2018 · 5 comments

Comments

@ttessarolo
Copy link

ttessarolo commented Sep 18, 2018

Expected Behavior

Generate and open Flamegraph

Current Behavior

Error: v8 log conversion failed

Steps to Reproduce (for bugs)

  1. I'm using a basic node.js app just for test:

var express = require("express");
var app = express();

app.get("/", function(req, res) {
res.send("Hello World");
});

app.listen(3097);

  1. using Node.js v.10.10.0 (with both clinic doctor + autocannon installed -g)
  2. clinic flame --on-port='autocannon -c 100 localhost:$PORT' -- node index.js
  3. when autocannon finish it produce the following error: Error: v8 log conversion failed
  4. Switching to Node.js v8.12.0 -- nvm use v8.12.0 -- (with both clinic doctor + autocannon installed -g) and running exactly the same command it generates correctly the flamegraph

Sample upload

Environment

@nearform/doctor@3.3.0
autocannon@2.4.1

  • Node version: Node.js v.10.10.0
  • OSX 10.13.6 (17G2307)
@mcollina
Copy link
Contributor

Thanks for reporting, this is actually a regression in Node.js 10 which will be fixed in 10.11, coming out later today.

@BridgeAR
Copy link
Contributor

Duplicate of davidmarkclements/0x#163

@BridgeAR BridgeAR marked this as a duplicate of davidmarkclements/0x#163 Sep 18, 2018
@ttessarolo
Copy link
Author

great thanks

@DylanC
Copy link
Contributor

DylanC commented Feb 14, 2020

@mcollina - Should this and the related 0x issue be closed since the fix is released into Node?

@jasnell
Copy link
Contributor

jasnell commented Feb 14, 2020

While I'm not @mcollina (who could be! ;-) ) I definitely think we can close this one

@jasnell jasnell closed this as completed Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants