Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intermittent testing failures #13

Open
clbarnes opened this issue Nov 16, 2020 · 4 comments
Open

Intermittent testing failures #13

clbarnes opened this issue Nov 16, 2020 · 4 comments
Labels
info

Comments

@clbarnes
Copy link
Owner

https://github.com/clbarnes/ncollpyde/runs/1406818474?check_suite_focus=true

test_ncollpyde_contains test fails randomly on CI; count of points in the mesh differs by 1.
@clbarnes
Copy link
Owner Author

clbarnes commented Nov 16, 2020 •
edited
Loading

This is probably due to randomly selecting the rays for containment checks. As of 0b127e4 the seed is consistent (but can be made random).

@clbarnes
Copy link
Owner Author

Deterministic rays do not solve this issue.

@clbarnes clbarnes mentioned this issue May 10, 2021
Closed
@clbarnes
Copy link
Owner Author

clbarnes commented Nov 9, 2021

"Resolved" in that I've added a tolerance to the one benchmark which was failing... Not ideal, so I'll leave this open for now.

@clbarnes clbarnes added the info label Nov 9, 2021
@clbarnes
Copy link
Owner Author

clbarnes commented Nov 9, 2021

This may be resolved by the rebase on parry and the use of parry's enhanced-determinism feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
info
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@clbarnes