From 2f1d7c48ec9bed38add78ee4588fd179035144a3 Mon Sep 17 00:00:00 2001 From: Jhonatan Gomes Date: Thu, 3 May 2018 14:29:15 -0300 Subject: [PATCH] refactor(dash): handle error on super when error is unknown --- src/clappr-dash-shaka-playback.js | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/clappr-dash-shaka-playback.js b/src/clappr-dash-shaka-playback.js index 78721f4..8c44cad 100644 --- a/src/clappr-dash-shaka-playback.js +++ b/src/clappr-dash-shaka-playback.js @@ -315,15 +315,15 @@ class DashShakaPlayback extends HTML5Video { videoError: this.el.error } - if (error.videoError) return super._onError() - let { category, code, severity } = error.shakaError.detail || error.shakaError + if (error.videoError || !code && !category) return super._onError() + const isCritical = severity === shaka.util.Error.Severity.CRITICAL const errorData = { code: `${category}_${code}`, description: `Category: ${category}, code: ${code}, severity: ${severity}`, - level: severity === 1 ? PlayerError.Levels.WARN : PlayerError.Levels.FATAL, + level: isCritical ? PlayerError.Levels.FATAL : PlayerError.Levels.WARN, raw: err } const formattedError = this.createError(errorData) @@ -331,6 +331,7 @@ class DashShakaPlayback extends HTML5Video { this.trigger(Events.PLAYBACK_ERROR, formattedError) } + _onAdaptation () { let activeVideo = this.videoTracks.filter((t) => t.active === true)[0]