Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interpolation not working on clesperanto version #40

Closed
StRigaud opened this issue Jun 21, 2024 · 2 comments
Closed

interpolation not working on clesperanto version #40

StRigaud opened this issue Jun 21, 2024 · 2 comments

Comments

@StRigaud
Copy link
Member

Trying to fix clEsperanto/pyclesperanto#204

Affine transform without interpolation works, so I assume there is a issue on the interpolation version. Main difference between the two is the position from which the kernel read and write.

My guess is on the read and write position computation. I used the POS_src_INSTANCE and POS_dst_INSTANCE while the original kernel uses float4 and int4 (float2 and int2 for 2d). But READ_IMAGE do not accept a float4 or float2, making the kernel build fail.

why is https://github.com/clEsperanto/clij-opencl-kernels/blob/master/kernels/affine_transform_3d_interpolate_x.cl works while https://github.com/clEsperanto/clij-opencl-kernels/blob/clesperanto_kernels/kernels/affine_transform_interpolate.cl fail to build

I might need an extra help to understand here @haesleinhuepf

@StRigaud
Copy link
Member Author

StRigaud commented Jul 2, 2024

@haesleinhuepf any feedback?

@StRigaud
Copy link
Member Author

StRigaud commented Jul 5, 2024

read_imagef can take float2 and float4 as coordinate, which works in combination with the sampler.
The issue can be fixed by updating the defines generation in CLIc.
See: clEsperanto/CLIc@f1f23fe

@StRigaud StRigaud closed this as completed Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant