Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upcast inline image styles to classes using a configurable mapping #9332

Closed
oleq opened this issue Mar 23, 2021 · 1 comment
Closed

Upcast inline image styles to classes using a configurable mapping #9332

oleq opened this issue Mar 23, 2021 · 1 comment
Labels
domain:ui/ux This issue reports a problem related to UI or UX. domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. package:image

Comments

@oleq
Copy link
Member

oleq commented Mar 23, 2021 •
edited
Loading

Developers should be able to configure upcast style matchers that will allow loading images styles with float: left/right (and others) to any supported class, e.g. .image-style-align-left.

This is essential for:
@oleq oleq added domain:ui/ux This issue reports a problem related to UI or UX. package:image squad:core Issue to be handled by the Core team. labels Mar 23, 2021
@oleq oleq added this to the iteration 42 milestone Mar 23, 2021
@oleq oleq changed the title Upcast float-based image styles to classes using a configurable mapping Upcast inline image styles to classes using a configurable mapping Mar 23, 2021
@AnnaTomanek AnnaTomanek added domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. squad:compat labels Apr 12, 2021
@AnnaTomanek AnnaTomanek modified the milestones: iteration 42, nice-to-have Apr 12, 2021
@AnnaTomanek AnnaTomanek removed the squad:core Issue to be handled by the Core team. label Apr 12, 2021
@oleq oleq mentioned this issue May 4, 2021
Closed
@Mgsy
Copy link
Member

Mgsy commented Aug 5, 2021

It will be covered by #10310.

@Mgsy Mgsy closed this as completed Aug 5, 2021
@Mgsy Mgsy removed this from the nice-to-have milestone Aug 5, 2021
@Mgsy Mgsy removed the squad:compat label Aug 5, 2021
@Mgsy Mgsy mentioned this issue Aug 5, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain:ui/ux This issue reports a problem related to UI or UX. domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. package:image
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AnnaTomanek @oleq @Mgsy