-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some icons may look blurry on LoDPI screens after theme refactoring #808
Comments
For me, lists, bold and italic looks very bad on standard screen. :( When I open standard editor I thought there is a rendering bug. |
The biggest difference is, surprise surprise, in 1px -> 1.5px horizontal/vertical lines. Those are blurry now. But all rounded shapes look as good/bad as they did. I wonder what would happen if we increased the line width from 1.5px to eg. 1.75px. Or down to 1.25px. It might look sharper then because it would round better to 1px or 2px. While the average width would still be ~3px on retina. Could you do such tests on one of the icons, Olek? I'm really curious to see this live. |
@jodator That looks pretty bad, I admit. Linux, I guess? We might research 1.25 or 1.75 but in truth, the only safe solutions are 1px and 2px. Unfortunately, with current technology, we are unable to deliver different icons based on the density of the screen – we'd have to include 2 icon sets in the JS build to do that. |
I just went quickly through other editors and they are:
That's the state of the web in 2018. Also, it made me realise that I haven't been noticing this so it may happen that we'll stop noticing the blurriness of the new icons in a short time too :D |
I think I got used to this and no one ever reported it, so I'm closing this ticket. |
Most of them look crisp enough to me but blockquote and image need refactoring.
A follow-up of #645.
The text was updated successfully, but these errors were encountered: