-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow passing your own translations when building CKEditor 5 #763
Comments
cc @wwalc too |
I wouldn't be so afraid of scaring people away from Transifex, it's exactly the same difference that is between submitting a code fix in a PR to the official repository and just fixing your code locally - the same benefits (quick fix) and risks (not future-proof). Whoever wants to help us will want to help us as long as it's easy enough and rewarding (be it through a "thank you" note from us or their own internal feeling of doing something to help others). One note is that once you submit your translations to Transifex, you can download the translations as individual |
Our guide would say that:
This way people won't have to understand the PO files syntax (which isn't super natural) and they will still be able to quickly build the editor despite outdated translations (on npm). |
Maybe the JSON format would be easier for developers? Either way, it should be easy to implement. Option to overwriting existing translations would be a little bit harder, but also doable. |
How can I configure CKEditor5WebpackPlugin to use my custom po files that I uploaded at transifex? |
@fabken, we are discussing adding such an option to the If you uploaded translations on the https://www.transifex.com/ckeditor/ckeditor5/, then they will be available in our next release. |
I wonder if offering one more thing would not make sense: a tool for the end users to fetch latest translations from Transifex. Like Things I did not check:
|
AFAIR the API token provides, unfortunately, a |
We could make a CS proxy for the readonly access to translations :D |
Can you confirm this, just to make sure? If you confirm it, could you ask Transifex support if they see any workaround for our use case? |
I can confirm that for today there's only the
Yep, a little bit late, but still I can ask them 😅 |
We have users which would like to also overwrite existing translations. I think it would be extremely useful if users could create their own file or set of files with translations they want to change to add. |
Hi! |
Hm... Interesting :) Can you write a bit more about it? I think I know how you did this, but just to be sure – how does the structure of |
@Reinmar, @MuhammadAsadUllah821 |
Problem
Scenario:
The problem is that the process would need to have those additional steps:
This is just too slow and inconvenient. Therefore, we need to find some solutions for translating the editor by other developers. Also, we may think whether this wouldn't allow translating your own code which may be needed in international projects.
Solution
The easiest solution I can think of is allowing developers to pass additional PO file to
CKEditor5WebpackPlugin
. Developers should be able to put all missing translations (from all packages) in this file.@AnnaTomanek @ma2ciek, does it sound reasonable? Or do you have other ideas?
There's one issue with this solution – when it will be so easy to translate CKEditor 5 for yourself people will be less inclined to sign into Transifex to fill those translations there too. But OTOH, tricking people to fill translations on Transifex when they can't use them for next month is not cool anyway.
If you'd like to see this feature implemented, add a 👍 reaction to this post.
The text was updated successfully, but these errors were encountered: