Differ#getChanges() could return items for remove entries

[scofalik]

📝 Provide a description of the improvement

At the moment, Differ#getChanges() for "remove" entries does not return the removed item. Instead position and length are returned.

What is returned now is fine for remove conversion but it feels bad when used in post-fixers. Now, if you want to react to removing particular element, you need to get changes together with changes in graveyard and check if the element was inserted into a graveyard. This is not intuitive at all.

Moreover, there are some difficulties when using the above "workaround". For example, I don't know from which position the element was removed.

[jodator]

I've spiked this when trying to figure out why table reconversion fails: 77c8115.

Looks easy to implement. It might be also required for table partial reconversion.

The problem in tables touches the way how triggerBy handles events and that there's no way to "consume" remove changes. I need to override the default remove converter (block it in case of table reconversion when a row was removed) because the default removes converter uses a heuristic to detect what view element is to be removed (because it does not have access to removed element and can't check if the view element was already removed).

[jodator]

I've spiked this when trying to figure out why table reconversion fails: 77c8115.

This will not work for the current writer.move() operation.

It could be a new kind of conversion operation to handle but I don't know the impact of such change. So it is hard to tell.

OTOH maybe the remove opearation handler could actually check if the model is in greaveyard or not (remove vs move).

[CKEditorBot]

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

[CKEditorBot]

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).