Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tests started to fail on Chrome 80 #6198

Closed
jodator opened this issue Feb 5, 2020 · 10 comments
Closed

Some tests started to fail on Chrome 80 #6198

jodator opened this issue Feb 5, 2020 · 10 comments
Labels
browser:chrome type:bug This issue reports a buggy (incorrect) behavior.

Comments

@jodator
Copy link
Contributor

jodator commented Feb 5, 2020

πŸ“ Provide detailed reproduction steps (if any)

  1. Update Chrome to the latest version (80)
  2. Run tests on master branch

βœ”οΈ Expected result

πŸ’š tests are green

❌ Actual result

πŸ”΄ tests are red:

Tests fail in:

  • table (one test) running single repo locally / CI (PR)
  • autoformat - bulleted list (multiple tests) running whole ckeditor5 tests locally
  • ImageResize (multiple tests) running whole ckeditor5 or single repo locally

Those are only repositories I've found failing but I didn't check them all (ie table fails locally/Ci when running single repo but not when shole ckeditor5 package tests).

πŸ“ƒ Other details

  • Browser: Chrome 80
  • OS: Linux
  • CKEditor version: latest master

CKEditor 5 builds on Travis CI (ooks OK though):


If you'd like to see this fixed sooner, add a πŸ‘ reaction to this post.

@jodator jodator added type:bug This issue reports a buggy (incorrect) behavior. browser:chrome labels Feb 5, 2020
@jodator jodator added this to the iteration 29 milestone Feb 5, 2020
@Reinmar
Copy link
Member

Reinmar commented Feb 6, 2020

@Reinmar
Copy link
Member

Reinmar commented Feb 6, 2020

For me, only the image resize tests fail locally on Chrome 80.0.3987 (Mac OS X 10.15.2). cc @mlewand

Also, on CI all are green now: https://travis-ci.org/ckeditor/ckeditor5/builds/646814309. Which is weird.

Can you check on your side?

@Reinmar
Copy link
Member

Reinmar commented Feb 6, 2020

OK, I can also reproduce the single table test that fails when running table tests locally. I'll handle that.

I can't reproduce any problem with autoformat when running all tests. I'll ignore this.

@mlewand
Copy link
Contributor

mlewand commented Feb 6, 2020

@Reinmar interestingly tests ran on master for image and widget packages (yarn run test -f image,widget) are green on Windows. I can see that CI also reports no issue.

Tested with Chrome 80.0.3987 (Windows 10.0.0). πŸ€” I'll make a couple more runs.

@jodator
Copy link
Contributor Author

jodator commented Feb 6, 2020

@mlewand - it might be that for me only some configuration failed (ie running all tests or running single repo)

@Reinmar
Copy link
Member

Reinmar commented Feb 6, 2020

For this specific setup (image + widget) I get the below:

SUMMARY:
βœ” 604 tests completed
βœ– 2 tests failed

FAILED TESTS:
  Widget - integration
    βœ– should do nothing if clicked inside a nested editable
      Chrome 80.0.3987 (Mac OS X 10.15.2)
    AssertionError: expected '[<div class="ck-widget ck-widget_selected" contenteditable="false"><figcaption contenteditable="true">foo bar</figcaption></div>]' to equal '[]<div class="ck-widget" contenteditable="false"><figcaption contenteditable="true">foo bar</figcaption></div>'

      + expected - actual

      -[<div class="ck-widget ck-widget_selected" contenteditable="false"><figcaption contenteditable="true">foo bar</figcaption></div>]
      +[]<div class="ck-widget" contenteditable="false"><figcaption contenteditable="true">foo bar</figcaption></div>

    at Context.eval (webpack:///./packages/ckeditor5-widget/tests/widget-integration.js?:128:118)


    βœ– should does nothing for non-Safari browser
      Chrome 80.0.3987 (Mac OS X 10.15.2)
    AssertionError: expected '[<div class="ck-widget ck-widget_selected" contenteditable="false"><figcaption contenteditable="true">foo bar</figcaption></div>]' to equal '[]<div class="ck-widget" contenteditable="false"><figcaption contenteditable="true">foo bar</figcaption></div>'

      + expected - actual

      -[<div class="ck-widget ck-widget_selected" contenteditable="false"><figcaption contenteditable="true">foo bar</figcaption></div>]
      +[]<div class="ck-widget" contenteditable="false"><figcaption contenteditable="true">foo bar</figcaption></div>

    at Context.eval (webpack:///./packages/ckeditor5-widget/tests/widget-integration.js?:247:118)


Error: Karma finished with "1" code.
error Command failed with exit code 1.

OMFG...

@Reinmar
Copy link
Member

Reinmar commented Feb 6, 2020

@mlewand, could you check yarn run test -f core,engine,image,widget?

@mlewand
Copy link
Contributor

mlewand commented Feb 6, 2020

I even went ahead and ran the entire test suite, still, no issue:
image

@Reinmar
Copy link
Member

Reinmar commented Feb 6, 2020

Just perfect. So, I guess, we're waiting for a new Chrome version to patch that.

@Reinmar
Copy link
Member

Reinmar commented Feb 12, 2020

Let's merge this into #6222.

@Reinmar Reinmar closed this as completed Feb 12, 2020
@Reinmar Reinmar removed this from the iteration 29 milestone Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser:chrome type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

3 participants