-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The floating toolbar design #582
Comments
Note: the background of the page may be different. Whatever color we choose it will not fit all scenarios. I'd review the whole UI TBH (e.g. balloon panels for links). |
Hm... when you wrote this I realised that I had this feeling too, just not clear enough. Would stronger shadow help? |
Maybe some shadow and maybe simply inverted colors. It's unlikely the editor will be integrated into a web page with a black bg and white text. It would work in like 90% of cases. |
You went with a bit too dark colors (for my taste), but it sounds like a possible option. Although, I wonder how many people will prefer the bright (current) version cause, aesthetically speaking, I like it more. Also, I think we should wait for some feedback cause, after having second thoughts, I think that we may be overthinking this. |
Closed in #645. |
I was checking the ballon panel in a demo page:
Unfortunately, the lack of contrast of it, and also its design, probably, make it merge into the content, making it hard to see and use it. When playing of selecting text randomly, I was even confused on finding where the toolbar is, sometimes
I have the impression that the current design has been created on top of the classic editor and it works better there. But it seems to not be a good "universal" solution.
What do you think?
The text was updated successfully, but these errors were encountered: