Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The floating toolbar design #582

Closed
fredck opened this issue Oct 3, 2017 · 7 comments
Closed

The floating toolbar design #582

fredck opened this issue Oct 3, 2017 · 7 comments
Labels
type:improvement This issue reports a possible enhancement of an existing feature.
Milestone

Comments

@fredck
Copy link
Contributor

fredck commented Oct 3, 2017

I was checking the ballon panel in a demo page:

image

Unfortunately, the lack of contrast of it, and also its design, probably, make it merge into the content, making it hard to see and use it. When playing of selecting text randomly, I was even confused on finding where the toolbar is, sometimes

I have the impression that the current design has been created on top of the classic editor and it works better there. But it seems to not be a good "universal" solution.

What do you think?

@wwalc
Copy link
Member

wwalc commented Oct 3, 2017

Note: the background of the page may be different. Whatever color we choose it will not fit all scenarios. I'd review the whole UI TBH (e.g. balloon panels for links).

@Reinmar
Copy link
Member

Reinmar commented Oct 3, 2017

Hm... when you wrote this I realised that I had this feeling too, just not clear enough.

Would stronger shadow help?

@oleq
Copy link
Member

oleq commented Oct 3, 2017

Maybe some shadow and maybe simply inverted colors. It's unlikely the editor will be integrated into a web page with a black bg and white text. It would work in like 90% of cases.

@fredck
Copy link
Contributor Author

fredck commented Oct 3, 2017

It's almost like I've seen something like this out there already :D

image

@oleq
Copy link
Member

oleq commented Oct 3, 2017

LGTM in CKEditor too

image

@Reinmar Reinmar added candidate:1.0.0 type:improvement This issue reports a possible enhancement of an existing feature. labels Oct 9, 2017
@Reinmar
Copy link
Member

Reinmar commented Oct 9, 2017

You went with a bit too dark colors (for my taste), but it sounds like a possible option. Although, I wonder how many people will prefer the bright (current) version cause, aesthetically speaking, I like it more.

Also, I think we should wait for some feedback cause, after having second thoughts, I think that we may be overthinking this.

@oleq
Copy link
Member

oleq commented Mar 2, 2018

Closed in #645.

@oleq oleq closed this as completed Mar 2, 2018
@oleq oleq added this to the iteration 14 milestone Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

No branches or pull requests

4 participants