Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix branches coverage summary #51

Closed
pjasiun opened this issue Dec 30, 2015 · 2 comments
Closed

Fix branches coverage summary #51

pjasiun opened this issue Dec 30, 2015 · 2 comments
Milestone

Comments

@pjasiun
Copy link

pjasiun commented Dec 30, 2015

Because of the building we have one branch not covered in every file. Because of it, it is hard to check if all other branches are covered (each file has 75% - 98%, depending on the number of tests). Even if we will not be able to remove that line, it would be useful to ignore it in the coverage or fix the summary.

@Reinmar
Copy link
Member

Reinmar commented Dec 30, 2015

This will not be a problem any more once Istanbul 1.0 is released (gotwarlost/istanbul#212).

Before that... we would need to fork Babel modules and put a special comments in the helper templates. We'll need to fork them anyway, so perhaps we could also do this.

@Reinmar Reinmar changed the title Improve branches coverage summary Fix branches coverage summary Jan 18, 2016
@Reinmar
Copy link
Member

Reinmar commented May 18, 2016

In fact, we have this hotfixed by adding an ignore comment:

'/* istanbul ignore next */\n\t\t' +

It's fine for now, so I'm closing this ticket.

@Reinmar Reinmar closed this as completed May 18, 2016
@Reinmar Reinmar added this to the 0.1.0 milestone May 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants