-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the extend-template-render warning #5060
Labels
package:image
type:task
This issue reports a chore (non-production change) and other types of "todos".
Milestone
Comments
The problem is here: const panel = this._panel = new ImageBalloonPanel( editor );
const promises = [];
const toolbar = new ToolbarView();
// Add CSS class to the panel.
Template.extend( panel.template, {
attributes: {
class: [
'ck-toolbar__container'
]
}
} ); And... well, ping @oleq for a solution ;> |
The solution is: extend first, render next. And by "render", I mean "access |
Yeah, but what's accessing |
// Let the focusTracker know about new focusable UI element.
editor.ui.focusTracker.add( this.element ); This would need to be moved to init(). |
Reinmar
referenced
this issue
in ckeditor/ckeditor5-image
Feb 9, 2017
Fix: Moved focus tracking setup to `ImageBalloonPanelView#init()` method to prevent too early access to the view element. Closes #42.
mlewand
added
status:confirmed
type:task
This issue reports a chore (non-production change) and other types of "todos".
package:image
labels
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
package:image
type:task
This issue reports a chore (non-production change) and other types of "todos".
UI lib introduced a warning about extending already rendered templates and it turns out that the image feature logs a lot of them:
https://travis-ci.org/ckeditor/ckeditor5-image/builds/195804693#L1452
The text was updated successfully, but these errors were encountered: