Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider moving src/imagestyle/imagestyle to src/ #5045

Closed
Reinmar opened this issue Jan 13, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-image#61
Closed

Consider moving src/imagestyle/imagestyle to src/ #5045

Reinmar opened this issue Jan 13, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-image#61
Assignees
@Reinmar
Labels
package:image type:improvement This issue reports a possible enhancement of an existing feature. type:task This issue reports a chore (non-production change) and other types of "todos".
Milestone
iteration 8

Comments

@Reinmar
Copy link
Member

Reinmar commented Jan 13, 2017

I think that it'd be better (for discoverability) if features were directly in src/.
@Reinmar Reinmar self-assigned this Feb 24, 2017
Reinmar referenced this issue in ckeditor/ckeditor5-image Feb 24, 2017
@Reinmar
Merge pull request #61 from ckeditor/t/37
e38675f 
Other: Renamed "Image alternate text" to "Image text alternative" all across the code. Improved directory structure to have most important features in the top level of `src/`. Closes #37.

BREAKING CHANGES: The `src/imagealternatetext/imagealternatetext` module is now `src/imagetextalternative`. All other related classes and directories were renamed too.

BREAKING CHANGES: All the base image's util modules are now inside `src/image/`. The same applies to all other features. The main features are now directly in `src/`. Closes #33. Closes #26.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-image Oct 9, 2019
@mlewand mlewand added this to the iteration 8 milestone Oct 9, 2019
@mlewand mlewand added type:improvement This issue reports a possible enhancement of an existing feature. type:task This issue reports a chore (non-production change) and other types of "todos". package:image labels Oct 9, 2019
@Reinmar Reinmar mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Reinmar Reinmar

Labels
package:image type:improvement This issue reports a possible enhancement of an existing feature. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Milestone
iteration 8
Development

Successfully merging a pull request may close this issue.

Fixed various naming and directory structure issues ckeditor/ckeditor5-image
2 participants
@Reinmar @mlewand