Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview-Balloon rendering position wrong after creating a new link #4838

Closed
devRoemer opened this issue Jul 26, 2018 · 3 comments
Closed

Preview-Balloon rendering position wrong after creating a new link #4838

devRoemer opened this issue Jul 26, 2018 · 3 comments
Labels
package:link resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). type:bug This issue reports a buggy (incorrect) behavior.

Comments

@devRoemer
Copy link

With pull request ckeditor/ckeditor5-link#197 the render event has been replaced by an update event.

This introduced the following problems:

  • After creating a new link the balloon with a link preview is shown. This balloon is not positioned correctly anymore (it is visible at the beginning of the line)
  • If i leave the link on navigating across it with the arrow buttons the balloon stays open but shows the invalid link message.

The problem is that the update event is not triggered at all. (Maybe it is too late to register an update event on showing the balloon. For testing i changed the logic back to the "render" event and everything worked fine.

@Reinmar
Copy link
Member

Reinmar commented Jul 26, 2018

cc @oleq @oskarwrobel

@oleq
Copy link
Member

oleq commented Jul 26, 2018

@devRoemer

  1. Which browser do you use?
  2. How to reproduce the issue? A snippet in JSFiddle or CodePen would help us a lot.

@devRoemer
Copy link
Author

Sorry, false alarm - i just saw that i had an older version of ckeditor. No problem in version v11.0.0 anymore. Issue can be closed.

@mlewand mlewand transferred this issue from ckeditor/ckeditor5-link Oct 9, 2019
@mlewand mlewand added resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). type:bug This issue reports a buggy (incorrect) behavior. package:link labels Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:link resolution:invalid This issue is invalid (e.g. reports a non-existent bug or a by-design behavior). type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

4 participants