Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--ck-color-upload-bar-background should not be used with .ck-content #3423

Closed
oleq opened this issue Jul 31, 2019 · 2 comments · Fixed by ckeditor/ckeditor5-theme-lark#240
Closed

--ck-color-upload-bar-background should not be used with .ck-content #3423

oleq opened this issue Jul 31, 2019 · 2 comments · Fixed by ckeditor/ckeditor5-theme-lark#240
Assignees
@dkonopka

Comments

@oleq
Copy link
Member

oleq commented Jul 31, 2019

This custom property only makes sense when the editor is running. It's not a content style but editor UI style and should be defined as one (not under .ck-content).

Check out https://github.com/ckeditor/ckeditor5-theme-lark/blob/d8afbaeec1898f3f9ec0d35352697d2acd09441b/theme/ckeditor5-image/imageuploadprogress.css#L21

Spotted when working on #773.
@oleq
Copy link
Member Author

oleq commented Jul 31, 2019

@dkonopka, WDYT?

@dkonopka
Copy link
Contributor

Agree, definitely we should move it outside .ck-content. Besides that, working on this issue we could combine it with removal duplicated --ck-image-upload-progress-line-width from ckeditor5-image repo, see #1915

@dkonopka dkonopka self-assigned this Jul 31, 2019
oleq referenced this issue in ckeditor/ckeditor5-theme-lark Jul 31, 2019
@oleq
Merge pull request #240 from ckeditor/t/ckeditor5-theme-lark/239
cb92793 
Other: The `.ck-progress-bar` styles should not be under with `.ck-content`. Additionaly removed two unused custom properties: `--ck-color-upload-infinite-background` and `--ck-image-upload-progress-line-width`. Closes https://github.com/ckeditor/ckeditor5-theme-lark/issues/239. Closes ckeditor/ckeditor5#1915.
oleq referenced this issue in ckeditor/ckeditor5-image Jul 31, 2019
@oleq
Moved the .ck-progress-bar styles out of .ck-content scope because th…
6bee4a2 
…ey are runtime styles. See https://github.com/ckeditor/ckeditor5-theme-lark/issues/239.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-theme-lark Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkonopka dkonopka

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@oleq @dkonopka