Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EditingKeystrokeHandler should prevent default only for commands #2918

Closed
oleq opened this issue Jun 14, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-core#91
Closed

EditingKeystrokeHandler should prevent default only for commands #2918

oleq opened this issue Jun 14, 2017 · 0 comments · Fixed by ckeditor/ckeditor5-core#91
Assignees
@oleq
Labels
package:core type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 11

Comments

@oleq
Copy link
Member

oleq commented Jun 14, 2017

Use the generic preventDefault() in EKH for all command keystrokes and disable it for callbacks. Each callback will need to call cancel() in the listener if it actually handled the keystroke (e.g. Tab actually focused the link form). It looks clean to me.

A follow-up of #472 (comment).

Should also close #472.
@oleq oleq self-assigned this Jun 14, 2017
oleq referenced this issue in ckeditor/ckeditor5-core Jun 14, 2017
@oleq
Fix: EditingKeystrokeHandler should prevent default only for commands…
a867a4b 
…. Closes #90.
oleq referenced this issue in ckeditor/ckeditor5-basic-styles Jun 19, 2017
@oleq
Tests: Updated tests after tthe refactoring in the EditingKeystrokeHa…
1f314e9 
…ndler. See ckeditor/ckeditor5-core#90.
oleq referenced this issue in ckeditor/ckeditor5-undo Jun 19, 2017
@oleq
Tests: Updated tests after tthe refactoring in the EditingKeystrokeHa…
fe412d6 
…ndler. See ckeditor/ckeditor5-core#90.
Reinmar referenced this issue in ckeditor/ckeditor5-core Jun 20, 2017
@Reinmar
Merge pull request #91 from ckeditor/t/90
82ff39a 
Fix: `EditingKeystrokeHandler` should prevent default action only for commands. Closes #90.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-core Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:bug This issue reports a buggy (incorrect) behavior. package:core labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:core type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 11
Development

Successfully merging a pull request may close this issue.

t/90 EditingKeystrokeHandler should prevent default only for commands ckeditor/ckeditor5-core
2 participants
@oleq @mlewand