Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IconViews used in buttons should be marked as decorative since they lack accessible labels #17554

Closed
oleq opened this issue Nov 28, 2024 · 0 comments · Fixed by #17615
Closed
Assignees
Labels
domain:accessibility This issue reports an accessibility problem. intro Good first ticket. squad:collaboration Issue to be handled by the Collaboration team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@oleq
Copy link
Member

oleq commented Nov 28, 2024

📝 Provide detailed reproduction steps (if any)

Even though toolbar buttons have their own labels, the icons used inside don't, and accessing them individually, e.g. using the "virtual cursor" feature offered by assistive technologies presents an accessibility issue.

❓ Possible solution

Icons that are used as a decoration should come with an aria-hidden attribute.

Possible questions

Should all IconView get aria-hidden or just those used in buttons/menus/dropdowns/lists? Frankly, I don't remember any place using IconView for anything other than decoration but who knows (3rd-party). It might be a BC so it needs consideration.


If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@oleq oleq added domain:accessibility This issue reports an accessibility problem. type:bug This issue reports a buggy (incorrect) behavior. labels Nov 28, 2024
@oleq oleq self-assigned this Nov 28, 2024
@DawidKossowski DawidKossowski added intro Good first ticket. squad:collaboration Issue to be handled by the Collaboration team. labels Nov 29, 2024
@Witoso Witoso added the support:2 An issue reported by a commercially licensed client. label Dec 2, 2024
@CKEditorBot CKEditorBot added the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Dec 9, 2024
@f1ames f1ames closed this as completed in 513f8d3 Dec 10, 2024
@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Dec 10, 2024
@CKEditorBot CKEditorBot added this to the iteration 81 milestone Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:accessibility This issue reports an accessibility problem. intro Good first ticket. squad:collaboration Issue to be handled by the Collaboration team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
5 participants