[Edge, Safari] ckeditor5-editor-* CI jobs fail on 15th test

[Reinmar]

https://travis-ci.org/ckeditor/ckeditor5-editor-inline/jobs/521399249

My guess will be the memory leak tests make that browser unresponsive. I'd switch them off on Edge because its engine is dead anyway.

[Reinmar]

Those tests should be skipped when window.gc is not present:

function skipIfNoGarbageCollector() {
	before( function() {
		if ( !window.gc ) {
			this.skip();
		}
	} );
}

But maybe this object is available on Edge? :| Or I'm mistaken that this is about that test.

[Reinmar]

One more job: https://travis-ci.org/ckeditor/ckeditor5-editor-balloon/jobs/521399230

Here, both Safari and Edge failed:

I've just checked that this.skip() is either not called or it doesn't make the test abort from being executed (and just skips the results). We need to make sure those tests are not executed at all.

[pomek]

It is not about the GC. This test is invalid and breaks everything:

it( 'initializes with config.initialData', () => {
	return InlineEditor.create( editorElement, {
		initialData: '<p>Hello world!</p>',
		plugins: [ Paragraph ]
	} ).then( editor => {
		expect( editor.getData() ).to.equal( '<p>Hello world!</p>' );

		editor.destroy();
	} );
} );

[pomek]

It should be:

it( 'initializes with config.initialData', () => {
	const editorElement = document.createElement( 'div' );
	document.body.appendChild( editorElement );

	return InlineEditor.create( editorElement, {
		initialData: '<p>Hello world!</p>',
		plugins: [ Paragraph ]
	} ).then( editor => {
		expect( editor.getData() ).to.equal( '<p>Hello world!</p>' );

		editor.destroy();
		editorElement.remove();
	} );
} );

or even more correct solution:

it( 'initializes with config.initialData', () => {
	const editorElement = document.createElement( 'div' );
	document.body.appendChild( editorElement );

	return InlineEditor.create( editorElement, {
		initialData: '<p>Hello world!</p>',
		plugins: [ Paragraph ]
	} ).then( editor => {
		expect( editor.getData() ).to.equal( '<p>Hello world!</p>' );

		return editor.destroy();
	} ).then( () => {
		editorElement.remove();
	} );
} );

[pomek]

I assume that the editor does not know what to do. We passed initialData and we have HTML code as initial data in editorElement.

https://github.com/ckeditor/ckeditor5-editor-inline/blob/1f47051035b38fe049719fa062c75523d1a466c5/tests/inlineeditor.js#L33-L34

[pomek]

Because we removed BrowserStack from our CI (#1742 (comment)), could we agree that this ticket is no longer valid?

[pomek]

After removing BS, all tests pass. I am closing the ticket.