Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Drag & drop] Improve images preview #14744

Closed
Tracked by #13933
dagdzi opened this issue Aug 3, 2023 · 3 comments
Closed
Tracked by #13933

[Drag & drop] Improve images preview #14744

dagdzi opened this issue Aug 3, 2023 · 3 comments
Assignees
Labels
package:clipboard resolution:resolved This issue was already resolved (e.g. by another ticket). squad:core Issue to be handled by the Core team. type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@dagdzi
Copy link

dagdzi commented Aug 3, 2023

We want to improve the image preview (especially for large images) so that they do not cover the content during using drag and drop feature.

We have chosen the following approach: Image preview cannot be bigger than 50% of editor area.
The preview is smaller when the image is bigger than 50% of editor area, and the user drags the image by clicking on it.

In the Balloon block editor, when the user uses the drag handle to drag an image, the preview is the same size as the image size.

Figma prototype (click on the image to see the preview).


If you'd like to see this improvement implemented, add a 👍 reaction to this post.

@dagdzi dagdzi added type:improvement This issue reports a possible enhancement of an existing feature. package:clipboard squad:core Issue to be handled by the Core team. labels Aug 3, 2023
@dagdzi dagdzi mentioned this issue Aug 3, 2023
16 tasks
@Witoso
Copy link
Member

Witoso commented Aug 21, 2023

Image preview cannot be bigger than 50% of editor area.

@dagdzi do I understand correctly that if it's bigger than 50%, we resize the width of the image in preview to 50% of the editor's width.

@dagdzi
Copy link
Author

dagdzi commented Aug 28, 2023

@Witoso Yes, that's correct.

@CKEditorBot CKEditorBot added the status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. label Sep 11, 2023
@pszczesniak pszczesniak self-assigned this Sep 12, 2023
@CKEditorBot CKEditorBot added status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. and removed status:planned Set automatically when an issue lands in the "Sprint backlog" column. We will be working on it soon. labels Sep 12, 2023
@pszczesniak
Copy link
Contributor

Will be solved by #14968 (native browser solution was chosen).

@CKEditorBot CKEditorBot removed the status:in-progress Set automatically when an issue lands in the "In progress" column. We are working on it. label Sep 13, 2023
@Witoso Witoso added the resolution:resolved This issue was already resolved (e.g. by another ticket). label Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:clipboard resolution:resolved This issue was already resolved (e.g. by another ticket). squad:core Issue to be handled by the Core team. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants