Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add width and height attribute to img element in "Simple upload adapter" #10324

Closed
doanhquang2005 opened this issue Aug 8, 2021 · 2 comments
Closed
Labels
resolution:resolved This issue was already resolved (e.g. by another ticket). squad:core Issue to be handled by the Core team. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).

Comments

@doanhquang2005
Copy link

In lighthouse Chrome:
Image elements do not have explicit width and height
Set an explicit width and height on image elements to reduce layout shifts and improve CLS. Learn moreCLS

Is there any solution to solve the above problem with "Simple upload adapter"?

@doanhquang2005 doanhquang2005 added the type:feature This issue reports a feature request (an idea for a new functionality or a missing option). label Aug 8, 2021
@Reinmar Reinmar added the squad:core Issue to be handled by the Core team. label Aug 10, 2021
@mmichaelis
Copy link

I assume, this is related to current restrictions, that width/height cannot be set for an image. For reference, see for example:

@Witoso
Copy link
Member

Witoso commented Sep 21, 2023

🎉 This feature was merged to the master and is available on the nightly releases and nightly docs to test.

After the release, width and heigh will be set automatically after the upload.

In a comment in another issue, you can find more details about the changes.

@Witoso Witoso closed this as completed Sep 21, 2023
@Witoso Witoso added the resolution:resolved This issue was already resolved (e.g. by another ticket). label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution:resolved This issue was already resolved (e.g. by another ticket). squad:core Issue to be handled by the Core team. type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Development

No branches or pull requests

4 participants