Merge pull request #197 from ckeditor/t/193

Fix: Removed a period at the end of an error message because some browsers included the period in links to errors. Closes #193.
ckeditor · Nov 9, 2017 · fdebc2f · fdebc2f
2 parents ab11565 + c0dc863
commit fdebc2f
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/src/ckeditorerror.js b/src/ckeditorerror.js
@@ -82,5 +82,5 @@ export function attachLinkToDocumentation( message ) {
 		return message;
 	}
 
-	return message + ` Read more: ${ DOCUMENTATION_URL }#${ matchedErrorName[ 1 ] }.\n`;
+	return message + ` Read more: ${ DOCUMENTATION_URL }#${ matchedErrorName[ 1 ] }\n`;
 }
diff --git a/tests/ckeditorerror.js b/tests/ckeditorerror.js
@@ -56,7 +56,7 @@ describe( 'CKEditorError', () => {
 		const error = new CKEditorError( 'model-schema-no-item: Specified item cannot be found.' );
 
 		const errorMessage = 'model-schema-no-item: Specified item cannot be found. ' +
-			`Read more: ${ DOCUMENTATION_URL }#model-schema-no-item.\n`;
+			`Read more: ${ DOCUMENTATION_URL }#model-schema-no-item\n`;
 
 		expect( error ).to.have.property( 'message', errorMessage );
 	} );
@@ -65,7 +65,7 @@ describe( 'CKEditorError', () => {
 		const error = new CKEditorError( 'model-schema-no-item: Specified item cannot be found.', { foo: 1, bar: 2 } );
 
 		const errorMessage = 'model-schema-no-item: Specified item cannot be found. ' +
-			`Read more: ${ DOCUMENTATION_URL }#model-schema-no-item.\n ` +
+			`Read more: ${ DOCUMENTATION_URL }#model-schema-no-item\n ` +
 			'{"foo":1,"bar":2}';
 
 		expect( error ).to.have.property( 'message', errorMessage );

diff --git a/tests/log.js b/tests/log.js
@@ -38,7 +38,7 @@ describe( 'log', () => {
 			log.warn( 'model-schema-no-item: Specified item cannot be found.' );
 
 			const logMessage = 'model-schema-no-item: Specified item cannot be found. ' +
-				`Read more: ${ DOCUMENTATION_URL }#model-schema-no-item.\n`;
+				`Read more: ${ DOCUMENTATION_URL }#model-schema-no-item\n`;
 
 			sinon.assert.calledOnce( spy );
 			sinon.assert.calledWith( spy, logMessage );
@@ -66,7 +66,7 @@ describe( 'log', () => {
 			log.error( 'model-schema-no-item: Specified item cannot be found.' );
 
 			const logMessage = 'model-schema-no-item: Specified item cannot be found. ' +
-				`Read more: ${ DOCUMENTATION_URL }#model-schema-no-item.\n`;
+				`Read more: ${ DOCUMENTATION_URL }#model-schema-no-item\n`;
 
 			sinon.assert.calledOnce( spy );
 			sinon.assert.calledWith( spy, logMessage );