From a145cfb92472b5af5dff8eddf9e3b10dfcc2871c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maciej=20Go=C5=82aszewski?= Date: Thu, 20 Feb 2020 16:14:47 +0100 Subject: [PATCH 1/4] Add eslint-plugin-mocha to eslint configuration. --- packages/eslint-config-ckeditor5/.eslintrc.js | 14 +++- packages/eslint-config-ckeditor5/package.json | 3 +- yarn.lock | 79 +++++++------------ 3 files changed, 41 insertions(+), 55 deletions(-) diff --git a/packages/eslint-config-ckeditor5/.eslintrc.js b/packages/eslint-config-ckeditor5/.eslintrc.js index c1b676954..a1ad85760 100644 --- a/packages/eslint-config-ckeditor5/.eslintrc.js +++ b/packages/eslint-config-ckeditor5/.eslintrc.js @@ -20,7 +20,8 @@ module.exports = { sinon: true }, plugins: [ - 'ckeditor5-rules' + 'ckeditor5-rules', + 'mocha' ], rules: { // ## Possible errors @@ -296,6 +297,15 @@ module.exports = { "error", "after" ], - 'ckeditor5-rules/no-relative-imports': 'error' + 'ckeditor5-rules/no-relative-imports': 'error', + 'mocha/handle-done-callback': 'error', + 'mocha/no-async-describe': 'error', + 'mocha/no-exclusive-tests': 'error', + 'mocha/no-global-tests': 'error', + 'mocha/no-identical-title': 'warn', + 'mocha/no-nested-tests': 'error', + 'mocha/no-pending-tests': 'error', + 'mocha/no-sibling-hooks': 'error', + 'mocha/no-top-level-hooks': 'error' } }; diff --git a/packages/eslint-config-ckeditor5/package.json b/packages/eslint-config-ckeditor5/package.json index 0821cb813..3071e1032 100644 --- a/packages/eslint-config-ckeditor5/package.json +++ b/packages/eslint-config-ckeditor5/package.json @@ -12,7 +12,8 @@ ], "main": ".eslintrc.js", "dependencies": { - "eslint-plugin-ckeditor5-rules": "^0.0.4" + "eslint-plugin-ckeditor5-rules": "^0.0.4", + "eslint-plugin-mocha": "^6.3.0" }, "peerDependencies": { "eslint": ">=3.0.0" diff --git a/yarn.lock b/yarn.lock index 3a1e46789..c311e981c 100644 --- a/yarn.lock +++ b/yarn.lock @@ -3193,11 +3193,6 @@ deep-eql@^3.0.1: dependencies: type-detect "^4.0.0" -deep-extend@^0.6.0: - version "0.6.0" - resolved "https://registry.yarnpkg.com/deep-extend/-/deep-extend-0.6.0.tgz#c4fa7c95404a17a9c3e8ca7e1537312b736330ac" - integrity sha512-LOHxIOaPYdHlJRtCQfDIVZtfw/ufM8+rVj649RIHzcm/vGwQRXFt6OPqIFWsm2XEMrNIEtWR64sY1LEKD2vAOA== - deep-is@~0.1.3: version "0.1.3" resolved "https://registry.yarnpkg.com/deep-is/-/deep-is-0.1.3.tgz#b369d6fb5dbc13eecf524f91b070feedc357cf34" @@ -3324,11 +3319,6 @@ detect-indent@^5.0.0: resolved "https://registry.yarnpkg.com/detect-indent/-/detect-indent-5.0.0.tgz#3871cc0a6a002e8c3e5b3cf7f336264675f06b9d" integrity sha1-OHHMCmoALow+Wzz38zYmRnXwa50= -detect-libc@^1.0.2: - version "1.0.3" - resolved "https://registry.yarnpkg.com/detect-libc/-/detect-libc-1.0.3.tgz#fa137c4bd698edf55cd5cd02ac559f91a4c4ba9b" - integrity sha1-+hN8S9aY7fVc1c0CrFWfkaTEups= - dezalgo@^1.0.0: version "1.0.3" resolved "https://registry.yarnpkg.com/dezalgo/-/dezalgo-1.0.3.tgz#7f742de066fc748bc8db820569dddce49bf0d456" @@ -3725,6 +3715,14 @@ escodegen@^1.9.0: optionalDependencies: source-map "~0.6.1" +eslint-plugin-mocha@^6.3.0: + version "6.3.0" + resolved "https://registry.yarnpkg.com/eslint-plugin-mocha/-/eslint-plugin-mocha-6.3.0.tgz#72bfd06a5c4323e17e30ef41cd726030e8cdb8fd" + integrity sha512-Cd2roo8caAyG21oKaaNTj7cqeYRWW1I2B5SfpKRp0Ip1gkfwoR1Ow0IGlPWnNjzywdF4n+kHL8/9vM6zCJUxdg== + dependencies: + eslint-utils "^2.0.0" + ramda "^0.27.0" + eslint-scope@^4.0.3: version "4.0.3" resolved "https://registry.yarnpkg.com/eslint-scope/-/eslint-scope-4.0.3.tgz#ca03833310f6889a3264781aa82e63eb9cfe7848" @@ -3740,6 +3738,13 @@ eslint-utils@^1.3.1: dependencies: eslint-visitor-keys "^1.1.0" +eslint-utils@^2.0.0: + version "2.0.0" + resolved "https://registry.yarnpkg.com/eslint-utils/-/eslint-utils-2.0.0.tgz#7be1cc70f27a72a76cd14aa698bcabed6890e1cd" + integrity sha512-0HCPuJv+7Wv1bACm8y5/ECVfYdfsAm9xmVb7saeFlxjPYALefjhbYoCkBjPdPzGH8wWyTpAez82Fh3VKYEZ8OA== + dependencies: + eslint-visitor-keys "^1.1.0" + eslint-visitor-keys@^1.0.0, eslint-visitor-keys@^1.1.0: version "1.1.0" resolved "https://registry.yarnpkg.com/eslint-visitor-keys/-/eslint-visitor-keys-1.1.0.tgz#e2a82cea84ff246ad6fb57f9bde5b46621459ec2" @@ -4810,7 +4815,7 @@ husky@^0.14.3: normalize-path "^1.0.0" strip-indent "^2.0.0" -iconv-lite@0.4.24, iconv-lite@^0.4.24, iconv-lite@^0.4.4, iconv-lite@~0.4.13: +iconv-lite@0.4.24, iconv-lite@^0.4.24, iconv-lite@~0.4.13: version "0.4.24" resolved "https://registry.yarnpkg.com/iconv-lite/-/iconv-lite-0.4.24.tgz#2022b4b25fbddc21d2f524974a474aafe733908b" integrity sha512-v3MXnZAcvnywkTUEZomIActle7RXXeedOR31wwl7VlyoXO4Qi9arvSenNQWne1TcRwhCL1HwLI21bEqdpj8/rA== @@ -4947,7 +4952,7 @@ inherits@2.0.3: resolved "https://registry.yarnpkg.com/inherits/-/inherits-2.0.3.tgz#633c2c83e3da42a502f52466022480f4208261de" integrity sha1-Yzwsg+PaQqUC9SRmAiSA9CCCYd4= -ini@^1.3.2, ini@^1.3.4, ini@~1.3.0: +ini@^1.3.2, ini@^1.3.4: version "1.3.5" resolved "https://registry.yarnpkg.com/ini/-/ini-1.3.5.tgz#eee25f56db1c9ec6085e0c22778083f596abf927" integrity sha512-RZY5huIKCMRWDUqZlEi72f/lmXKMvuszcMBduliQ3nnWbx9X/ZBQO7DijMEYS9EhHBb2qacRUMtC7svLwe0lcw== @@ -6592,15 +6597,6 @@ natural-compare@^1.4.0: resolved "https://registry.yarnpkg.com/natural-compare/-/natural-compare-1.4.0.tgz#4abebfeed7541f2c27acfb29bdbbd15c8d5ba4f7" integrity sha1-Sr6/7tdUHywnrPspvbvRXI1bpPc= -needle@^2.2.1: - version "2.4.0" - resolved "https://registry.yarnpkg.com/needle/-/needle-2.4.0.tgz#6833e74975c444642590e15a750288c5f939b57c" - integrity sha512-4Hnwzr3mi5L97hMYeNl8wRW/Onhy4nUKR/lVemJ8gJedxxUyBLm9kkrDColJvoSfwi0jCNhD+xCdOtiGDQiRZg== - dependencies: - debug "^3.2.6" - iconv-lite "^0.4.4" - sax "^1.2.4" - negotiator@0.6.2: version "0.6.2" resolved "https://registry.yarnpkg.com/negotiator/-/negotiator-0.6.2.tgz#feacf7ccf525a77ae9634436a64883ffeca346fb" @@ -6700,22 +6696,6 @@ node-libs-browser@^2.2.1: util "^0.11.0" vm-browserify "^1.0.1" -node-pre-gyp@*: - version "0.14.0" - resolved "https://registry.yarnpkg.com/node-pre-gyp/-/node-pre-gyp-0.14.0.tgz#9a0596533b877289bcad4e143982ca3d904ddc83" - integrity sha512-+CvDC7ZttU/sSt9rFjix/P05iS43qHCOOGzcr3Ry99bXG7VX953+vFyEuph/tfqoYu8dttBkE86JSKBO2OzcxA== - dependencies: - detect-libc "^1.0.2" - mkdirp "^0.5.1" - needle "^2.2.1" - nopt "^4.0.1" - npm-packlist "^1.1.6" - npmlog "^4.0.2" - rc "^1.2.7" - rimraf "^2.6.1" - semver "^5.3.0" - tar "^4.4.2" - node-releases@^1.1.44: version "1.1.45" resolved "https://registry.yarnpkg.com/node-releases/-/node-releases-1.1.45.tgz#4cf7e9175d71b1317f15ffd68ce63bce1d53e9f2" @@ -6820,7 +6800,7 @@ npm-normalize-package-bin@^1.0.0, npm-normalize-package-bin@^1.0.1: semver "^5.6.0" validate-npm-package-name "^3.0.0" -npm-packlist@^1.1.6, npm-packlist@^1.4.4: +npm-packlist@^1.4.4: version "1.4.7" resolved "https://registry.yarnpkg.com/npm-packlist/-/npm-packlist-1.4.7.tgz#9e954365a06b80b18111ea900945af4f88ed4848" integrity sha512-vAj7dIkp5NhieaGZxBJB8fF4R0078rqsmhJcAfXZ6O7JJhjhPK96n5Ry1oZcfLXgfun0GWTZPOxaEyqv8GBykQ== @@ -6860,7 +6840,7 @@ npm-which@^3.0.1: npm-path "^2.0.2" which "^1.2.10" -npmlog@^4.0.2, npmlog@^4.1.2: +npmlog@^4.1.2: version "4.1.2" resolved "https://registry.yarnpkg.com/npmlog/-/npmlog-4.1.2.tgz#08a7f2a8bf734604779a9efa4ad5cc717abb954b" integrity sha512-2uUqazuKlTaSI/dC8AzicUck7+IrEaOnN/e0jd3Xtt1KcGpwx30v50mL7oPyr/h9bL3E4aZccVwpwP+5W9Vjkg== @@ -7919,6 +7899,11 @@ quick-lru@^1.0.0: resolved "https://registry.yarnpkg.com/quick-lru/-/quick-lru-1.1.0.tgz#4360b17c61136ad38078397ff11416e186dcfbb8" integrity sha1-Q2CxfGETatOAeDl/8RQW4Ybc+7g= +ramda@^0.27.0: + version "0.27.0" + resolved "https://registry.yarnpkg.com/ramda/-/ramda-0.27.0.tgz#915dc29865c0800bf3f69b8fd6c279898b59de43" + integrity sha512-pVzZdDpWwWqEVVLshWUHjNwuVP7SfcmPraYuqocJp1yo2U1R7P+5QAfDhdItkuoGqIBnBYrtPp7rEPqDn9HlZA== + randombytes@^2.0.0, randombytes@^2.0.1, randombytes@^2.0.5: version "2.1.0" resolved "https://registry.yarnpkg.com/randombytes/-/randombytes-2.1.0.tgz#df6f84372f0270dc65cdf6291349ab7a473d4f2a" @@ -7957,16 +7942,6 @@ raw-loader@^3.1.0: loader-utils "^1.1.0" schema-utils "^2.0.1" -rc@^1.2.7: - version "1.2.8" - resolved "https://registry.yarnpkg.com/rc/-/rc-1.2.8.tgz#cd924bf5200a075b83c188cd6b9e211b7fc0d3ed" - integrity sha512-y3bGgqKj3QBdxLbLkomlohkvsA8gdAiUQlSBJnBhfn+BPxg4bc62d8TcBW15wavDfgexCgccckhcZvywyQYPOw== - dependencies: - deep-extend "^0.6.0" - ini "~1.3.0" - minimist "^1.2.0" - strip-json-comments "~2.0.1" - read-cache@^1.0.0: version "1.0.0" resolved "https://registry.yarnpkg.com/read-cache/-/read-cache-1.0.0.tgz#e664ef31161166c9751cdbe8dbcf86b5fb58f774" @@ -8323,7 +8298,7 @@ rimraf@2.6.3: dependencies: glob "^7.1.3" -rimraf@^2.5.4, rimraf@^2.6.0, rimraf@^2.6.1, rimraf@^2.6.2, rimraf@^2.6.3: +rimraf@^2.5.4, rimraf@^2.6.0, rimraf@^2.6.2, rimraf@^2.6.3: version "2.7.1" resolved "https://registry.yarnpkg.com/rimraf/-/rimraf-2.7.1.tgz#35797f13a7fdadc566142c29d4f07ccad483e3ec" integrity sha512-uWjbaKIK3T1OSVptzX7Nl6PvQ3qAGtKEtVRjRuazjfL3Bx5eI409VZSqgND+4UNnmzLVdPj9FqFJNPqBZFve4w== @@ -8393,7 +8368,7 @@ safe-regex@^1.1.0: resolved "https://registry.yarnpkg.com/safer-buffer/-/safer-buffer-2.1.2.tgz#44fa161b0187b9549dd84bb91802f9bd8385cd6a" integrity sha512-YZo3K82SD7Riyi0E1EQPojLz7kpepnSQI9IyPbHHg1XXXevb5dJI7tpyN2ADxGcQbHG7vcyRHk0cbwqcQriUtg== -sax@^1.2.4, sax@~1.2.4: +sax@~1.2.4: version "1.2.4" resolved "https://registry.yarnpkg.com/sax/-/sax-1.2.4.tgz#2816234e2378bddc4e5354fab5caa895df7100d9" integrity sha512-NqVDv9TpANUjFm0N8uM5GxL36UgKi9/atZw+x7YFnQ8ckwFGKrl4xX4yWtrey3UJm5nP1kUbnYgLopqWNSRhWw== @@ -9135,7 +9110,7 @@ tapable@^1.0.0, tapable@^1.1.3: resolved "https://registry.yarnpkg.com/tapable/-/tapable-1.1.3.tgz#a1fccc06b58db61fd7a45da2da44f5f3a3e67ba2" integrity sha512-4WK/bYZmj8xLr+HUCODHGF1ZFzsYffasLUgEiMBY4fgtltdO6B4WJtlSbPaDTLpYTcGVwM2qLnFTICEcNxs3kA== -tar@^4.4.10, tar@^4.4.12, tar@^4.4.2, tar@^4.4.8: +tar@^4.4.10, tar@^4.4.12, tar@^4.4.8: version "4.4.13" resolved "https://registry.yarnpkg.com/tar/-/tar-4.4.13.tgz#43b364bc52888d555298637b10d60790254ab525" integrity sha512-w2VwSrBoHa5BsSyH+KxEqeQBAllHhccyMFVHtGtdMpF4W7IRWfZjFiQceJPChOeTsSDVUpER2T8FA93pr0L+QA== From 76db6f79a70d0684bbe14f1c81b661339f26f26f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maciej=20Go=C5=82aszewski?= Date: Fri, 21 Feb 2020 12:59:08 +0100 Subject: [PATCH 2/4] Disallow dangling comma. --- packages/eslint-config-ckeditor5/.eslintrc.js | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/eslint-config-ckeditor5/.eslintrc.js b/packages/eslint-config-ckeditor5/.eslintrc.js index a1ad85760..7bbb781ea 100644 --- a/packages/eslint-config-ckeditor5/.eslintrc.js +++ b/packages/eslint-config-ckeditor5/.eslintrc.js @@ -116,6 +116,7 @@ module.exports = { 'properties': 'never' } ], + 'comma-dangle': [ 'error', 'never' ], 'comma-spacing': [ 'error', { From 7d744c450ad5822fc49a8647cec8464c5fd73eee Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maciej=20Go=C5=82aszewski?= Date: Fri, 21 Feb 2020 12:59:47 +0100 Subject: [PATCH 3/4] Use single quotes. --- packages/eslint-config-ckeditor5/.eslintrc.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/eslint-config-ckeditor5/.eslintrc.js b/packages/eslint-config-ckeditor5/.eslintrc.js index 7bbb781ea..be0ae2994 100644 --- a/packages/eslint-config-ckeditor5/.eslintrc.js +++ b/packages/eslint-config-ckeditor5/.eslintrc.js @@ -271,9 +271,9 @@ module.exports = { 'arrow-spacing': 'error', // This is too pedantic. It makes writing callbacks such as `value => value ? 1 : 2` impossible // 'no-confusing-arrow': 'error', - "generator-star-spacing": [ - "error", - "after" + 'generator-star-spacing': [ + 'error', + 'after' ], 'no-duplicate-imports': 'error', 'no-useless-computed-key': 'error', @@ -294,9 +294,9 @@ module.exports = { 'error', 'always' ], - "yield-star-spacing": [ - "error", - "after" + 'yield-star-spacing': [ + 'error', + 'after' ], 'ckeditor5-rules/no-relative-imports': 'error', 'mocha/handle-done-callback': 'error', From 6185ce89a201eeba86b1a87fb6f9fec6cf56a8ec Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maciej=20Go=C5=82aszewski?= Date: Fri, 21 Feb 2020 15:57:46 +0100 Subject: [PATCH 4/4] Fix ESLint issues. --- .../tasks/generatesummarychangelog.js | 4 +- .../lib/release-tools/utils/cli.js | 10 +- .../utils/getpackagestorelease.js | 2 +- .../lib/translations/collect-utils.js | 2 +- packages/ckeditor5-dev-env/tests/index.js | 6 +- .../generatechangelogforsinglepackage.js | 2 +- .../tasks/generatechangelogforsubpackages.js | 6 +- .../tasks/generatesummarychangelog.js | 4 +- .../tests/release-tools/templates/commit.js | 2 +- .../release-tools/utils/executeonpackages.js | 4 +- ...eneratechangelogfromcommits-integration.js | 2 +- .../utils/getpackagestorelease.js | 2 +- .../utils/getsubpackagespaths.js | 6 +- .../utils/getsubrepositoriespaths.js | 12 +-- .../getchangedfilesforcommit.js | 14 ++- .../transformcommitforsubpackagefactory.js | 4 +- .../transformcommitforsubrepositoryfactory.js | 4 +- .../utils/updatedependenciesversions.js | 2 +- .../tests/translations/collect-utils.js | 8 +- .../tests/translations/collect.js | 2 +- .../tests/translations/download.js | 4 +- .../tests/translations/transifex-service.js | 6 +- .../tests/translations/upload.js | 4 +- .../bin/notify-travis-status.js | 6 +- packages/ckeditor5-dev-tests/lib/index.js | 2 +- .../utils/automated-tests/getwebpackconfig.js | 2 +- .../utils/automated-tests/leaksdetector.js | 2 + .../utils/manual-tests/getwebpackconfig.js | 2 +- .../tests/tasks/runautomatedtests.js | 10 +- .../tests/tasks/runmanualtests.js | 2 +- .../utils/automated-tests/getwebpackconfig.js | 10 +- .../utils/manual-tests/compilescripts.js | 6 +- .../lib/styles/getpostcssconfig.js | 2 +- .../lib/styles/themeimporter.js | 2 +- .../lib/translations/cleanpofilecontent.js | 4 +- .../tests/bundler/createentryfile.js | 2 +- .../tests/bundler/getplugins.js | 2 +- packages/ckeditor5-dev-utils/tests/git.js | 4 +- .../createdictionaryfrompofilecontent.js | 2 +- .../tests/translations/findoriginalstrings.js | 2 +- .../multiplelanguagetranslationservice.js | 14 +-- .../tests/ckeditor5-env-utils.js | 6 +- .../jsdoc-plugins/lib/custom-tags/error.js | 2 +- .../fixers/fix-incorrect-class-longname.js | 4 +- .../longname-fixer/fixers/fix-short-refs.js | 8 +- .../lib/longname-fixer/longname-fixer.js | 2 +- .../lib/validator/doclet-validator.js | 6 +- packages/jsdoc-plugins/lib/validator/types.js | 2 +- packages/jsdoc-plugins/tests/doclet-utils.js | 10 +- .../jsdoc-plugins/tests/doclet-validator.js | 100 +++++++++--------- .../tests/fix-interfaces-and-classes.js | 32 +++--- packages/jsdoc-plugins/tests/fix-links.js | 24 ++--- .../tests/integration-tests/data/mixin.jsdoc | 2 +- .../integration-tests/utils/parsefiles.js | 2 +- .../test-data/inheritance-implicit.js | 2 +- .../tests/relation-fixer/test-data/mixins.js | 2 +- .../test-data/unwanted-doclets.js | 2 +- 57 files changed, 197 insertions(+), 197 deletions(-) diff --git a/packages/ckeditor5-dev-env/lib/release-tools/tasks/generatesummarychangelog.js b/packages/ckeditor5-dev-env/lib/release-tools/tasks/generatesummarychangelog.js index a19600d31..1ec324c2a 100644 --- a/packages/ckeditor5-dev-env/lib/release-tools/tasks/generatesummarychangelog.js +++ b/packages/ckeditor5-dev-env/lib/release-tools/tasks/generatesummarychangelog.js @@ -138,7 +138,7 @@ module.exports = function generateSummaryChangelog( options ) { dependencies, newVersion: version, currentVersion: packageJson.version, - repositoryUrl: packageJson.repository.url.replace( /\.git$/, '' ), + repositoryUrl: packageJson.repository.url.replace( /\.git$/, '' ) } ); // Additional notes for changelog generated from commits should be added if any dependency has been added or changed. @@ -368,7 +368,7 @@ module.exports = function generateSummaryChangelog( options ) { const entries = [ // eslint-disable-next-line max-len `## [${ options.newVersion }](${ options.repositoryUrl }/compare/v${ options.currentVersion }...v${ options.newVersion }) (${ date })`, - '', + '' ]; const allowBreakingChangeInMinor = areBreakingChangesAcceptableInVersion( options.newVersion ); diff --git a/packages/ckeditor5-dev-env/lib/release-tools/utils/cli.js b/packages/ckeditor5-dev-env/lib/release-tools/utils/cli.js index 5bc4d402e..4ec3d8c6d 100644 --- a/packages/ckeditor5-dev-env/lib/release-tools/utils/cli.js +++ b/packages/ckeditor5-dev-env/lib/release-tools/utils/cli.js @@ -45,7 +45,7 @@ const cli = { message, type: 'confirm', name: 'confirm', - default: true, + default: true }; return inquirer.prompt( [ confirmQuestion ] ) @@ -95,7 +95,7 @@ const cli = { message, type: 'confirm', name: 'confirm', - default: true, + default: true }; return inquirer.prompt( [ confirmQuestion ] ) @@ -112,7 +112,7 @@ const cli = { message: 'Remove created archives?', type: 'confirm', name: 'confirm', - default: true, + default: true }; return inquirer.prompt( [ confirmQuestion ] ) @@ -309,12 +309,12 @@ const cli = { type: 'confirm', name: 'confirm', prefix: getPrefix( indentLevel ), - default: haveMajorBreakingChangeCommits, + default: haveMajorBreakingChangeCommits }; return inquirer.prompt( [ confirmQuestion ] ) .then( answers => answers.confirm ); - }, + } }; module.exports = cli; diff --git a/packages/ckeditor5-dev-env/lib/release-tools/utils/getpackagestorelease.js b/packages/ckeditor5-dev-env/lib/release-tools/utils/getpackagestorelease.js index 5032c6b9b..77526deab 100644 --- a/packages/ckeditor5-dev-env/lib/release-tools/utils/getpackagestorelease.js +++ b/packages/ckeditor5-dev-env/lib/release-tools/utils/getpackagestorelease.js @@ -39,7 +39,7 @@ module.exports = function getPackagesToRelease( pathsToPackages ) { if ( gitVersion !== changelogVersion ) { packagesToRelease.set( repositoryName, { previousVersion: packageJson.version, - version: changelogVersion, + version: changelogVersion } ); } diff --git a/packages/ckeditor5-dev-env/lib/translations/collect-utils.js b/packages/ckeditor5-dev-env/lib/translations/collect-utils.js index 970c234f2..397c79413 100644 --- a/packages/ckeditor5-dev-env/lib/translations/collect-utils.js +++ b/packages/ckeditor5-dev-env/lib/translations/collect-utils.js @@ -176,7 +176,7 @@ const utils = { key: originalString, package: packageMatch[ 1 ], context: contextMatch ? contextMatch[ 1 ] : null, - sentence: sentenceMatch[ 0 ].trim(), + sentence: sentenceMatch[ 0 ].trim() }; } ) .filter( translationCall => !!translationCall ); diff --git a/packages/ckeditor5-dev-env/tests/index.js b/packages/ckeditor5-dev-env/tests/index.js index 4b7ae8227..c2ac1b7c5 100644 --- a/packages/ckeditor5-dev-env/tests/index.js +++ b/packages/ckeditor5-dev-env/tests/index.js @@ -41,7 +41,7 @@ describe( 'dev-env/index', () => { generateChangelogForSubPackages: sandbox.stub(), generateChangelogForSubRepositories: sandbox.stub(), generateSummaryChangelog: sandbox.stub(), - bumpVersions: sandbox.stub(), + bumpVersions: sandbox.stub() } }; @@ -182,7 +182,7 @@ describe( 'dev-env/index', () => { return tasks.uploadTranslations().then( () => { sinon.assert.calledOnce( stubs.translations.upload ); sinon.assert.alwaysCalledWithExactly( stubs.translations.upload, { - token: 'token', + token: 'token' } ); } ); } ); @@ -195,7 +195,7 @@ describe( 'dev-env/index', () => { return tasks.downloadTranslations().then( () => { sinon.assert.calledOnce( stubs.translations.download ); sinon.assert.alwaysCalledWithExactly( stubs.translations.download, { - token: 'token', + token: 'token' } ); } ); } ); diff --git a/packages/ckeditor5-dev-env/tests/release-tools/tasks/generatechangelogforsinglepackage.js b/packages/ckeditor5-dev-env/tests/release-tools/tasks/generatechangelogforsinglepackage.js index 8c86f2ff6..9cfe78743 100644 --- a/packages/ckeditor5-dev-env/tests/release-tools/tasks/generatechangelogforsinglepackage.js +++ b/packages/ckeditor5-dev-env/tests/release-tools/tasks/generatechangelogforsinglepackage.js @@ -20,7 +20,7 @@ describe( 'dev-env/release-tools/tasks', () => { stubs = { changelogUtils: { - changelogFile: changelogUtils.changelogFile, + changelogFile: changelogUtils.changelogFile }, getNewReleaseType: sandbox.stub(), displayCommits: sandbox.stub(), diff --git a/packages/ckeditor5-dev-env/tests/release-tools/tasks/generatechangelogforsubpackages.js b/packages/ckeditor5-dev-env/tests/release-tools/tasks/generatechangelogforsubpackages.js index a738e8496..1708cd629 100644 --- a/packages/ckeditor5-dev-env/tests/release-tools/tasks/generatechangelogforsubpackages.js +++ b/packages/ckeditor5-dev-env/tests/release-tools/tasks/generatechangelogforsubpackages.js @@ -32,7 +32,7 @@ describe( 'dev-env/release-tools/tasks', () => { generateChangelogFromCommits: sandbox.stub(), getPackageJson: sandbox.stub(), changelogUtils: { - changelogFile: 'CHANGELOG.md', + changelogFile: 'CHANGELOG.md' }, getNewReleaseType: sandbox.stub(), displayCommits: sandbox.stub(), @@ -200,7 +200,7 @@ describe( 'dev-env/release-tools/tasks', () => { '/ckeditor5-dev/packages/ckeditor5-dev-bar' ] ), matched: new Set( [ - '/ckeditor5-dev/packages/ckeditor5-dev-foo', + '/ckeditor5-dev/packages/ckeditor5-dev-foo' ] ) } ); @@ -252,7 +252,7 @@ describe( 'dev-env/release-tools/tasks', () => { stubs.getSubPackagesPaths.returns( { skipped: new Set(), matched: new Set( [ - '/ckeditor5-dev/packages/ckeditor5-dev-foo', + '/ckeditor5-dev/packages/ckeditor5-dev-foo' ] ) } ); diff --git a/packages/ckeditor5-dev-env/tests/release-tools/tasks/generatesummarychangelog.js b/packages/ckeditor5-dev-env/tests/release-tools/tasks/generatesummarychangelog.js index 0e7e15040..e12b6c15b 100644 --- a/packages/ckeditor5-dev-env/tests/release-tools/tasks/generatesummarychangelog.js +++ b/packages/ckeditor5-dev-env/tests/release-tools/tasks/generatesummarychangelog.js @@ -48,10 +48,10 @@ describe( 'dev-env/release-tools/tasks', () => { }, versionUtils: { getLastFromChangelog: sandbox.stub(), - getCurrent: sandbox.stub(), + getCurrent: sandbox.stub() }, cliUtils: { - provideVersion: sandbox.stub(), + provideVersion: sandbox.stub() }, changelogUtils: { getChangelog: sandbox.stub(), diff --git a/packages/ckeditor5-dev-env/tests/release-tools/templates/commit.js b/packages/ckeditor5-dev-env/tests/release-tools/templates/commit.js index 11f9d2b72..c473060c6 100644 --- a/packages/ckeditor5-dev-env/tests/release-tools/templates/commit.js +++ b/packages/ckeditor5-dev-env/tests/release-tools/templates/commit.js @@ -31,7 +31,7 @@ describe( 'dev-env/release-tools/changelog/templates', () => { }; templateOptions = { data: { - root: rootOptions, + root: rootOptions } }; } ); diff --git a/packages/ckeditor5-dev-env/tests/release-tools/utils/executeonpackages.js b/packages/ckeditor5-dev-env/tests/release-tools/utils/executeonpackages.js index 2b7269140..9e6c9aa9e 100644 --- a/packages/ckeditor5-dev-env/tests/release-tools/utils/executeonpackages.js +++ b/packages/ckeditor5-dev-env/tests/release-tools/utils/executeonpackages.js @@ -36,7 +36,7 @@ describe( 'dev-env/release-tools/utils', () => { const packages = new Set( [ '/packages/ckeditor5-core', - '/packages/ckeditor5-engine', + '/packages/ckeditor5-engine' ] ); return executeOnPackages( packages, functionToExecute ) @@ -63,7 +63,7 @@ describe( 'dev-env/release-tools/utils', () => { const packages = new Set( [ '/packages/ckeditor5-core', - '/packages/ckeditor5-engine', + '/packages/ckeditor5-engine' ] ); return executeOnPackages( packages, functionToExecute ) diff --git a/packages/ckeditor5-dev-env/tests/release-tools/utils/generatechangelogfromcommits-integration.js b/packages/ckeditor5-dev-env/tests/release-tools/utils/generatechangelogfromcommits-integration.js index c042d04c5..9569fe607 100644 --- a/packages/ckeditor5-dev-env/tests/release-tools/utils/generatechangelogfromcommits-integration.js +++ b/packages/ckeditor5-dev-env/tests/release-tools/utils/generatechangelogfromcommits-integration.js @@ -57,7 +57,7 @@ describe( 'dev-env/release-tools/utils', () => { info: sandbox.stub(), warning: sandbox.stub(), error: sandbox.stub() - }, + } }; generateChangelogFromCommits = proxyquire( '../../../lib/release-tools/utils/generatechangelogfromcommits', { diff --git a/packages/ckeditor5-dev-env/tests/release-tools/utils/getpackagestorelease.js b/packages/ckeditor5-dev-env/tests/release-tools/utils/getpackagestorelease.js index 5d5654a1b..f9c5f90d7 100644 --- a/packages/ckeditor5-dev-env/tests/release-tools/utils/getpackagestorelease.js +++ b/packages/ckeditor5-dev-env/tests/release-tools/utils/getpackagestorelease.js @@ -28,7 +28,7 @@ describe( 'dev-env/release-tools/utils', () => { info: sandbox.stub(), warning: sandbox.stub(), error: sandbox.stub() - }, + } }; getPackagesToRelease = proxyquire( '../../../lib/release-tools/utils/getpackagestorelease', { diff --git a/packages/ckeditor5-dev-env/tests/release-tools/utils/getsubpackagespaths.js b/packages/ckeditor5-dev-env/tests/release-tools/utils/getsubpackagespaths.js index 76818615b..d50ce2020 100644 --- a/packages/ckeditor5-dev-env/tests/release-tools/utils/getsubpackagespaths.js +++ b/packages/ckeditor5-dev-env/tests/release-tools/utils/getsubpackagespaths.js @@ -67,7 +67,7 @@ describe( 'dev-env/release-tools/utils', () => { getDirectoriesStub.returns( [ 'ckeditor5-core', 'ckeditor5-engine', - 'ckeditor5-utils', + 'ckeditor5-utils' ] ); const options = { @@ -125,7 +125,7 @@ describe( 'dev-env/release-tools/utils', () => { 'ckeditor5-engine', 'ckeditor5-utils', 'ckeditor5-build-classic', - 'ckeditor5-build-inline', + 'ckeditor5-build-inline' ] ); const options = { @@ -161,7 +161,7 @@ describe( 'dev-env/release-tools/utils', () => { 'ckeditor5-engine', 'ckeditor5-utils', 'ckeditor5-build-classic', - 'ckeditor5-build-inline', + 'ckeditor5-build-inline' ] ); const options = { diff --git a/packages/ckeditor5-dev-env/tests/release-tools/utils/getsubrepositoriespaths.js b/packages/ckeditor5-dev-env/tests/release-tools/utils/getsubrepositoriespaths.js index 40dbde6e6..d96011b50 100644 --- a/packages/ckeditor5-dev-env/tests/release-tools/utils/getsubrepositoriespaths.js +++ b/packages/ckeditor5-dev-env/tests/release-tools/utils/getsubrepositoriespaths.js @@ -127,7 +127,7 @@ describe( 'dev-env/release-tools/utils', () => { dependencies: { '@ckeditor/ckeditor5-core': 'ckeditor/ckeditor5-core', '@ckeditor/ckeditor5-engine': 'ckeditor/ckeditor5-engine', - '@ckeditor/ckeditor5-utils': 'ckeditor/ckeditor5-utils', + '@ckeditor/ckeditor5-utils': 'ckeditor/ckeditor5-utils' } } ); getPackageJsonStub.onCall( 1 ).returns( { name: '@ckeditor/ckeditor5-core' } ); @@ -162,7 +162,7 @@ describe( 'dev-env/release-tools/utils', () => { dependencies: { '@ckeditor/ckeditor5-core': 'ckeditor/ckeditor5-core', '@ckeditor/ckeditor5-engine': 'ckeditor/ckeditor5-engine', - '@ckeditor/ckeditor5-utils': 'ckeditor/ckeditor5-utils', + '@ckeditor/ckeditor5-utils': 'ckeditor/ckeditor5-utils' } } ); getPackageJsonStub.onCall( 1 ).returns( { name: '@ckeditor/ckeditor5-core' } ); @@ -186,7 +186,7 @@ describe( 'dev-env/release-tools/utils', () => { 'ckeditor5-engine', 'ckeditor5-utils', 'ckeditor5-build-classic', - 'ckeditor5-build-inline', + 'ckeditor5-build-inline' ] ); const options = { @@ -234,7 +234,7 @@ describe( 'dev-env/release-tools/utils', () => { 'ckeditor5-engine', 'ckeditor5-utils', 'ckeditor5-build-classic', - 'ckeditor5-build-inline', + 'ckeditor5-build-inline' ] ); const options = { @@ -284,7 +284,7 @@ describe( 'dev-env/release-tools/utils', () => { 'ckeditor5-engine', 'ckeditor5-utils', 'ckeditor5-build-classic', - 'ckeditor5-build-inline', + 'ckeditor5-build-inline' ] ); const options = { @@ -330,7 +330,7 @@ describe( 'dev-env/release-tools/utils', () => { it( 'allows returning the main repository only (skipMainRepository=false)', () => { const options = { cwd: '/tmp', - packages: null, + packages: null }; const pathsCollection = getSubRepositoriesPaths( options ); diff --git a/packages/ckeditor5-dev-env/tests/release-tools/utils/transform-commit/getchangedfilesforcommit.js b/packages/ckeditor5-dev-env/tests/release-tools/utils/transform-commit/getchangedfilesforcommit.js index ec7f7b342..5de0a4b38 100644 --- a/packages/ckeditor5-dev-env/tests/release-tools/utils/transform-commit/getchangedfilesforcommit.js +++ b/packages/ckeditor5-dev-env/tests/release-tools/utils/transform-commit/getchangedfilesforcommit.js @@ -34,6 +34,8 @@ describe( 'dev-env/release-tools/utils/transform-commit', () => { exec( 'git config user.email "ckeditor5@ckeditor.com"' ); exec( 'git config user.name "CKEditor5 CI"' ); } + + getChangedFilesForCommit = require( '../../../../lib/release-tools/utils/transform-commit/getchangedfilesforcommit' ); } ); afterEach( () => { @@ -41,10 +43,6 @@ describe( 'dev-env/release-tools/utils/transform-commit', () => { exec( `rm -rf ${ path.join( tmpCwd, '*' ) }` ); } ); - beforeEach( () => { - getChangedFilesForCommit = require( '../../../../lib/release-tools/utils/transform-commit/getchangedfilesforcommit' ); - } ); - it( 'returns files for initial commit', () => { exec( 'touch 1.txt' ); exec( 'touch 2.txt' ); @@ -61,7 +59,7 @@ describe( 'dev-env/release-tools/utils/transform-commit', () => { '2.txt', '3.txt', '4.txt', - '5.txt', + '5.txt' ] ); } ); @@ -85,7 +83,7 @@ describe( 'dev-env/release-tools/utils/transform-commit', () => { expect( files ).to.deep.equal( [ '2.js', '3.js', - '4.js', + '4.js' ] ); } ); @@ -114,7 +112,7 @@ describe( 'dev-env/release-tools/utils/transform-commit', () => { expect( files ).to.deep.equal( [ '5.json', - '6.json', + '6.json' ] ); } ); @@ -153,7 +151,7 @@ describe( 'dev-env/release-tools/utils/transform-commit', () => { expect( files ).to.deep.equal( [ '5.json', - '6.json', + '6.json' ] ); } ); } ); diff --git a/packages/ckeditor5-dev-env/tests/release-tools/utils/transform-commit/transformcommitforsubpackagefactory.js b/packages/ckeditor5-dev-env/tests/release-tools/utils/transform-commit/transformcommitforsubpackagefactory.js index 6f378ac0a..6aeb3fbf6 100644 --- a/packages/ckeditor5-dev-env/tests/release-tools/utils/transform-commit/transformcommitforsubpackagefactory.js +++ b/packages/ckeditor5-dev-env/tests/release-tools/utils/transform-commit/transformcommitforsubpackagefactory.js @@ -143,7 +143,7 @@ describe( 'dev-env/release-tools/utils/transform-commit', () => { stubs.getChangedFilesForCommit.returns( [ 'packages/ckeditor5-dev-env/README.md', - 'packages/ckeditor5-dev-env/package.json', + 'packages/ckeditor5-dev-env/package.json' ] ); stubs.transformCommitForSubRepositoryFactory.reset(); @@ -210,7 +210,7 @@ describe( 'dev-env/release-tools/utils/transform-commit', () => { stubs.getChangedFilesForCommit.returns( [ 'packages/ckeditor5-dev-env/README.md', - 'packages/ckeditor5-dev-env/package.json', + 'packages/ckeditor5-dev-env/package.json' ] ); const commit = transformCommitForSubPackage( rawCommit, context ); diff --git a/packages/ckeditor5-dev-env/tests/release-tools/utils/transform-commit/transformcommitforsubrepositoryfactory.js b/packages/ckeditor5-dev-env/tests/release-tools/utils/transform-commit/transformcommitforsubrepositoryfactory.js index 57ef3442c..9d8f0f6ab 100644 --- a/packages/ckeditor5-dev-env/tests/release-tools/utils/transform-commit/transformcommitforsubrepositoryfactory.js +++ b/packages/ckeditor5-dev-env/tests/release-tools/utils/transform-commit/transformcommitforsubrepositoryfactory.js @@ -244,12 +244,12 @@ describe( 'dev-env/release-tools/utils/transform-commit', () => { it( 'attaches additional commit description with correct indent', () => { const commitDescription = [ '* Release task - rebuilt module for collecting dependencies to release.', - '* Used `semver` package for bumping the version (instead of a custom module).', + '* Used `semver` package for bumping the version (instead of a custom module).' ]; const commitDescriptionWithIndents = [ ' * Release task - rebuilt module for collecting dependencies to release.', - ' * Used `semver` package for bumping the version (instead of a custom module).', + ' * Used `semver` package for bumping the version (instead of a custom module).' ].join( '\n' ); const rawCommit = { diff --git a/packages/ckeditor5-dev-env/tests/release-tools/utils/updatedependenciesversions.js b/packages/ckeditor5-dev-env/tests/release-tools/utils/updatedependenciesversions.js index 9195a0057..eb48139bc 100644 --- a/packages/ckeditor5-dev-env/tests/release-tools/utils/updatedependenciesversions.js +++ b/packages/ckeditor5-dev-env/tests/release-tools/utils/updatedependenciesversions.js @@ -144,7 +144,7 @@ describe( 'dev-env/release-tools/utils', () => { let json = { dependencies: { 'package-deps-a': '^1.0.0', - 'package-deps-b': '^1.0.0', + 'package-deps-b': '^1.0.0' }, devDependencies: { 'package-dev-a': '^2.0.0' diff --git a/packages/ckeditor5-dev-env/tests/translations/collect-utils.js b/packages/ckeditor5-dev-env/tests/translations/collect-utils.js index b9878feea..4008358cd 100644 --- a/packages/ckeditor5-dev-env/tests/translations/collect-utils.js +++ b/packages/ckeditor5-dev-env/tests/translations/collect-utils.js @@ -51,7 +51,7 @@ describe( 'collect-utils', () => { it( 'should collect info about t() calls', () => { const fileContents = { '/ckeditor5-core/file1.js': 't( \'Bold\' );', - '/ckeditor5-utils/file2.js': 't( \'Italic [context: italic style]\' );', + '/ckeditor5-utils/file2.js': 't( \'Italic [context: italic style]\' );' }; originalStringMap = { @@ -84,13 +84,13 @@ describe( 'collect-utils', () => { key: 'Bold', package: 'ckeditor5-core', context: null, - sentence: 'Bold', + sentence: 'Bold' }, { filePath: '/ckeditor5-utils/file2.js', key: 'Italic [context: italic style]', package: 'ckeditor5-utils', context: 'italic style', - sentence: 'Italic', + sentence: 'Italic' } ] ); } ); } ); @@ -125,7 +125,7 @@ describe( 'collect-utils', () => { it( 'should return an error when ckeditor5-core is missing', () => { const contexts = new Map(); const translations = [ { - package: 'ckeditor5-utils', + package: 'ckeditor5-utils' } ]; const errors = utils.getMissingContextErrorMessages( contexts, translations ); diff --git a/packages/ckeditor5-dev-env/tests/translations/collect.js b/packages/ckeditor5-dev-env/tests/translations/collect.js index 7e10bea59..32b243e3b 100644 --- a/packages/ckeditor5-dev-env/tests/translations/collect.js +++ b/packages/ckeditor5-dev-env/tests/translations/collect.js @@ -29,7 +29,7 @@ describe( 'collect', () => { createPotFileHeader: sandbox.stub(), createPotFileContent: sandbox.stub(), savePotFile: sandbox.spy(), - removeExistingPotFiles: sandbox.spy(), + removeExistingPotFiles: sandbox.spy() } }; diff --git a/packages/ckeditor5-dev-env/tests/translations/download.js b/packages/ckeditor5-dev-env/tests/translations/download.js index ef39b8c67..45277fd0f 100644 --- a/packages/ckeditor5-dev-env/tests/translations/download.js +++ b/packages/ckeditor5-dev-env/tests/translations/download.js @@ -71,7 +71,7 @@ describe( 'download', () => { resources = [ { slug: 'ckeditor5-core' }, - { slug: 'ckeditor5-ui' }, + { slug: 'ckeditor5-ui' } ]; resourcesDetails = { @@ -127,7 +127,7 @@ describe( 'download', () => { resources = [ { slug: 'ckeditor5-core' }, - { slug: 'ckeditor5-ui' }, + { slug: 'ckeditor5-ui' } ]; // jscs:disable requireCamelCaseOrUpperCaseIdentifiers diff --git a/packages/ckeditor5-dev-env/tests/translations/transifex-service.js b/packages/ckeditor5-dev-env/tests/translations/transifex-service.js index e3b12880c..d9285bab1 100644 --- a/packages/ckeditor5-dev-env/tests/translations/transifex-service.js +++ b/packages/ckeditor5-dev-env/tests/translations/transifex-service.js @@ -131,7 +131,7 @@ describe( 'transifex-service', () => { token: 'token', name: 'name', slug: 'slug', - content: 'content', + content: 'content' } ).then( () => { sinon.assert.calledWith( spy, @@ -161,7 +161,7 @@ describe( 'transifex-service', () => { return transifexService.putResourceContent( { token: 'token', slug: 'slug', - content: 'content', + content: 'content' } ).then( () => { sinon.assert.calledWith( spy, @@ -188,7 +188,7 @@ describe( 'transifex-service', () => { return transifexService.getResourceDetails( { token: 'token', - slug: 'slug', + slug: 'slug' } ).then( () => { sinon.assert.calledWith( spy, diff --git a/packages/ckeditor5-dev-env/tests/translations/upload.js b/packages/ckeditor5-dev-env/tests/translations/upload.js index 05eaf63e4..eed7e77cf 100644 --- a/packages/ckeditor5-dev-env/tests/translations/upload.js +++ b/packages/ckeditor5-dev-env/tests/translations/upload.js @@ -62,7 +62,7 @@ describe( 'upload', () => { it( 'should create and update resources on the Transifex', () => { packageNames = [ 'ckeditor5-core', - 'ckeditor5-ui', + 'ckeditor5-ui' ]; serverResources = [ { @@ -71,7 +71,7 @@ describe( 'upload', () => { fileContents = { 'workspace/ckeditor5/build/.transifex/ckeditor5-ui/en.pot': '# ckeditor-ui en.pot content', - 'workspace/ckeditor5/build/.transifex/ckeditor5-core/en.pot': '# ckeditor-core en.pot content', + 'workspace/ckeditor5/build/.transifex/ckeditor5-core/en.pot': '# ckeditor-core en.pot content' }; return upload( { token: 'secretToken' } ) diff --git a/packages/ckeditor5-dev-tests/bin/notify-travis-status.js b/packages/ckeditor5-dev-tests/bin/notify-travis-status.js index c89600ed0..da8e47183 100755 --- a/packages/ckeditor5-dev-tests/bin/notify-travis-status.js +++ b/packages/ckeditor5-dev-tests/bin/notify-travis-status.js @@ -81,7 +81,7 @@ const data = { title: 'Repository (branch)', value: [ ``, - `()`, + `()` ].join( ' ' ), short: true }, @@ -104,9 +104,9 @@ const data = { title: 'Commit message', value: getFormattedMessage( process.env.TRAVIS_COMMIT_MESSAGE, owner, repo ), short: false - }, + } ] - }, + } ] }; diff --git a/packages/ckeditor5-dev-tests/lib/index.js b/packages/ckeditor5-dev-tests/lib/index.js index e11ac639b..d3344ab48 100644 --- a/packages/ckeditor5-dev-tests/lib/index.js +++ b/packages/ckeditor5-dev-tests/lib/index.js @@ -8,5 +8,5 @@ module.exports = { runAutomatedTests: require( './tasks/runautomatedtests' ), runManualTests: require( './tasks/runmanualtests' ), - parseArguments: require( './utils/automated-tests/parsearguments' ), + parseArguments: require( './utils/automated-tests/parsearguments' ) }; diff --git a/packages/ckeditor5-dev-tests/lib/utils/automated-tests/getwebpackconfig.js b/packages/ckeditor5-dev-tests/lib/utils/automated-tests/getwebpackconfig.js index 4727975a0..7fa8014a1 100644 --- a/packages/ckeditor5-dev-tests/lib/utils/automated-tests/getwebpackconfig.js +++ b/packages/ckeditor5-dev-tests/lib/utils/automated-tests/getwebpackconfig.js @@ -37,7 +37,7 @@ module.exports = function getWebpackConfigForAutomatedTests( options ) { }, minify: true } ) - }, + } ] }, { diff --git a/packages/ckeditor5-dev-tests/lib/utils/automated-tests/leaksdetector.js b/packages/ckeditor5-dev-tests/lib/utils/automated-tests/leaksdetector.js index f612342fb..e41017b9d 100644 --- a/packages/ckeditor5-dev-tests/lib/utils/automated-tests/leaksdetector.js +++ b/packages/ckeditor5-dev-tests/lib/utils/automated-tests/leaksdetector.js @@ -8,10 +8,12 @@ ( function() { let lastDomElementsCount; + // eslint-disable-next-line mocha/no-top-level-hooks beforeEach( () => { lastDomElementsCount = document.body.childElementCount; } ); + // eslint-disable-next-line mocha/no-top-level-hooks afterEach( () => { if ( document.body.childElementCount !== lastDomElementsCount ) { const leaksCount = document.body.childElementCount - lastDomElementsCount; diff --git a/packages/ckeditor5-dev-tests/lib/utils/manual-tests/getwebpackconfig.js b/packages/ckeditor5-dev-tests/lib/utils/manual-tests/getwebpackconfig.js index 29784f6cd..edad91b62 100644 --- a/packages/ckeditor5-dev-tests/lib/utils/manual-tests/getwebpackconfig.js +++ b/packages/ckeditor5-dev-tests/lib/utils/manual-tests/getwebpackconfig.js @@ -65,7 +65,7 @@ module.exports = function getWebpackConfigForManualTests( options ) { }, sourceMap: true } ) - }, + } ] }, { diff --git a/packages/ckeditor5-dev-tests/tests/tasks/runautomatedtests.js b/packages/ckeditor5-dev-tests/tests/tasks/runautomatedtests.js index 9ec717e9c..f5a4dde3d 100644 --- a/packages/ckeditor5-dev-tests/tests/tasks/runautomatedtests.js +++ b/packages/ckeditor5-dev-tests/tests/tasks/runautomatedtests.js @@ -44,7 +44,7 @@ beforeEach( () => { stubs = { fs: { writeFileSync: sandbox.stub(), - utimesSync: sandbox.stub(), + utimesSync: sandbox.stub() }, log: { info: sandbox.stub(), @@ -75,7 +75,7 @@ beforeEach( () => { karmaServerStart: sandbox.stub() }, getKarmaConfig: sandbox.stub(), - transformFileOptionToTestGlob: sandbox.stub(), + transformFileOptionToTestGlob: sandbox.stub() }; sandbox.stub( process, 'cwd' ).returns( '/workspace' ); @@ -94,7 +94,7 @@ beforeEach( () => { runAutomatedTests = proxyquire( '../../lib/tasks/runautomatedtests', { fs: stubs.fs, - glob: stubs.glob, + glob: stubs.glob } ); } ); @@ -162,14 +162,14 @@ beforeEach( () => { const options = { files: [ 'basic-foo', - 'bar-core', + 'bar-core' ], production: true }; stubs.transformFileOptionToTestGlob.onFirstCall().returns( [ '/workspace/packages/ckeditor5-basic-foo/tests/**/*.js', - '/workspace/packages/ckeditor-basic-foo/tests/**/*.js', + '/workspace/packages/ckeditor-basic-foo/tests/**/*.js' ] ); stubs.transformFileOptionToTestGlob.onSecondCall().returns( [ diff --git a/packages/ckeditor5-dev-tests/tests/tasks/runmanualtests.js b/packages/ckeditor5-dev-tests/tests/tasks/runmanualtests.js index 11fb07cd7..f5d637294 100644 --- a/packages/ckeditor5-dev-tests/tests/tasks/runmanualtests.js +++ b/packages/ckeditor5-dev-tests/tests/tasks/runmanualtests.js @@ -204,7 +204,7 @@ describe( 'runManualTests', () => { 'workspace/packages/ckeditor-editor-classic/tests/manual/**/*.js' ], language: 'pl', - additionalLanguages: [ 'ar', 'en' ], + additionalLanguages: [ 'ar', 'en' ] } ); expect( spies.scriptCompiler.calledOnce ).to.equal( true ); diff --git a/packages/ckeditor5-dev-tests/tests/utils/automated-tests/getwebpackconfig.js b/packages/ckeditor5-dev-tests/tests/utils/automated-tests/getwebpackconfig.js index 253d5b4cf..887d3068e 100644 --- a/packages/ckeditor5-dev-tests/tests/utils/automated-tests/getwebpackconfig.js +++ b/packages/ckeditor5-dev-tests/tests/utils/automated-tests/getwebpackconfig.js @@ -46,7 +46,7 @@ describe( 'getWebpackConfigForAutomatedTests()', () => { it( 'should return webpack configutation with istanbul loader', () => { const webpackConfig = getWebpackConfigForAutomatedTests( { coverage: true, - files: [ '**/*.js' ], + files: [ '**/*.js' ] } ); const istanbulLoader = webpackConfig.module.rules @@ -71,9 +71,9 @@ describe( 'getWebpackConfigForAutomatedTests()', () => { files: [ [ 'node_modules/ckeditor5-utils/tests/**/*.js', - 'node_modules/ckeditor-utils/tests/**/*.js', + 'node_modules/ckeditor-utils/tests/**/*.js' ] - ], + ] } ); const istanbulLoader = webpackConfig.module.rules @@ -85,7 +85,7 @@ describe( 'getWebpackConfigForAutomatedTests()', () => { ] ); } ); - it( 'should return webpack configutation with istanbul loader containing include regexp', () => { + it( 'should return webpack configutation with istanbul loader containing include regexp (exclude pattern)', () => { const webpackConfig = getWebpackConfigForAutomatedTests( { coverage: true, files: [ @@ -93,7 +93,7 @@ describe( 'getWebpackConfigForAutomatedTests()', () => { 'node_modules/ckeditor5-!(utils)/tests/**/*.js', 'node_modules/ckeditor-!(utils)/tests/**/*.js' ] - ], + ] } ); const istanbulLoader = webpackConfig.module.rules diff --git a/packages/ckeditor5-dev-tests/tests/utils/manual-tests/compilescripts.js b/packages/ckeditor5-dev-tests/tests/utils/manual-tests/compilescripts.js index f953c8ddb..0d9bf0556 100644 --- a/packages/ckeditor5-dev-tests/tests/utils/manual-tests/compilescripts.js +++ b/packages/ckeditor5-dev-tests/tests/utils/manual-tests/compilescripts.js @@ -151,7 +151,7 @@ describe( 'compileManualTestScripts', () => { it( 'compiles only manual test files', () => { const manualTestScriptsPatterns = [ - 'ckeditor5-build-classic/tests/**/*.js', + 'ckeditor5-build-classic/tests/**/*.js' ]; stubs.glob.onFirstCall().returns( [ @@ -181,11 +181,11 @@ describe( 'compileManualTestScripts', () => { stubs.pathSep.value( '\\' ); const manualTestScriptsPatterns = [ - 'ckeditor5-build-classic/tests/**/*.js', + 'ckeditor5-build-classic/tests/**/*.js' ]; stubs.glob.onFirstCall().returns( [ - 'ckeditor5-build-classic\\tests\\manual\\ckeditor.js', + 'ckeditor5-build-classic\\tests\\manual\\ckeditor.js' ] ); return compileManualTestScripts( { diff --git a/packages/ckeditor5-dev-utils/lib/styles/getpostcssconfig.js b/packages/ckeditor5-dev-utils/lib/styles/getpostcssconfig.js index 99d6faf5e..4423846ee 100644 --- a/packages/ckeditor5-dev-utils/lib/styles/getpostcssconfig.js +++ b/packages/ckeditor5-dev-utils/lib/styles/getpostcssconfig.js @@ -24,7 +24,7 @@ module.exports = function getPostCssConfig( options = {} ) { require( './themeimporter' )( options.themeImporter ), require( 'postcss-mixins' )(), require( 'postcss-nesting' )(), - require( './themelogger' )(), + require( './themelogger' )() ] }; diff --git a/packages/ckeditor5-dev-utils/lib/styles/themeimporter.js b/packages/ckeditor5-dev-utils/lib/styles/themeimporter.js index 44ebdf394..5e351c0bd 100644 --- a/packages/ckeditor5-dev-utils/lib/styles/themeimporter.js +++ b/packages/ckeditor5-dev-utils/lib/styles/themeimporter.js @@ -52,7 +52,7 @@ module.exports = postcss.plugin( 'postcss-ckeditor5-theme-importer', ( pluginOpt require( './themelogger' )() ] }, - root, result, + root, result } ); return importThemeFile( options ); diff --git a/packages/ckeditor5-dev-utils/lib/translations/cleanpofilecontent.js b/packages/ckeditor5-dev-utils/lib/translations/cleanpofilecontent.js index 12eca2096..0feda45f6 100644 --- a/packages/ckeditor5-dev-utils/lib/translations/cleanpofilecontent.js +++ b/packages/ckeditor5-dev-utils/lib/translations/cleanpofilecontent.js @@ -21,7 +21,7 @@ module.exports = function cleanPoFileContent( poFileContent ) { po.headers = { Language: po.headers.Language, 'Language-Team': po.headers[ 'Language-Team' ], - 'Plural-Forms': po.headers[ 'Plural-Forms' ], + 'Plural-Forms': po.headers[ 'Plural-Forms' ] }; // Clean comments. @@ -37,7 +37,7 @@ module.exports = function cleanPoFileContent( poFileContent ) { '', ' To learn more, check out the official contributor\'s guide:', ' https://ckeditor.com/docs/ckeditor5/latest/framework/guides/contributing/contributing.html', - '', + '' ]; return po.toString(); diff --git a/packages/ckeditor5-dev-utils/tests/bundler/createentryfile.js b/packages/ckeditor5-dev-utils/tests/bundler/createentryfile.js index d65939796..dce5914d3 100644 --- a/packages/ckeditor5-dev-utils/tests/bundler/createentryfile.js +++ b/packages/ckeditor5-dev-utils/tests/bundler/createentryfile.js @@ -36,7 +36,7 @@ describe( 'bundler', () => { editor: '@ckeditor/ckeditor5-editor-classic/src/editor', config: { undo: { - step: 3, + step: 3 }, toolbar: [ 'image' diff --git a/packages/ckeditor5-dev-utils/tests/bundler/getplugins.js b/packages/ckeditor5-dev-utils/tests/bundler/getplugins.js index f3015b7b9..64624ccc0 100644 --- a/packages/ckeditor5-dev-utils/tests/bundler/getplugins.js +++ b/packages/ckeditor5-dev-utils/tests/bundler/getplugins.js @@ -31,7 +31,7 @@ describe( 'bundler', () => { it( 'does not duplicate plugins with the same name', () => { const plugins = getPlugins( [ '@ckeditor/ckeditor5-essentials/src/essentials', - 'ckeditor5-foo/src/essentials', + 'ckeditor5-foo/src/essentials' ] ); expect( plugins ).to.have.property( 'EssentialsPlugin', '@ckeditor/ckeditor5-essentials/src/essentials' ); diff --git a/packages/ckeditor5-dev-utils/tests/git.js b/packages/ckeditor5-dev-utils/tests/git.js index a3fe47862..b30e61a40 100644 --- a/packages/ckeditor5-dev-utils/tests/git.js +++ b/packages/ckeditor5-dev-utils/tests/git.js @@ -85,7 +85,7 @@ describe( 'utils', () => { expect( urlInfo.branch ).to.equal( 't/122' ); } ); - it( 'should parse full GitHub URL (git)', () => { + it( 'should parse full GitHub URL (git@)', () => { const urlInfo = git.parseRepositoryUrl( 'git@github.com:ckeditor/ckeditor5-core.git' ); expect( urlInfo.server ).to.equal( 'git@github.com:' ); @@ -95,7 +95,7 @@ describe( 'utils', () => { expect( urlInfo.branch ).to.equal( 'master' ); } ); - it( 'should parse full GitHub URL (git)', () => { + it( 'should parse full GitHub URL (git://)', () => { const urlInfo = git.parseRepositoryUrl( 'git://github.com/ckeditor/ckeditor5-core.git' ); expect( urlInfo.server ).to.equal( 'git://github.com/' ); diff --git a/packages/ckeditor5-dev-utils/tests/translations/createdictionaryfrompofilecontent.js b/packages/ckeditor5-dev-utils/tests/translations/createdictionaryfrompofilecontent.js index b48f589d6..4343d6c23 100644 --- a/packages/ckeditor5-dev-utils/tests/translations/createdictionaryfrompofilecontent.js +++ b/packages/ckeditor5-dev-utils/tests/translations/createdictionaryfrompofilecontent.js @@ -35,7 +35,7 @@ describe( 'translations', () => { 'msgctxt "Label for the Save button."', 'msgid "Save"', 'msgstr ""', - '', + '' ].join( '\n' ) ); expect( result ).to.deep.equal( {} ); diff --git a/packages/ckeditor5-dev-utils/tests/translations/findoriginalstrings.js b/packages/ckeditor5-dev-utils/tests/translations/findoriginalstrings.js index 8841555c8..8f79d45f7 100644 --- a/packages/ckeditor5-dev-utils/tests/translations/findoriginalstrings.js +++ b/packages/ckeditor5-dev-utils/tests/translations/findoriginalstrings.js @@ -19,7 +19,7 @@ describe( 'findOriginalStrings', () => { info: sandbox.stub(), warning: sandbox.stub(), error: sandbox.stub() - }, + } }; findOriginalStrings = proxyquire( '../../lib/translations/findoriginalstrings', { diff --git a/packages/ckeditor5-dev-utils/tests/translations/multiplelanguagetranslationservice.js b/packages/ckeditor5-dev-utils/tests/translations/multiplelanguagetranslationservice.js index 9557f3aa7..a1a9fbdb5 100644 --- a/packages/ckeditor5-dev-utils/tests/translations/multiplelanguagetranslationservice.js +++ b/packages/ckeditor5-dev-utils/tests/translations/multiplelanguagetranslationservice.js @@ -199,7 +199,7 @@ describe( 'translations', () => { translationService._dictionary = { pl: { Cancel: 'Anuluj', - Save: 'Zapisz', + Save: 'Zapisz' }, en: { Cancel: 'Cancel', @@ -256,7 +256,7 @@ describe( 'translations', () => { translationService._dictionary = { pl: { Cancel: 'Anuluj', - Save: 'Zapisz', + Save: 'Zapisz' } }; @@ -285,7 +285,7 @@ describe( 'translations', () => { translationService._dictionary = { pl: { Cancel: 'Anuluj', - Save: 'Zapisz', + Save: 'Zapisz' } }; @@ -328,7 +328,7 @@ describe( 'translations', () => { translationService._dictionary = { pl: { Cancel: 'Anuluj', - Save: 'Zapisz', + Save: 'Zapisz' } }; @@ -385,7 +385,7 @@ describe( 'translations', () => { pl: { Cancel: 'Anuluj', Save: 'Zapisz', - Close: 'Zamknij', + Close: 'Zamknij' } }; @@ -421,7 +421,7 @@ describe( 'translations', () => { translationService._dictionary = { pl: { Cancel: 'Anuluj', - Save: 'Zapisz', + Save: 'Zapisz' } }; @@ -450,7 +450,7 @@ describe( 'translations', () => { it( 'should use output directory', () => { const translationService = new MultipleLanguageTranslationService( 'pl', { - additionalLanguages: [ 'en' ], + additionalLanguages: [ 'en' ] } ); const spy = sandbox.spy(); diff --git a/packages/ckeditor5-dev-webpack-plugin/tests/ckeditor5-env-utils.js b/packages/ckeditor5-dev-webpack-plugin/tests/ckeditor5-env-utils.js index 822ae4e6e..892575c6f 100644 --- a/packages/ckeditor5-dev-webpack-plugin/tests/ckeditor5-env-utils.js +++ b/packages/ckeditor5-dev-webpack-plugin/tests/ckeditor5-env-utils.js @@ -103,7 +103,7 @@ describe( 'webpack-plugin/ckeditor5-env-utils', () => { expect( newLoaders ).to.deep.equal( [ { loader: originalPath.normalize( originalPath.join( __dirname, '../lib/translatesourceloader.js' ) ), - options, + options } ] ); } ); @@ -131,7 +131,7 @@ describe( 'webpack-plugin/ckeditor5-env-utils', () => { expect( newLoaders ).to.deep.equal( [ { loader: path.normalize( path.join( __dirname, '..\\lib\\translatesourceloader.js' ) ), - options, + options } ] ); } ); @@ -167,7 +167,7 @@ describe( 'webpack-plugin/ckeditor5-env-utils', () => { expect( newLoaders ).does.deep.equal( [ { loader: path.normalize( path.join( __dirname, '../lib/translatesourceloader.js' ) ), - options, + options } ] ); } ); } ); diff --git a/packages/jsdoc-plugins/lib/custom-tags/error.js b/packages/jsdoc-plugins/lib/custom-tags/error.js index a4120f2a9..fa4c5b2d9 100644 --- a/packages/jsdoc-plugins/lib/custom-tags/error.js +++ b/packages/jsdoc-plugins/lib/custom-tags/error.js @@ -23,5 +23,5 @@ module.exports = { } ); } } ); - }, + } }; diff --git a/packages/jsdoc-plugins/lib/longname-fixer/fixers/fix-incorrect-class-longname.js b/packages/jsdoc-plugins/lib/longname-fixer/fixers/fix-incorrect-class-longname.js index 2b8823fe2..09918e68c 100644 --- a/packages/jsdoc-plugins/lib/longname-fixer/fixers/fix-incorrect-class-longname.js +++ b/packages/jsdoc-plugins/lib/longname-fixer/fixers/fix-incorrect-class-longname.js @@ -28,12 +28,12 @@ function fixIncorrectClassConstructor( object ) { memberof: doclet.memberof.replace( '.' + match[ 1 ], '' ), kind: 'function', scope: 'instance', - name: 'constructor', + name: 'constructor' } ); } else { doclet = Object.assign( {}, doclet, { longname: doclet.longname.replace( '.' + match[ 1 ], '' ), - memberof: doclet.memberof.replace( '.' + match[ 1 ], '' ), + memberof: doclet.memberof.replace( '.' + match[ 1 ], '' ) } ); } diff --git a/packages/jsdoc-plugins/lib/longname-fixer/fixers/fix-short-refs.js b/packages/jsdoc-plugins/lib/longname-fixer/fixers/fix-short-refs.js index 9cb2bae48..0367669db 100644 --- a/packages/jsdoc-plugins/lib/longname-fixer/fixers/fix-short-refs.js +++ b/packages/jsdoc-plugins/lib/longname-fixer/fixers/fix-short-refs.js @@ -50,12 +50,12 @@ function fixShortRefsInLongnameAndMemeberof( options ) { if ( firstNameChar === '~' ) { doclet = assign( {}, doclet, { memberof: lastInterfaceOrClass.memberof + '~' + lastInterfaceOrClass.name, - longname: lastInterfaceOrClass.memberof + doclet.longname, + longname: lastInterfaceOrClass.memberof + doclet.longname } ); } else if ( firstNameChar === '#' ) { doclet = assign( {}, doclet, { memberof: lastInterfaceOrClass.longname, - longname: lastInterfaceOrClass.longname + doclet.longname, + longname: lastInterfaceOrClass.longname + doclet.longname } ); } @@ -63,12 +63,12 @@ function fixShortRefsInLongnameAndMemeberof( options ) { if ( doclet.kind === 'event' && !doclet.name.includes( 'event' ) && doclet.longname.includes( 'module:' ) ) { doclet = assign( {}, doclet, { memberof: lastInterfaceOrClass.longname, - longname: lastInterfaceOrClass.longname + '#event:' + doclet.name, + longname: lastInterfaceOrClass.longname + '#event:' + doclet.name } ); } else if ( doclet.kind === 'event' && !doclet.longname.includes( 'module:' ) ) { doclet = assign( {}, doclet, { memberof: lastInterfaceOrClass.longname, - longname: lastInterfaceOrClass.longname + '#' + doclet.longname, + longname: lastInterfaceOrClass.longname + '#' + doclet.longname } ); } diff --git a/packages/jsdoc-plugins/lib/longname-fixer/longname-fixer.js b/packages/jsdoc-plugins/lib/longname-fixer/longname-fixer.js index 23eecf6c7..b954e301f 100644 --- a/packages/jsdoc-plugins/lib/longname-fixer/longname-fixer.js +++ b/packages/jsdoc-plugins/lib/longname-fixer/longname-fixer.js @@ -36,5 +36,5 @@ const docletHandler = ( () => { } )(); exports.handlers = { - newDoclet: docletHandler, + newDoclet: docletHandler }; diff --git a/packages/jsdoc-plugins/lib/validator/doclet-validator.js b/packages/jsdoc-plugins/lib/validator/doclet-validator.js index 4d406c43a..4e830475f 100644 --- a/packages/jsdoc-plugins/lib/validator/doclet-validator.js +++ b/packages/jsdoc-plugins/lib/validator/doclet-validator.js @@ -119,7 +119,7 @@ class DocletValidator { _lintParams() { const collections = [ ...this._collection.get( 'function' ), - ...this._collection.get( 'class' ), + ...this._collection.get( 'class' ) ] .filter( el => !!el.params ); @@ -315,7 +315,7 @@ class DocletValidator { */ _addError( doclet, errorMessage ) { this._errors.push( Object.assign( { - message: errorMessage, + message: errorMessage }, this._getErrorData( doclet ) ) ); } @@ -327,7 +327,7 @@ class DocletValidator { return { parent: doclet.memberof, line: doclet.meta.lineno, - file: doclet.meta.path + '/' + doclet.meta.filename, + file: doclet.meta.path + '/' + doclet.meta.filename }; } diff --git a/packages/jsdoc-plugins/lib/validator/types.js b/packages/jsdoc-plugins/lib/validator/types.js index 6f24aa654..ce5ccfba1 100644 --- a/packages/jsdoc-plugins/lib/validator/types.js +++ b/packages/jsdoc-plugins/lib/validator/types.js @@ -61,7 +61,7 @@ const GENERIC_TYPES = [ // Object that contains next() method and satisfies the Iterator protocol. // https://developer.mozilla.org/pl/docs/Web/JavaScript/Reference/Iteration_protocols - 'Iterator', + 'Iterator' ]; module.exports = { diff --git a/packages/jsdoc-plugins/tests/doclet-utils.js b/packages/jsdoc-plugins/tests/doclet-utils.js index 1ba04b2e1..e409b9e94 100644 --- a/packages/jsdoc-plugins/tests/doclet-utils.js +++ b/packages/jsdoc-plugins/tests/doclet-utils.js @@ -13,7 +13,7 @@ describe( 'doclet-utils', () => { describe( 'doesFieldExistsInClass()', () => { it( 'should find method in the same class', () => { const result = doesFieldExistInClass( [ { - longname: 'module:a~A#method', + longname: 'module:a~A#method' }, { longname: 'module:a~A' } ], 'module:a~A#method' ); @@ -23,12 +23,12 @@ describe( 'doclet-utils', () => { it( 'should find method in the augmented class', () => { const result = doesFieldExistInClass( [ { - longname: 'module:a~B#method', + longname: 'module:a~B#method' }, { longname: 'module:a~A', - augments: [ 'module:a~B' ], + augments: [ 'module:a~B' ] }, { - longname: 'module:a~B', + longname: 'module:a~B' } ], 'module:a~A#method' ); expect( result ).to.be.equal( true ); @@ -36,7 +36,7 @@ describe( 'doclet-utils', () => { it( 'should not find method if not exists', () => { const result = doesFieldExistInClass( [ { - longname: 'module:a~A#methodB', + longname: 'module:a~A#methodB' }, { longname: 'module:a~A' } ], 'module:a~A#methodA' ); diff --git a/packages/jsdoc-plugins/tests/doclet-validator.js b/packages/jsdoc-plugins/tests/doclet-validator.js index ce7062eb6..caa26a2c4 100644 --- a/packages/jsdoc-plugins/tests/doclet-validator.js +++ b/packages/jsdoc-plugins/tests/doclet-validator.js @@ -15,7 +15,7 @@ describe( 'Linter plugin', () => { kind: 'member', name: 'module:ckeditor5/wrong_path', scope: 'inner', - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } } ], getTestedModules() ); linter._lintMembers(); @@ -29,7 +29,7 @@ describe( 'Linter plugin', () => { kind: 'member', name: 'module:ckeditor5/path', memberof: '', - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } } ], getTestedModules() ); linter._lintMemberofProperty(); @@ -42,7 +42,7 @@ describe( 'Linter plugin', () => { kind: 'member', name: 'module:ckeditor5/wrong_path', memberof: 'wrongMemberof', - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } } ], getTestedModules() ); linter._lintMemberofProperty(); @@ -55,7 +55,7 @@ describe( 'Linter plugin', () => { kind: 'member', name: 'module:ckeditor5/editor', memberof: 'module:ckeditor5/editor', - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } } ], getTestedModules() ); linter._lintMemberofProperty(); @@ -69,7 +69,7 @@ describe( 'Linter plugin', () => { undocumented: 'true', name: '⌘', memberof: 'macGlyphsToModifiers', - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } } ], getTestedModules() ); linter._lintMemberofProperty(); @@ -89,7 +89,7 @@ describe( 'Linter plugin', () => { } ], longname: 'abc', scope: 'inner', - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } } ], getTestedModules() ); linter._lintParams(); @@ -105,11 +105,11 @@ describe( 'Linter plugin', () => { names: [ 'module:engine/ckeditor5/editor' ] } } ], - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } }, { kind: 'module', longname: 'module:engine/ckeditor5/editor', - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } } ], getTestedModules() ); linter._lintParams(); @@ -138,23 +138,23 @@ describe( 'Linter plugin', () => { names: [ 'module:engine/foo~FunctionAbc' ] } } ], - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } }, { kind: 'class', longname: 'module:engine/foo~ClassFoo', - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } }, { kind: 'interface', longname: 'module:engine/foo~InterfaceBar', - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } }, { kind: 'typedef', longname: 'module:engine/foo~TypedefBaz', - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } }, { kind: 'function', longname: 'module:engine/foo~FunctionAbc', - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } } ], getTestedModules() ); linter._lintParams(); @@ -174,7 +174,7 @@ describe( 'Linter plugin', () => { ] } } ], - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } } ], getTestedModules() ); linter._lintParams(); @@ -194,7 +194,7 @@ describe( 'Linter plugin', () => { ] } } ], - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } } ], getTestedModules() ); linter._lintParams(); @@ -209,7 +209,7 @@ describe( 'Linter plugin', () => { comment: `* {@link module:utils/a~A#method1} * {@link module:utils/b~Some1} `, - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } } ], getTestedModules() ); linter._lintLinks(); @@ -222,11 +222,11 @@ describe( 'Linter plugin', () => { comment: `/** Linking test:\n *\n * * a:\n * * {@link module:ckeditor5/a~A} `, - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } }, { comment: '', longname: 'module:ckeditor5/a~A', - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } } ], getTestedModules() ); linter._lintLinks(); @@ -237,11 +237,11 @@ describe( 'Linter plugin', () => { it( 'should validate links with name', () => { const linter = new DocletValidator( [ { comment: ' {@link module:ckeditor5/a~A classA} ', - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } }, { comment: '', longname: 'module:ckeditor5/a~A', - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } } ], getTestedModules() ); linter._lintLinks(); @@ -252,11 +252,11 @@ describe( 'Linter plugin', () => { it( 'should validate links with white spaces', () => { const linter = new DocletValidator( [ { comment: ' {@link \n module:ckeditor5/a~A \n\t classA} ', - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } }, { comment: '', longname: 'module:ckeditor5/a~A', - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } } ], getTestedModules() ); linter._lintLinks(); @@ -267,11 +267,11 @@ describe( 'Linter plugin', () => { it( 'should validate links with multi-word link', () => { const linter = new DocletValidator( [ { comment: ' {@link module:ckeditor5/a~A with multi word link} ', - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } }, { comment: '', longname: 'module:ckeditor5/a~A', - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } } ], getTestedModules() ); linter._lintLinks(); @@ -282,11 +282,11 @@ describe( 'Linter plugin', () => { it( 'should validate links that contain double link keyword', () => { const linter = new DocletValidator( [ { comment: '{@link @link module:ckeditor5/a~A with multi word link} ', - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } }, { comment: '', longname: 'module:ckeditor5/a~A', - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } } ], getTestedModules() ); linter._lintLinks(); @@ -304,15 +304,15 @@ describe( 'Linter plugin', () => { Random comment: {priority: 'high'} Invalid link: {module:ckeditor5/a~B} `, - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } }, { comment: '', longname: 'module:ckeditor5/a~A', - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } }, { comment: '', longname: 'module:ckeditor5/a~B', - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } } ], getTestedModules() ); linter._lintLinks(); @@ -324,7 +324,7 @@ describe( 'Linter plugin', () => { it( 'should validate comment without any link', () => { const linter = new DocletValidator( [ { comment: 'Some comment without any valid nor invalid link', - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } } ], getTestedModules() ); linter._lintLinks(); @@ -372,7 +372,7 @@ describe( 'Linter plugin', () => { kind: 'class', longname: 'module:abc/SomeClass', meta: { fileName: '', path: '' }, - fires: [ 'someEvent' ], + fires: [ 'someEvent' ] } ], getTestedModules() ); linter._lintEvents(); @@ -385,7 +385,7 @@ describe( 'Linter plugin', () => { kind: 'class', longname: 'module:abc/SomeClass', meta: { fileName: '', path: '' }, - fires: [ 'module:abc/SomeClass#event:someEvent' ], + fires: [ 'module:abc/SomeClass#event:someEvent' ] }, { kind: 'event', longname: 'module:abc/SomeClass#event:someEvent' @@ -401,7 +401,7 @@ describe( 'Linter plugin', () => { kind: 'class', longname: 'module:abc/SomeClass', meta: { fileName: '', path: '' }, - fires: [ 'module:abc/SomeClass#event:someEvent' ], + fires: [ 'module:abc/SomeClass#event:someEvent' ] }, { kind: 'not-event', longname: 'module:abc/SomeClass#event:someEvent' @@ -413,16 +413,16 @@ describe( 'Linter plugin', () => { } ); } ); - it( '_lintModuleDocumentedExports()', () => { + it( '_lintModuleDocumentedExports() - show errors', () => { const linter = new DocletValidator( [ { kind: 'member', scope: 'inner', memberof: 'module:utils/emittermixin', - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } }, { kind: 'module', longname: 'module:utils/emittermixin', - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } } ], getTestedModules() ); linter._lintModuleDocumentedExports(); @@ -435,7 +435,7 @@ describe( 'Linter plugin', () => { kind: 'member', scope: 'inner', memberof: 'module:utils/emittermixin~EmitterMixin', - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } } ], getTestedModules() ); linter._lintModuleDocumentedExports(); @@ -448,13 +448,13 @@ describe( 'Linter plugin', () => { kind: 'class', longname: 'module:utils/emittermixin~EmitterMixin', see: [ - 'module:utils/emittermixin~EmitterMixin#constructor', + 'module:utils/emittermixin~EmitterMixin#constructor' ], - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } }, { kind: 'member', longname: 'module:utils/emittermixin~EmitterMixin#constructor', - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } } ], getTestedModules() ); linter._lintSeeReferences(); @@ -466,9 +466,9 @@ describe( 'Linter plugin', () => { const linter = new DocletValidator( [ { kind: 'class', see: [ - 'module:utils/emittermixin~EmitterMixin', + 'module:utils/emittermixin~EmitterMixin' ], - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } } ], getTestedModules() ); linter._lintSeeReferences(); @@ -485,9 +485,9 @@ describe( 'Linter plugin', () => { 'String', 'Map.' ] - }, + } } ], - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } } ], getTestedModules() ); linter._lintTypedefs(); @@ -503,9 +503,9 @@ describe( 'Linter plugin', () => { names: [ 'Abc' ] - }, + } } ], - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } } ], getTestedModules() ); linter._lintTypedefs(); @@ -521,7 +521,7 @@ describe( 'Linter plugin', () => { expect( result ).to.be.equal( true ); } ); - it( 'Should validate generic type', () => { + it( 'Should validate generic type (Array.)', () => { const linter = new DocletValidator( [] ); const result = linter._isCorrectType( 'Array.' ); @@ -553,7 +553,7 @@ describe( 'Linter plugin', () => { const linter = new DocletValidator( [ { longname: 'module:core/editor~Editor', kind: 'function', - meta: { fileName: '', path: '' }, + meta: { fileName: '', path: '' } } ], getTestedModules() ); const result = linter._isCorrectType( 'Array.' ); @@ -561,7 +561,7 @@ describe( 'Linter plugin', () => { expect( result ).to.be.equal( true ); } ); - it( 'Should validate generic type', () => { + it( 'Should validate generic type (Array)', () => { const linter = new DocletValidator( [] ); const result = linter._isCorrectType( 'Array.<*>' ); @@ -602,6 +602,6 @@ function getTestedModules() { return [ 'module:utils', 'module:engine', - 'module:ckeditor5', + 'module:ckeditor5' ]; } diff --git a/packages/jsdoc-plugins/tests/fix-interfaces-and-classes.js b/packages/jsdoc-plugins/tests/fix-interfaces-and-classes.js index c62a22780..db6b4ea7e 100644 --- a/packages/jsdoc-plugins/tests/fix-interfaces-and-classes.js +++ b/packages/jsdoc-plugins/tests/fix-interfaces-and-classes.js @@ -46,7 +46,7 @@ describe( 'Long name fix plugin - fixShortRefs()', () => { filename: 'interface.js' }, longname: '#destroy', - name: 'destroy', + name: 'destroy' } } ); @@ -73,7 +73,7 @@ describe( 'Long name fix plugin - fixShortRefs()', () => { filename: 'editormixin.js' }, longname: '#destroy', - name: 'destroy', + name: 'destroy' } } ); @@ -101,8 +101,8 @@ describe( 'Long name fix plugin - fixShortRefs()', () => { }, longname: 'module:someModule~SomeOtherClass#destroy', memberof: 'module:someModule~SomeOtherClass', - name: 'destroy', - }, + name: 'destroy' + } } ); expect( result.doclet.memberof ).to.be.equal( 'module:someModule~SomeOtherClass' ); @@ -128,8 +128,8 @@ describe( 'Long name fix plugin - fixShortRefs()', () => { filename: 'editor.js' }, longname: '~Editor#name', - name: 'name', - }, + name: 'name' + } } ); expect( result.doclet.longname ).to.be.equal( 'module:editor~Editor#name' ); @@ -146,7 +146,7 @@ describe( 'Long name fix plugin - fixShortRefs()', () => { meta: { path: '/', filename: 'editor.js' - }, + } }, doclet: { kind: 'event', @@ -157,7 +157,7 @@ describe( 'Long name fix plugin - fixShortRefs()', () => { name: 'blur', longname: 'event:blur', memberof: 'module:editor~Editor' - }, + } } ); expect( result.doclet.longname ).to.be.equal( @@ -175,7 +175,7 @@ describe( 'Long name fix plugin - fixShortRefs()', () => { meta: { path: '/', filename: 'editor.js' - }, + } }, doclet: { kind: 'event', @@ -186,7 +186,7 @@ describe( 'Long name fix plugin - fixShortRefs()', () => { name: 'event:blur', longname: 'module:editor2~Editor#event:blur', memberof: 'module:editor2~Editor' - }, + } } ); expect( result.doclet.longname ).to.be.equal( @@ -204,7 +204,7 @@ describe( 'Long name fix plugin - fixShortRefs()', () => { meta: { path: '/', filename: 'editor.js' - }, + } }, doclet: { kind: 'function', @@ -216,7 +216,7 @@ describe( 'Long name fix plugin - fixShortRefs()', () => { fires: [ 'event:execute' ], longname: 'module:editor~Editor#execute', memberof: 'module:editor~Editor' - }, + } } ); expect( result.doclet.fires[ 0 ] ).to.be.equal( @@ -234,7 +234,7 @@ describe( 'Long name fix plugin - fixShortRefs()', () => { meta: { path: '/', filename: 'editor.js' - }, + } }, doclet: { kind: 'function', @@ -246,7 +246,7 @@ describe( 'Long name fix plugin - fixShortRefs()', () => { fires: [ 'change:attribute' ], longname: 'module:editor~Editor#attr', memberof: 'module:editor~Editor' - }, + } } ); expect( result.doclet.fires[ 0 ] ).to.be.equal( @@ -264,7 +264,7 @@ describe( 'Long name fix plugin - fixShortRefs()', () => { meta: { path: '/', filename: 'editor.js' - }, + } }, doclet: { kind: 'function', @@ -276,7 +276,7 @@ describe( 'Long name fix plugin - fixShortRefs()', () => { see: [ '#create' ], longname: 'module:editor~Editor#attr', memberof: 'module:editor~Editor' - }, + } } ); expect( result.doclet.see[ 0 ] ).to.be.equal( diff --git a/packages/jsdoc-plugins/tests/fix-links.js b/packages/jsdoc-plugins/tests/fix-links.js index 71d31a11c..d9fa057d2 100644 --- a/packages/jsdoc-plugins/tests/fix-links.js +++ b/packages/jsdoc-plugins/tests/fix-links.js @@ -21,7 +21,7 @@ describe( 'Long name fix plugin - formatLinks()', () => { const doclet = formatLinksInDoclet( { comment: 'Creates {@link ~EditorInterface} instance', description: '

Creates {@link ~EditorInterface} instance

', - memberof: 'module:ckeditor5/editor/editorinterface', + memberof: 'module:ckeditor5/editor/editorinterface' } ); expect( doclet.comment ).to.be.equal( @@ -35,7 +35,7 @@ describe( 'Long name fix plugin - formatLinks()', () => { it( 'formatLinks() hash', () => { const doclet = formatLinksInDoclet( { comment: 'Method {@link #create} creates instance', - memberof: 'module:ckeditor5/editor/editorinterface~EditorInterface', + memberof: 'module:ckeditor5/editor/editorinterface~EditorInterface' } ); expect( doclet.comment ).to.be.equal( @@ -46,7 +46,7 @@ describe( 'Long name fix plugin - formatLinks()', () => { it( 'formatLinks() with link description', () => { const doclet = formatLinksInDoclet( { comment: 'Creates {@link ~EditorInterface editor} instance with a given name.', - memberof: 'module:ckeditor5/editor/editorinterface', + memberof: 'module:ckeditor5/editor/editorinterface' } ); expect( doclet.comment ).to.be.equal( @@ -57,7 +57,7 @@ describe( 'Long name fix plugin - formatLinks()', () => { it( 'formatLinks() with more complicated path', () => { const doclet = formatLinksInDoclet( { comment: 'Method {@link ~EditorInterface#create create} creates Editor', - memberof: 'module:ckeditor5/editor/editorinterface', + memberof: 'module:ckeditor5/editor/editorinterface' } ); expect( doclet.comment ).to.be.equal( @@ -69,7 +69,7 @@ describe( 'Long name fix plugin - formatLinks()', () => { const doclet = formatLinksInDoclet( { comment: '', description: 'You can later destroy it with {@link ~EditorInterface#destroy}', - memberof: 'module:ckeditor5/editor/editorinterface', + memberof: 'module:ckeditor5/editor/editorinterface' } ); expect( doclet.description ).to.be.equal( @@ -80,7 +80,7 @@ describe( 'Long name fix plugin - formatLinks()', () => { it( 'formatLinks() multiple links', () => { const doclet = formatLinksInDoclet( { comment: '{@link #destroy} {@link #destroy}', - memberof: 'module:editor/editorinterface', + memberof: 'module:editor/editorinterface' } ); expect( doclet.comment ).to.be.equal( @@ -91,7 +91,7 @@ describe( 'Long name fix plugin - formatLinks()', () => { it( 'formatLinks() link to parent: class / interface', () => { const doclet = formatLinksInDoclet( { comment: '{@link ~EditorInterface}', - memberof: 'module:editor/editorinterface~EditorInterface', + memberof: 'module:editor/editorinterface~EditorInterface' } ); expect( doclet.comment ).to.be.equal( @@ -102,7 +102,7 @@ describe( 'Long name fix plugin - formatLinks()', () => { it( 'formatLinks() with multi-word link', () => { const doclet = formatLinksInDoclet( { comment: 'Creates {@link ~EditorInterface some editor} instance with a given name.', - memberof: 'module:ckeditor5/editor/editorinterface', + memberof: 'module:ckeditor5/editor/editorinterface' } ); expect( doclet.comment ).to.be.equal( @@ -116,10 +116,10 @@ describe( 'Long name fix plugin - formatLinks()', () => { doclet: { kind: 'error', comment: 'The {@link #constructor source} of a rect in an HTML element', - description: '

The {@link #constructor source} of a rect in an HTML element

', + description: '

The {@link #constructor source} of a rect in an HTML element

' }, lastInterfaceOrClass: { - longname: 'module:ckeditor5-utils/dom/rect~Rect', + longname: 'module:ckeditor5-utils/dom/rect~Rect' } }; @@ -127,10 +127,10 @@ describe( 'Long name fix plugin - formatLinks()', () => { doclet: { kind: 'error', comment: 'The {@link module:ckeditor5-utils/dom/rect~Rect#constructor source} of a rect in an HTML element', - description: '

The {@link module:ckeditor5-utils/dom/rect~Rect#constructor source} of a rect in an HTML element

', + description: '

The {@link module:ckeditor5-utils/dom/rect~Rect#constructor source} of a rect in an HTML element

' }, lastInterfaceOrClass: { - longname: 'module:ckeditor5-utils/dom/rect~Rect', + longname: 'module:ckeditor5-utils/dom/rect~Rect' } } ); } ); diff --git a/packages/jsdoc-plugins/tests/integration-tests/data/mixin.jsdoc b/packages/jsdoc-plugins/tests/integration-tests/data/mixin.jsdoc index 95a616509..09e5da625 100644 --- a/packages/jsdoc-plugins/tests/integration-tests/data/mixin.jsdoc +++ b/packages/jsdoc-plugins/tests/integration-tests/data/mixin.jsdoc @@ -19,7 +19,7 @@ const EmitterMixin = { */ on( event, callback, options = {} ) { this.listenTo( this, event, callback, options ); - }, + } }; export default EmitterMixin; diff --git a/packages/jsdoc-plugins/tests/integration-tests/utils/parsefiles.js b/packages/jsdoc-plugins/tests/integration-tests/utils/parsefiles.js index 3b4b131c4..3c44ef741 100644 --- a/packages/jsdoc-plugins/tests/integration-tests/utils/parsefiles.js +++ b/packages/jsdoc-plugins/tests/integration-tests/utils/parsefiles.js @@ -22,7 +22,7 @@ module.exports = function parseFiles() { require.resolve( '../../../lib/longname-fixer/longname-fixer' ), require.resolve( '../../../lib/event-extender/event-extender' ), - require.resolve( './logger' ), + require.resolve( './logger' ) ], source: { include: files diff --git a/packages/jsdoc-plugins/tests/relation-fixer/test-data/inheritance-implicit.js b/packages/jsdoc-plugins/tests/relation-fixer/test-data/inheritance-implicit.js index b8d36dad3..61b73e553 100644 --- a/packages/jsdoc-plugins/tests/relation-fixer/test-data/inheritance-implicit.js +++ b/packages/jsdoc-plugins/tests/relation-fixer/test-data/inheritance-implicit.js @@ -28,5 +28,5 @@ module.exports = [ augmentsNested: [ 'classA' ] - }, + } ]; diff --git a/packages/jsdoc-plugins/tests/relation-fixer/test-data/mixins.js b/packages/jsdoc-plugins/tests/relation-fixer/test-data/mixins.js index bbd8f153b..1619da2ec 100644 --- a/packages/jsdoc-plugins/tests/relation-fixer/test-data/mixins.js +++ b/packages/jsdoc-plugins/tests/relation-fixer/test-data/mixins.js @@ -49,5 +49,5 @@ module.exports = [ 'classA' ], mixesNested: [ 'mixinA' ] - }, + } ]; diff --git a/packages/jsdoc-plugins/tests/relation-fixer/test-data/unwanted-doclets.js b/packages/jsdoc-plugins/tests/relation-fixer/test-data/unwanted-doclets.js index dc1f57dda..cb8a1a0a6 100644 --- a/packages/jsdoc-plugins/tests/relation-fixer/test-data/unwanted-doclets.js +++ b/packages/jsdoc-plugins/tests/relation-fixer/test-data/unwanted-doclets.js @@ -45,5 +45,5 @@ module.exports = [ augmentsNested: [ 'classA' ] - }, + } ];