Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog button focus is not visible enough in High Contrast mode #4892

Closed
jswiderski opened this issue Sep 16, 2021 · 2 comments · Fixed by #4933
Closed

Dialog button focus is not visible enough in High Contrast mode #4892

jswiderski opened this issue Sep 16, 2021 · 2 comments · Fixed by #4933
Assignees
Labels
accessibility Issue related to accessibility. plugin:dialog The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. support:2 An issue reported by a commercially licensed client. type:bug A bug.
Milestone

Comments

@jswiderski
Copy link
Contributor

📝 Provide detailed reproduction steps (if any)

  1. Switch your screen to High Contrast (HC) Mode in white color.
  2. Open https://ckeditor.com/docs/ckeditor4/latest/examples/fullpreset.html
  3. Open link dialog and start tabbing through fields until you reach Ok/Cancel button

✔️ Expected result

When Ok or Cancel button is focused, the focus should be clearly visible. 

❌ Actual result

Focus is really subtle and could be missed by visually impaired users. 

❓ Possible solution

File ckeditor/skins/moono-lisa/dialog.css contains the following CSS rule:

.cke_hc a.cke_dialog_ui_button {
    border: 3px solid #bcbcbc;
}

If you change 3px to 1px, it should  become visible enough.

📃 Other details

  • Browser: Any
  • OS: Windows
  • First affected CKEditor version: 4.6
  • Installed CKEditor plugins: N/A

If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@jswiderski jswiderski changed the title Dialob button focus is not visible enough in High Contrast mode. Dialog button focus is not visible enough in High Contrast mode. Sep 16, 2021
@mlewand mlewand transferred this issue from ckeditor/ckeditor5 Sep 16, 2021
@mlewand
Copy link
Contributor

mlewand commented Sep 16, 2021

@jswiderski I moved the issue to CKE4 repository.

@Comandeer Comandeer added accessibility Issue related to accessibility. plugin:dialog The plugin which probably causes the issue. size:? status:confirmed An issue confirmed by the development team. type:bug A bug. labels Sep 17, 2021
@lslowikowska lslowikowska added the support:2 An issue reported by a commercially licensed client. label Oct 15, 2021
@jacekbogdanski jacekbogdanski changed the title Dialog button focus is not visible enough in High Contrast mode. Dialog button focus is not visible enough in High Contrast mode Oct 18, 2021
@KarolDawidziuk KarolDawidziuk self-assigned this Oct 19, 2021
@CKEditorBot
Copy link
Collaborator

Closed in #4933

@CKEditorBot CKEditorBot added this to the 4.17.1 milestone Oct 20, 2021
@Comandeer Comandeer modified the milestones: 4.17.1, 4.17.0 Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issue related to accessibility. plugin:dialog The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. support:2 An issue reported by a commercially licensed client. type:bug A bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants