Autocomplete loses navigation keybindings after switching source mode

[jacekbogdanski]

Type of report

Bug

Provide detailed reproduction steps (if any)

1. Open any sample with autocomplete and sourcearea plugins.
2. Switch between source editing and content editing.
3. Trigger autocompletion.
4. Navigate using arrow keys.

Expected result

You can navigate through the completion panel using a keyboard.

Actual result

Keybindings are removed.

Other details

Probably standard issue with incorrect event listener on editable where we should use attachListener instead:

ckeditor4/plugins/autocomplete/plugin.js

Lines 307 to 309 in 5ace43e

	this._listeners.push( editable.on( 'keydown', function( evt ) {
	this.onKeyDown( evt );
	}, this, null, 5 ) );

[f1ames]

The correct way is to attach key listeners inside contentDom event listener, same as e.g. here:

ckeditor4/core/selection/optimization.js

Lines 24 to 38 in 258c8ec

	editor.on( 'contentDom', function() {
	var editable = editor.editable();
	if ( !editable ) {
	return;
	}
	editable.attachListener( editable, 'keydown', function( evt ) {
	this._.shiftPressed = evt.data.$.shiftKey;
	}, this );
	editable.attachListener( editable, 'keyup', function( evt ) {
	this._.shiftPressed = evt.data.$.shiftKey;
	}, this );
	} );

[f1ames]

Fixed in f0dfded.