Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error thrown when quickly changing routes #44

Closed
engineering-this opened this issue May 20, 2019 · 3 comments
Closed

Error thrown when quickly changing routes #44

engineering-this opened this issue May 20, 2019 · 3 comments
Milestone
1.0.0

Comments

@engineering-this
Copy link
Contributor

engineering-this commented May 20, 2019 •
edited
Loading

Are you reporting a feature request or a bug?

Feature (workaround for upstream bug).

Provide detailed reproduction steps (if any)

  1. Open sample: https://ckeditor.com/docs/ckeditor4/latest/examples/react.html#/
  2. Open dev console.
  3. Start quickly changing routes (randomly click on buttons under "Click the tab below to change an example.").

Expected result

No errors in console.

Actual result

Errors in console

Screenshot 2019-05-20 at 13 05 54

Other details

This is related to issues that we have with Angular and Vue integrations. Happens when component is unmounted before editor is fully initialized.

  • Browser: …
  • OS: …
  • Integration version: 1.0.0-beta
  • CKEditor version: 4.11.4
  • Installed CKEditor plugins: …
@engineering-this
Copy link
Contributor Author

Technically this is an upstream to CKEditor 4. However it can be fixed on Integration side, so this ticket is a feature request for workaround. We will try to fix the editor if we success this can be closed.

@engineering-this engineering-this mentioned this issue May 20, 2019
Closed
@f1ames f1ames added this to the 1.0.0 milestone May 30, 2019
@benjy benjy mentioned this issue Jun 19, 2019
Closed
@f1ames f1ames mentioned this issue Jul 12, 2019
Closed
@f1ames
Copy link
Contributor

f1ames commented Jul 12, 2019

Probably related - #35, #49.

@f1ames f1ames mentioned this issue Jul 31, 2019
Closed
@f1ames
Copy link
Contributor

f1ames commented Oct 9, 2019

Fixed in 7b34d2c via ckeditor/ckeditor4#3128.

@f1ames f1ames closed this as completed Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@f1ames @engineering-this