Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The 5.12.1 menu lacks color styling when used with Shoreditch #388

Closed
johncronan opened this issue Apr 17, 2019 · 9 comments
Closed

The 5.12.1 menu lacks color styling when used with Shoreditch #388

johncronan opened this issue Apr 17, 2019 · 9 comments

Comments

@johncronan
Copy link

johncronan commented Apr 17, 2019

This showed up for me after installing 5.12.1. In 5.12.0 there were also menu changes, but this problem with the colors was not present.

I'm not sure whether it's meant to be light or dark anymore!

Screen Shot 2019-04-16 at 9 47 34 PM

My Shoreditch version is 0.1-alpha31 and my Drupal version is 8.6.14.

edited to add: I probably should have quit out of Flux before taking the screenshot - that's why it's yellowish.

@MegaphoneJon
Copy link

I had the same problem with D8, but doing either cv flush or drush cr fixed it for me. However - I think you have a secondary problem in this screenshot that I did - the text in the Quicksearch box is an off-white. Can you confirm if that's happening for you?

@johncronan
Copy link
Author

It's still happening for me after cv flush and drush cr.

When you type text into the quicksearch it's hard to read, yes:

Screen Shot 2019-04-17 at 1 29 47 PM

@MegaphoneJon
Copy link

Sorry to hear that it didn't fix things for you! Meanwhile, I was able to replicate the off-white issue on a non-Shoreditch site - it's CMS theme-dependent, but separate from Shoreditch so I'll take this elsewhere.

@johncronan
Copy link
Author

Oh, okay. Well, this is not a functional issue with the site. I can afford to see if it shakes out in a coming point release, or something like that.

@MegaphoneJon
Copy link

@johncronan FWIW, I just submitted a patch on the Quicksearch color issue, and it's already been merged: civicrm/civicrm-core#14080

@colemanw
Copy link
Member

5.12.1 introduced configurable menu colors. With Shoreditch enables you should change the color to white.

@johncronan
Copy link
Author

Change it where? I can't find the setting.

@colemanw
Copy link
Member

Admin -> Customize Data & Screens -> Display Prefs

@johncronan
Copy link
Author

That worked. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants