From 4e42b2bbac35296c84ed318a807f53b328c1cf01 Mon Sep 17 00:00:00 2001 From: Seamus Lee Date: Thu, 15 Sep 2016 14:23:14 +1000 Subject: [PATCH 1/2] Fix PayPal test as it appears contributions are now getting set to be completed and not pending --- tests/phpunit/CRM/Contribute/Form/ContributionTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/phpunit/CRM/Contribute/Form/ContributionTest.php b/tests/phpunit/CRM/Contribute/Form/ContributionTest.php index e22f1071d59b..587d54bbcb59 100644 --- a/tests/phpunit/CRM/Contribute/Form/ContributionTest.php +++ b/tests/phpunit/CRM/Contribute/Form/ContributionTest.php @@ -234,7 +234,7 @@ public function testSubmitCreditCardPayPal() { } $this->callAPISuccessGetCount('Contribution', array( 'contact_id' => $this->_individualId, - 'contribution_status_id' => 'Pending', + 'contribution_status_id' => 'Completed', ), 1); $contact = $this->callAPISuccessGetSingle('Contact', array('id' => $this->_individualId)); $this->assertTrue(empty($contact['source'])); From 5c9fdd850d7fd838a4e331fa8d0b6f41b3c9e3e8 Mon Sep 17 00:00:00 2001 From: Seamus Lee Date: Fri, 30 Sep 2016 07:58:46 +1000 Subject: [PATCH 2/2] Re-enable paypal test --- tests/phpunit/CRM/Contribute/Form/ContributionTest.php | 3 --- 1 file changed, 3 deletions(-) diff --git a/tests/phpunit/CRM/Contribute/Form/ContributionTest.php b/tests/phpunit/CRM/Contribute/Form/ContributionTest.php index 587d54bbcb59..82042dec352a 100644 --- a/tests/phpunit/CRM/Contribute/Form/ContributionTest.php +++ b/tests/phpunit/CRM/Contribute/Form/ContributionTest.php @@ -185,9 +185,6 @@ public function testSubmitCreditCard() { * Test the submit function on the contribution page. */ public function testSubmitCreditCardPayPal() { - $this->markTestIncomplete('Paypal is creating a complete contribution but we are testing pending - we are unsure at this point if this is correct behaviour or not'); - return; $form = new CRM_Contribute_Form_Contribution(); $paymentProcessorID = $this->paymentProcessorCreate(array('is_test' => 0)); $form->_mode = 'Live';