Merge pull request #20358 from eileenmcnaughton/partial

Remove legacy references to partial_amount_to_pay

Author: monishdeb

CRM/Contribute/BAO/Contribution.php

@@ -3626,9 +3626,7 @@ public static function recordFinancialAccounts(&$params, $financialTrxnValues =
         $trxnParams['card_type_id'] = $params['card_type_id'] ?? NULL;
         $return = $financialTxn = CRM_Core_BAO_FinancialTrxn::create($trxnParams);
         $params['entity_id'] = $financialTxn->id;
-        if (empty($params['partial_payment_total']) && empty($params['partial_amount_to_pay'])) {
-          self::$_trxnIDs[] = $financialTxn->id;
-        }
+        self::$_trxnIDs[] = $financialTxn->id;
       }
     }
     // record line items and financial items

CRM/Event/Form/Participant.php

@@ -1312,7 +1312,7 @@ public function submit($params) {
             );
           }
 
-          // CRM-13964 partial_payment_total
+          // CRM-13964 partial payment
           if ($amountOwed > $params['total_amount']) {
             // the owed amount
             $contributionParams['total_amount'] = $amountOwed;

CRM/Price/BAO/LineItem.php

@@ -490,7 +490,7 @@ public static function syncLineItems($entityId, $entityTable = 'civicrm_contribu
   public static function getLineItemArray(&$params, $entityId = NULL, $entityTable = 'contribution', $isRelatedID = FALSE) {
     if (!$entityId) {
       $priceSetDetails = CRM_Price_BAO_PriceSet::getDefaultPriceSet($entityTable);
-      $totalAmount = CRM_Utils_Array::value('partial_payment_total', $params, CRM_Utils_Array::value('total_amount', $params));
+      $totalAmount = $params['total_amount'] ?? 0;
       $financialType = $params['financial_type_id'] ?? NULL;
       foreach ($priceSetDetails as $values) {
         if ($entityTable == 'membership') {

CRM/Price/BAO/PriceField.php

@@ -804,7 +804,7 @@ public static function priceSetValidation($priceSetId, $fields, &$error, $allowN
       // now we have all selected amount in hand.
       $totalAmount = array_sum($selectedAmounts);
       // The form offers a field to enter the amount paid. This may differ from the amount that is due to complete the purchase
-      $totalPaymentAmountEnteredOnForm = CRM_Utils_Array::value('partial_payment_total', $fields, CRM_Utils_Array::value('total_amount', $fields));
+      $totalPaymentAmountEnteredOnForm = CRM_Utils_Array::value('total_amount', $fields);
       if ($totalAmount < 0) {
         $error['_qf_default'] = ts('%1 amount can not be less than zero. Please select the options accordingly.', [1 => $componentName]);
       }

CRM/Price/BAO/PriceSet.php

@@ -1657,7 +1657,7 @@ public static function getLine(&$params, &$lineItem, $priceSetID, $field, $id):
       case 'Text':
         $firstOption = reset($field['options']);
         $params["price_{$id}"] = [$firstOption['id'] => $params["price_{$id}"]];
-        CRM_Price_BAO_LineItem::format($id, $params, $field, $lineItem, CRM_Utils_Array::value('partial_payment_total', $params));
+        CRM_Price_BAO_LineItem::format($id, $params, $field, $lineItem);
         $optionValueId = key($field['options']);
 
         if (CRM_Utils_Array::value('name', $field['options'][$optionValueId]) === 'contribution_amount') {
@@ -1691,7 +1691,7 @@ public static function getLine(&$params, &$lineItem, $priceSetID, $field, $id):
         $amount_override = NULL;
 
         if ($priceSetID && count(self::filterPriceFieldsFromParams($priceSetID, $params)) === 1) {
-          $amount_override = CRM_Utils_Array::value('partial_payment_total', $params, CRM_Utils_Array::value('total_amount', $params));
+          $amount_override = CRM_Utils_Array::value('total_amount', $params);
         }
         CRM_Price_BAO_LineItem::format($id, $params, $field, $lineItem, $amount_override);
         if (!empty($field['options'][$optionValueId]['tax_rate'])) {
@@ -1706,15 +1706,15 @@ public static function getLine(&$params, &$lineItem, $priceSetID, $field, $id):
         $params["price_{$id}"] = [$params["price_{$id}"] => 1];
         $optionValueId = CRM_Utils_Array::key(1, $params["price_{$id}"]);
 
-        CRM_Price_BAO_LineItem::format($id, $params, $field, $lineItem, CRM_Utils_Array::value('partial_payment_total', $params));
+        CRM_Price_BAO_LineItem::format($id, $params, $field, $lineItem);
         if (!empty($field['options'][$optionValueId]['tax_rate'])) {
           $lineItem = self::setLineItem($field, $lineItem, $optionValueId, $totalTax);
         }
         break;
 
       case 'CheckBox':
 
-        CRM_Price_BAO_LineItem::format($id, $params, $field, $lineItem, CRM_Utils_Array::value('partial_payment_total', $params));
+        CRM_Price_BAO_LineItem::format($id, $params, $field, $lineItem);
         foreach ($params["price_{$id}"] as $optionId => $option) {
           if (!empty($field['options'][$optionId]['tax_rate'])) {
             $lineItem = self::setLineItem($field, $lineItem, $optionId, $totalTax);