Skip to content

Commit dec8450

Browse files
authored
Merge pull request #20263 from colemanw/afformDragFix
Afform - Drag & drop fixes
2 parents c5f1d72 + 261a6a5 commit dec8450

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

ext/afform/admin/ang/afGuiEditor.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@
181181
$('#af-gui-icon-picker').crmIconPicker();
182182
});
183183
// Add css class while dragging
184-
$('#crm-container')
184+
$(document)
185185
.on('sortover', function(e) {
186186
$('.af-gui-container').removeClass('af-gui-dragtarget');
187187
$(e.target).closest('.af-gui-container').addClass('af-gui-dragtarget');
@@ -192,7 +192,7 @@
192192
.on('sortstart', '#afGuiEditor', function() {
193193
$('#afGuiEditor').addClass('af-gui-dragging');
194194
})
195-
.on('sortstop', '#afGuiEditor', function() {
195+
.on('sortstop', function() {
196196
$('.af-gui-dragging').removeClass('af-gui-dragging');
197197
$('.af-gui-dragtarget').removeClass('af-gui-dragtarget');
198198
});

ext/afform/admin/ang/afGuiEditor/afGuiEditor.component.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -238,13 +238,13 @@
238238
$target = $(sort.droptarget[0]),
239239
$item = $(ui.item[0]);
240240
// Fields cannot be dropped outside their own entity
241-
if ($item.is('[af-gui-field]') || $item.has('[af-gui-field]').length) {
241+
if ($item.find('af-gui-field').length) {
242242
if ($source.closest('[data-entity]').attr('data-entity') !== $target.closest('[data-entity]').attr('data-entity')) {
243243
return sort.cancel();
244244
}
245245
}
246246
// Entity-fieldsets cannot be dropped into other entity-fieldsets
247-
if ((sort.model['af-fieldset'] || $item.has('.af-gui-fieldset').length) && $target.closest('.af-gui-fieldset').length) {
247+
if ((sort.model['af-fieldset'] || $item.find('.af-gui-fieldset').length) && $target.closest('.af-gui-fieldset').length) {
248248
return sort.cancel();
249249
}
250250
}

0 commit comments

Comments
 (0)