diff --git a/CRM/Contribute/BAO/Contribution.php b/CRM/Contribute/BAO/Contribution.php index b4fe8f809a88..05459a3f99be 100644 --- a/CRM/Contribute/BAO/Contribution.php +++ b/CRM/Contribute/BAO/Contribution.php @@ -132,6 +132,7 @@ public static function add(&$params, $ids = array()) { else { // @todo put a deprecated here - this should be done in the form layer. $params['skipCleanMoney'] = FALSE; + Civi::log()->warning('Deprecated code path. Money should always be clean before it hits the BAO.', array('civi.tag' => 'deprecated')); } foreach ($moneyFields as $field) { diff --git a/CRM/Event/Form/Participant.php b/CRM/Event/Form/Participant.php index b9a1dec7cdcf..b7958bb4a078 100644 --- a/CRM/Event/Form/Participant.php +++ b/CRM/Event/Form/Participant.php @@ -986,7 +986,7 @@ public function submit($params) { } if ($this->_isPaidEvent) { - $contributionParams = array(); + $contributionParams = array('skipCleanMoney' => TRUE); $lineItem = array(); $additionalParticipantDetails = array(); if (CRM_Contribute_BAO_Contribution::checkContributeSettings('deferred_revenue_enabled')) { diff --git a/tests/phpunit/CRM/Core/Payment/AuthorizeNetTest.php b/tests/phpunit/CRM/Core/Payment/AuthorizeNetTest.php index 5bb68f8c5866..3575a24e761f 100644 --- a/tests/phpunit/CRM/Core/Payment/AuthorizeNetTest.php +++ b/tests/phpunit/CRM/Core/Payment/AuthorizeNetTest.php @@ -88,7 +88,7 @@ public function testCreateSingleNowDated() { 'is_test' => 1, 'contribution_status_id' => 2, ); - $contribution = CRM_Contribute_BAO_Contribution::add($contributionParams); + $contribution = $this->callAPISuccess('Contribution', 'create', $contributionParams); $params = array( 'qfKey' => '08ed21c7ca00a1f7d32fff2488596ef7_4454', diff --git a/tests/phpunit/CRM/Financial/BAO/FinancialAccountTest.php b/tests/phpunit/CRM/Financial/BAO/FinancialAccountTest.php index c67c76422b95..d3b284f1c455 100644 --- a/tests/phpunit/CRM/Financial/BAO/FinancialAccountTest.php +++ b/tests/phpunit/CRM/Financial/BAO/FinancialAccountTest.php @@ -145,7 +145,7 @@ public function testdelIfHasContribution() { 'financial_type_id' => $financialType->id, 'contribution_status_id' => 1, ); - $contributions = CRM_Contribute_BAO_Contribution::create($contributionParams); + $this->callAPISuccess('Contribution', 'create', $contributionParams); CRM_Financial_BAO_FinancialAccount::del($result->id); $params = array('id' => $result->id); $result = CRM_Financial_BAO_FinancialAccount::retrieve($params, $defaults);