diff --git a/CRM/Contribute/Form/Contribution/Main.php b/CRM/Contribute/Form/Contribution/Main.php index 1a23147d47bd..69fc0192cb7c 100644 --- a/CRM/Contribute/Form/Contribution/Main.php +++ b/CRM/Contribute/Form/Contribution/Main.php @@ -336,13 +336,8 @@ public function buildQuickForm() { $this->add('text', 'total_amount', ts('Total Amount'), ['readonly' => TRUE], FALSE); } $pps = []; - //@todo - this should be replaced by a check as to whether billing fields are set - $onlinePaymentProcessorEnabled = FALSE; if (!empty($this->_paymentProcessors)) { foreach ($this->_paymentProcessors as $key => $name) { - if ($name['billing_mode'] == 1) { - $onlinePaymentProcessorEnabled = TRUE; - } $pps[$key] = $name['name']; } } @@ -367,7 +362,7 @@ public function buildQuickForm() { $contactID = $this->getContactID(); if ($this->getContactID() === 0) { - $this->addCidZeroOptions($onlinePaymentProcessorEnabled); + $this->addCidZeroOptions(); } //build pledge block. diff --git a/CRM/Core/Form.php b/CRM/Core/Form.php index 5f61bbd2965f..9b10eb4199c3 100644 --- a/CRM/Core/Form.php +++ b/CRM/Core/Form.php @@ -2248,10 +2248,8 @@ public function canUseAjaxContactLookups() { * that small pieces of duplication are not being refactored into separate functions because their only shared parent * is this form. Inserting a class FrontEndForm.php between the contribution & event & this class would allow functions like this * and a dozen other small ones to be refactored into a shared parent with the reduction of much code duplication - * - * @param $onlinePaymentProcessorEnabled */ - public function addCIDZeroOptions($onlinePaymentProcessorEnabled) { + public function addCIDZeroOptions() { $this->assign('nocid', TRUE); $profiles = []; if ($this->_values['custom_pre_id']) { @@ -2260,9 +2258,7 @@ public function addCIDZeroOptions($onlinePaymentProcessorEnabled) { if ($this->_values['custom_post_id']) { $profiles = array_merge($profiles, (array) $this->_values['custom_post_id']); } - if ($onlinePaymentProcessorEnabled) { - $profiles[] = 'billing'; - } + $profiles[] = 'billing'; if (!empty($this->_values)) { $this->addAutoSelector($profiles); } diff --git a/CRM/Event/Form/Registration/Register.php b/CRM/Event/Form/Registration/Register.php index bb69047bc3ae..ac1388a35b3b 100644 --- a/CRM/Event/Form/Registration/Register.php +++ b/CRM/Event/Form/Registration/Register.php @@ -413,18 +413,14 @@ public function buildQuickForm() { $pps = []; //@todo this processor adding fn is another one duplicated on contribute - a shared // common class would make this sort of thing extractable - $onlinePaymentProcessorEnabled = FALSE; if (!empty($this->_paymentProcessors)) { foreach ($this->_paymentProcessors as $key => $name) { - if ($name['billing_mode'] == 1) { - $onlinePaymentProcessorEnabled = TRUE; - } $pps[$key] = $name['name']; } } if ($this->getContactID() === 0 && !$this->_values['event']['is_multiple_registrations']) { //@todo we are blocking for multiple registrations because we haven't tested - $this->addCIDZeroOptions($onlinePaymentProcessorEnabled); + $this->addCIDZeroOptions(); } if (!empty($this->_values['event']['is_pay_later']) && ($this->_allowConfirmation || (!$this->_requireApproval && !$this->_allowWaitlist))