From 86707c3e68bb9913434ef01e1ab4625d77efd506 Mon Sep 17 00:00:00 2001
From: Eileen McNaughton <emcnaughton@wikimedia.org>
Date: Fri, 11 Aug 2023 15:14:40 +1200
Subject: [PATCH] Remove do-nothing code.

This code conditionally adds the field is_required to the array that already
contains the field is_required
---
 CRM/Price/BAO/PriceSet.php | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/CRM/Price/BAO/PriceSet.php b/CRM/Price/BAO/PriceSet.php
index f2c2aa892fd6..7388afcc742c 100644
--- a/CRM/Price/BAO/PriceSet.php
+++ b/CRM/Price/BAO/PriceSet.php
@@ -386,7 +386,7 @@ public static function getAssoc($withInactive = FALSE, $extendComponentName = FA
    * @param int $setID
    *   Price Set ID.
    * @param bool $required
-   *   Appears to have no effect based on reading the code.
+   *   Deprecated.
    * @param bool $doNotIncludeExpiredFields
    *   Should only fields where today's date falls within the valid range be returned?
    *
@@ -415,9 +415,6 @@ public static function getSetDetail($setID, $required = TRUE, $doNotIncludeExpir
       'visibility_id',
       'is_required',
     ];
-    if ($required == TRUE) {
-      $priceFields[] = 'is_required';
-    }
 
     // create select
     $select = 'SELECT ' . implode(',', $priceFields);