From 4346bdb755640eadf502569aa99862a008a14fdb Mon Sep 17 00:00:00 2001 From: Alice Frumin Date: Wed, 2 Jan 2019 11:33:06 -0500 Subject: [PATCH] first stab at 5.9.0 release notes (#13) * first stab at release notes * some more notes * more release notes * more release note review * fixing formating issue * more release notes * a few release notes * more release notes * release notes * cleaning up release notes * reorganizing sections --- release-notes/5.9.0.md | 620 +++++++++++++++++++++++++++++++++-------- 1 file changed, 501 insertions(+), 119 deletions(-) diff --git a/release-notes/5.9.0.md b/release-notes/5.9.0.md index 14fc79b5ded4..4c362794d73e 100644 --- a/release-notes/5.9.0.md +++ b/release-notes/5.9.0.md @@ -9,253 +9,635 @@ Released January 2, 2019 - **[Credits](#credits)** - **[Feedback](#feedback)** +## Synopsis + +| *Does this version...?* | | +|:--------------------------------------------------------------- |:-------:| +| Fix security vulnerabilities? | | +| Change the database schema? | | +| Alter the API? | **yes** | +| Require attention to configuration options? | **yes** | +| Fix problems installing or upgrading to a previous version? | | +| Introduce features? | **yes** | +| Fix bugs? | **yes** | + ## Features ### Core CiviCRM -- **crm- Missing Summary ([13219](https://github.com/civicrm/civicrm-core/pull/13219))** +- **[dev/core#536](https://lab.civicrm.org/dev/core/issues/536) Contribution tab + is slow to render for contacts with many contributions (in large database) + ([13149](https://github.com/civicrm/civicrm-core/pull/13149))** + + This change improves performance of the Contributions tab on contact records. + +- **[dev/core#217](https://lab.civicrm.org/dev/core/issues/217) Allow + replacement of PrevNextCache implementation (for search screens) + ([13168](https://github.com/civicrm/civicrm-core/pull/13168) and + [12665](https://github.com/civicrm/civicrm-core/pull/12665))** + + This change makes it possible to use Redis to store the prev-next cache used + by contact-search screens by updating the setting "PrevNext Cache" on the + Administer -> Misc page. + +- **[dev/core#561](https://lab.civicrm.org/dev/core/issues/561) Replace + jcalendar instances with datepicker + ([13206](https://github.com/civicrm/civicrm-core/pull/13206), + [13208](https://github.com/civicrm/civicrm-core/pull/13208), + [13203](https://github.com/civicrm/civicrm-core/pull/13203), + [13196](https://github.com/civicrm/civicrm-core/pull/13196) and + [13198](https://github.com/civicrm/civicrm-core/pull/13198)) - Continues Work + Towards** + + These changes switch fields that store dates from jcalendar to use the + datepicker in the following places: the pledge payment form, the tagged + contributions custom search, the activity custom search form, the price field + form and the Event Aggregate Custom search. + +- **[dev/core#11](https://lab.civicrm.org/dev/core/issues/11) Email - send now + error screen should display earlier + ([13207](https://github.com/civicrm/civicrm-core/pull/13207))** + + From the results of an advanced search one can select the action option "Email - + send now (to 50 or less)" this change improves user experience by throwing an + error if a user tries to select more than 50 contacts and this action (when + displaying the results as contributions or memberships). + +- **[dev/core#505](https://lab.civicrm.org/dev/core/issues/505) Allow for + Extensions to set the CRM Type and PHP Type when dealing with unusual MySQL + Types ([13059](https://github.com/civicrm/civicrm-core/pull/13059))** + + This change makes it so extension authors can specify phpType and crmType + in their xml files. + +- **[dev/core#518](https://lab.civicrm.org/dev/core/issues/518) Lybunt + performance improvement + ([13088](https://github.com/civicrm/civicrm-core/pull/13088))** + + This change improves performance of the LYBUNT report. + +- **[dev-core#565](https://lab.civicrm.org/dev/core/issues/565) Make subject + field of Note, inline editable in contact summary page + ([13190](https://github.com/civicrm/civicrm-core/pull/13190))** + + This change makes it so that users can inline edit note fields on the contact + summary page. + +- **Make world_region translate on advanced search field + ([13212](https://github.com/civicrm/civicrm-core/pull/13212))** + + This change ensures that on the Advanced Search Form the world region field + gets translated. + +- **Fix Job Log entries containing links so they will display properly + ([12659](https://github.com/civicrm/civicrm-core/pull/12659))** + + This change improves the links and general html formating of the log for + the geocode scheduled job. + +- **Update npm dependencies to fix audit issues + ([13195](https://github.com/civicrm/civicrm-core/pull/13195))** + + This change updates several dependencies including: karma from 2.0.2 to + 3.1.1, jasmine-core from 3.1.0 to 3.3.0 and karma-jasmine from 1.1.2 to 2.0.1. + +- **Upgrade to Quickform 3.2.16 + ([224](https://github.com/civicrm/civicrm-packages/pull/224))** + + This change updates Quickform from 3.2.11 to 3.2.16. + +- **Lybunt report - improve developer support for debugging this report + ([13087](https://github.com/civicrm/civicrm-core/pull/13087))** + + This change makes it so that the developer tab on the Lybunt report shows + group queries. + +### CiviContribute + +- **Set default financial_type_id for creating new payment processors (form & + api) ([13181](https://github.com/civicrm/civicrm-core/pull/13181))** + + This change makes it so that the required field "Financial Account" on the + "New Payment Processor" form defaults to "Payment Processor Account". + +- **Fix Export when full group by mode is used + ([13124](https://github.com/civicrm/civicrm-core/pull/13124))** + + This change improves performance when exporting. + +### CiviEvent + +- **Update name of icon from pencil to wrench in EventInfo help + ([13119](https://github.com/civicrm/civicrm-core/pull/13119))** + + This change updates the help text on the Event info page to refer to the + wrench icon as a wrench (instead of as a pencil). + +- **Fix Configure Event help grammar + ([13118](https://github.com/civicrm/civicrm-core/pull/13118))** + + This change improves the grammar of the Configure Event help text. + +### CiviMail + +- **Display message template title on deletion form + ([13058](https://github.com/civicrm/civicrm-core/pull/13058))** + + This change improves user experience when deleting Message Templates by + displaying the Message Template name in the Deletion Confirmation popup. ## Bugs resolved ### Core CiviCRM -- **dev/core#442 Fix Style issues on word replacements, credit card expir… ([13197](https://github.com/civicrm/civicrm-core/pull/13197))** +- **Api3 - Add uf_user contact search param + ([13230](https://github.com/civicrm/civicrm-core/pull/13230))** -- **Api3 - Add uf_user contact search param ([13230](https://github.com/civicrm/civicrm-core/pull/13230))** + This change makes it so one can search contacts with and or without user + records thru the API. -- **dev/core#407 Fix mis-saving of price field values under localisation. ([13226](https://github.com/civicrm/civicrm-core/pull/13226))** +- **[dev/core#125](https://lab.civicrm.org/dev/core/issues/125) Invalid link to + custom-fields documentation + ([13199](https://github.com/civicrm/civicrm-core/pull/13199))** -- **dev/core#518 Fix lybunt performance ([13088](https://github.com/civicrm/civicrm-core/pull/13088))** + This change fixes the link to the Custom Fields documentation on the Custom + Group form to point to the correct documentation page. -- **5.8 to master ([13235](https://github.com/civicrm/civicrm-core/pull/13235))** +- **[dev/core#371](https://lab.civicrm.org/dev/core/issues/371) Be + environmentally friendly. Remove the sentence: "Please print this page for + your records." from the various CiviCRM tpls. We like trees! + ([13156](https://github.com/civicrm/civicrm-core/pull/13156))** -- **Typos, simplify if statement ([13233](https://github.com/civicrm/civicrm-core/pull/13233))** + This change removes the sentence "Please print this page for your records." + from the Thank You page for online contribution and event registration pages. -- **dev/core#563: Duplicate Case manager role fix ([13188](https://github.com/civicrm/civicrm-core/pull/13188))** +- **[dev/core#372](https://lab.civicrm.org/dev/core/issues/372) 5.6.alpha1 + notice ([13079](https://github.com/civicrm/civicrm-core/pull/13079))** -- **dev/core#529 open search panes when when reviewing smart groups if they have stuff selected ([13217](https://github.com/civicrm/civicrm-core/pull/13217))** + This change fixes a bug where editing an activity that had no details would + result in a notice error so that no notice error is thrown. -- **5.8 ([13229](https://github.com/civicrm/civicrm-core/pull/13229))** +- **[dev/core#406](https://lab.civicrm.org/dev/core/issues/406) 5.5.2: Import is + not happy on PHP-7.2 (Countable) + ([13133](https://github.com/civicrm/civicrm-core/pull/13133))** -- **Add custom search handling for jcalendar converstion. ([13209](https://github.com/civicrm/civicrm-core/pull/13209))** + This change fixes a "PHP Warning: count():" warning for users running php 7.2 + when importing. -- **[CRM-19115](https://issues.civicrm.org/jira/browse/CRM-19115) PHP and MySQL timezones mismatch over API but not in UI ([13220](https://github.com/civicrm/civicrm-core/pull/13220) and [13218](https://github.com/civicrm/civicrm-core/pull/13218))** +- **[dev/core#407](https://lab.civicrm.org/dev/core/issues/407) Error with + currency localization when recording a payment + ([13226](https://github.com/civicrm/civicrm-core/pull/13226))** -- **[REF] Rename recently added getUrlVariables getFormVariables function… ([13225](https://github.com/civicrm/civicrm-core/pull/13225))** + This change fixes a bug for users with a config with commas for the decimal + place and dots for the thousand separators where saving price set information + ON the membership tab for a contribution page would result in an error on + save. -- **dev/core/482 standardize contact edit form delete block behavior ([13169](https://github.com/civicrm/civicrm-core/pull/13169))** +- **[dev/core#442](https://lab.civicrm.org/dev/core/issues/442) Misc form issues + ([13197](https://github.com/civicrm/civicrm-core/pull/13197))** -- **dev/core#573 Fix select2 height on public pages ([13223](https://github.com/civicrm/civicrm-core/pull/13223))** + This change makes a variety of small styling improvements including: On the + New Individual form, in the "Tags and Groups" section aligning the Tags and + Groups boxes properly and using text inputs instead to text areas on the word + replacements form. -- **Set default financial_type_id for creating new payment processors (form & api) ([13181](https://github.com/civicrm/civicrm-core/pull/13181))** +- **[dev/core/482](https://lab.civicrm.org/dev/core/issues/482) New + Organization: There is no possible to add another website after deleting + ([13169](https://github.com/civicrm/civicrm-core/pull/13169)) -- Work + towards** -- **Make world_region translate on advanced search field ([13212](https://github.com/civicrm/civicrm-core/pull/13212))** + When adding a new contact via the "New Individual", "New Organization" etc + forms, or editing a contact, the website blocks allow a user to delete a block + even if it's the only one left. If one deletes the only website block the user + is not able to re-create a website block. This is non-standard for this form + i.e. Phone Number, Email, IM do not let a user delete a block if it's the only + one left. This change makes it so like Phone Number, Email, and IM one cannot + delete the last website block. -- **Prototype for metadata based fields on search screens. ([13013](https://github.com/civicrm/civicrm-core/pull/13013))** +- **[dev/core#503](https://lab.civicrm.org/dev/core/issues/503) Editing Rich + Text custom field on relationship non-functional + ([13076](https://github.com/civicrm/civicrm-core/pull/13076))** -- ** Add \Civi\Token\TokenProcessor::getContextValues() ([13214](https://github.com/civicrm/civicrm-core/pull/13214))** + This fixes a bug where editing a Note/RichTextEditor custom field on a + relationship would result in the HTML tags being encoded into the content (and + piling up each time one edits the field) so that the HTML tags to not get + encoded. -- **Remove '$dao->free()' part 1 ([13192](https://github.com/civicrm/civicrm-core/pull/13192))** +- **[dev/core#525](https://lab.civicrm.org/dev/core/issues/525) Extraneous + br-tags in rendered note-fields + ([13101](https://github.com/civicrm/civicrm-core/pull/13101))** -- **dev/core#11: Email - send now error screen should display earlier ([13207](https://github.com/civicrm/civicrm-core/pull/13207))** + This change fixes a bug where note fields were being rendered with extra blank + lines so that blank lines are not duplicated. -- **[REF] refactor shared search functions in pre-Process ([13210](https://github.com/civicrm/civicrm-core/pull/13210))** +- **[dev/core#527](https://lab.civicrm.org/dev/core/issues/527) Non translatable + fields in profile schema + ([13110](https://github.com/civicrm/civicrm-core/pull/13110))** -- **dev/core#561 Convert Pledge Payment form to use datepicker rather tha… ([13206](https://github.com/civicrm/civicrm-core/pull/13206))** + This change makes the "Public Title" field on the profile form translatable. -- **dev/core#561 Convert DateAdded and Tagged Contributions custom search… ([13208](https://github.com/civicrm/civicrm-core/pull/13208))** +- **[dev/core#528](https://lab.civicrm.org/dev/core/issues/528) Advanced Search -> + Contribution Tab and Contribution Dashboard returns a fatal error. + ([13112](https://github.com/civicrm/civicrm-core/pull/13112))** -- **dev/core#561 Convert Activity Custom Search from jcalendar to datepic… ([13203](https://github.com/civicrm/civicrm-core/pull/13203))** + This change fixes a network error when opening the Contributions tab on the + Advanced Search. -- **dev/core#561 Replace jacalendar with datepicker in Price Field Form ([13196](https://github.com/civicrm/civicrm-core/pull/13196))** +- **[dev/core#529](https://lab.civicrm.org/dev/core/issues/529) Editing smart + group removes search criteria unless criteria tabs are opened first + ([13217](https://github.com/civicrm/civicrm-core/pull/13217))** -- **dev/mail#23: Bounce processing doesn't catch pattern 'user doesn't exist' ([13200](https://github.com/civicrm/civicrm-core/pull/13200))** + This change ensures that when editing smart groups the previously selected + criteria is respected regardless of whether or not the criteria tabs are + opened first. -- **Prevent viewport jump when toggling help on "Administer CiviCRM" screen ([13173](https://github.com/civicrm/civicrm-core/pull/13173))** +- **[dev/core#532](https://lab.civicrm.org/dev/core/issues/532) Multi-select + field not respected in batch search + ([13121](https://github.com/civicrm/civicrm-core/pull/13121))** -- **dev-core#565: Make subject field of Note, inline editable in contact summary page ([13190](https://github.com/civicrm/civicrm-core/pull/13190))** + This change ensures that on the Batch form one can pick multiple options for + the field "Financial Type", before this change selecting multiple options for + the "Financial Type" field would result in the search failing. -- **dev/core#498 Update Mailing Report to fix undefined property error ([13194](https://github.com/civicrm/civicrm-core/pull/13194))** +- **[dev/core#540](https://lab.civicrm.org/dev/core/issues/540) Civicrm Contact + Dashboard returns fatal error + ([13140](https://github.com/civicrm/civicrm-core/pull/13140))** -- **Remove Defunct Templates from CiviMail ([13201](https://github.com/civicrm/civicrm-core/pull/13201))** + This fixes the 'Cannot determine api action for + CRM_Contribute_Form_Search.CRM_Core_Action "NO DESCRIPTION SET"' error when + visiting a url like https://dmaster.demo.civicrm.org/civicrm/user?reset=1. -- **(NFC) Regenerate DAO Checksums after changes to codegen ([13204](https://github.com/civicrm/civicrm-core/pull/13204))** +- **[dev/core#559](https://lab.civicrm.org/dev/core/issues/559) AngularJS module + crmUi has an unstated dependency on ui.utils + ([13180](https://github.com/civicrm/civicrm-core/pull/13180))** -- **dev/core#561 Remove jcalendar from the Event Aggregate Custom Search ([13198](https://github.com/civicrm/civicrm-core/pull/13198))** + This change decleares crmUi's dependency on ui.Utils so that developers do not + have to do so when creating custom AngularJS base pages. -- **Update npm dependencies to fix audit issues ([13195](https://github.com/civicrm/civicrm-core/pull/13195))** +- **[dev/core#573](https://lab.civicrm.org/dev/core/issues/573) State field + displays too small + ([13223](https://github.com/civicrm/civicrm-core/pull/13223))** -- **Flatten fix ([13176](https://github.com/civicrm/civicrm-core/pull/13176))** + This change fixes the styling of select 2's on front facing forms so that + the text is centered and the select 2 is approximately the same size as a text + box. -- **dev/core#125 Fix Doc url to custom fields user documentation ([13199](https://github.com/civicrm/civicrm-core/pull/13199))** +- **[dev/cloud-native/issues#18](https://lab.civicrm.org/dev/cloud-native/issues/18) + Soften messages for read-only extensionsDir + ([13100](https://github.com/civicrm/civicrm-core/pull/13100))** -- **(REF) Allow subclasses of AbstractTokenSubscriber to override the determination of active tokens. ([13186](https://github.com/civicrm/civicrm-core/pull/13186))** + This change makes it so that if the extensions directory is "Read Only" the + help text that appears is a notice instead of a warning. -- **5.8 ([13193](https://github.com/civicrm/civicrm-core/pull/13193))** +- **Add custom search handling for jcalendar converstion. + ([13209](https://github.com/civicrm/civicrm-core/pull/13209))** -- **Extract getContributionBalance function, use that rather than wrapper… ([13151](https://github.com/civicrm/civicrm-core/pull/13151))** + This change fixes smart groups created using the last activity custom search + and event aggregate custom search and a date field (post the jcalendar + conversion). -- **Test support for fixing dev/core#397 including adding Rule api ([13179](https://github.com/civicrm/civicrm-core/pull/13179))** +- **[CRM-19115](https://issues.civicrm.org/jira/browse/CRM-19115) PHP and MySQL + timezones mismatch over API but not in UI + ([13220](https://github.com/civicrm/civicrm-core/pull/13220) and + [13218](https://github.com/civicrm/civicrm-core/pull/13218))** -- **5.8 ([13184](https://github.com/civicrm/civicrm-core/pull/13184))** + This change makes it so the curl request for `System.check` reports that + `checkMysqlTime` passes because the PHP time and MySQL time are aligned. -- **5.8 ([13182](https://github.com/civicrm/civicrm-core/pull/13182))** +- **[dev/core#557](https://lab.civicrm.org/dev/core/issues/557) Prevent jump + when revealing help sections on "Administer CiviCRM" screen + ([13173](https://github.com/civicrm/civicrm-core/pull/13173))** -- **(dev/core#559) Declare crmUi's dependency on ui.utils. ([13180](https://github.com/civicrm/civicrm-core/pull/13180))** + On the "Administer CiviCRM" screen, this change makes it so that when one + opens a help section the page no longer jumps to the anchor. -- **Displayvalue fixes ([13175](https://github.com/civicrm/civicrm-core/pull/13175))** +- **Api3 profile:submit - fix handling of greeting fields + ([13161](https://github.com/civicrm/civicrm-core/pull/13161))** -- **dev/core#505 Allow Extensions to specify crmType and phpType when dea… ([13059](https://github.com/civicrm/civicrm-core/pull/13059))** + This change ensures that the Api3 call Profile.submit works with a custom + greeting selected. Specifically this change fixes a bug when using the Layout + Editor extension and attempting to save a custom greeting. -- **Fixes to enable UserDashboard tests to all run ([13147](https://github.com/civicrm/civicrm-core/pull/13147))** +- **Avoid permission checking on getOrganizationNames + ([13162](https://github.com/civicrm/civicrm-core/pull/13162))** -- **(dev/core#217) Search.setting.php - Fix mismatched metadata ([13168](https://github.com/civicrm/civicrm-core/pull/13168))** + This change ensures that users with contribution permissions can use + the Bookkeeping Transactions Report. -- **Set currency template variable from contribution pages ([13157](https://github.com/civicrm/civicrm-core/pull/13157))** +- **[CRM-21427](https://issues.civicrm.org/jira/browse/CRM-21427) Websites are + removed from the contact if their type is empty + ([13097](https://github.com/civicrm/civicrm-core/pull/13097))** -- **Api3 profile:submit - fix handling of greeting fields ([13161](https://github.com/civicrm/civicrm-core/pull/13161))** + This change fixes a bug where on the contact form, attempting to save + multiple websites of the same type would result in a validation error so that + one can save multiple websites of the same type on a contact record. -- **Avoid permission checking on getOrganizationNames ([13162](https://github.com/civicrm/civicrm-core/pull/13162))** +- **[dev/core#526](https://lab.civicrm.org/dev/core/issues/526) Feedback cannot + be translated when saving Contribution Page forms in languages other than + English ([13102](https://github.com/civicrm/civicrm-core/pull/13102))** -- **Trivial code cleanup ([13166](https://github.com/civicrm/civicrm-core/pull/13166))** + This change fixes a bug where, when saving a Contribution settings form the + feedback given is not translated or translatable so that it is translatable. -- **[NFC] Extract getUserCheckSum function ([13167](https://github.com/civicrm/civicrm-core/pull/13167))** +- **Add merge link to duplicate contact popup + ([13081](https://github.com/civicrm/civicrm-core/pull/13081))** -- **(dev/core#217) PrevNext - Implement Redis. Decouple Query::getCachedContacts(). ([12665](https://github.com/civicrm/civicrm-core/pull/12665))** + This change adds a "Merge: link to the "Similar Contact Found" popup (this + link had been inadvertently removed). -- **dev/core#371 remove please print this page text ([13156](https://github.com/civicrm/civicrm-core/pull/13156))** +- **Fix continue / break warning under PHP 7.3 + ([228](https://github.com/civicrm/civicrm-packages/pull/228))** -- **5.8 to master ([13154](https://github.com/civicrm/civicrm-core/pull/13154))** + This change fixes a "Did you mean to use 'continue 2'?" warning issued for + users on PHP 7.3 with sites configured to show warnings. -- **5.8 to master ([13152](https://github.com/civicrm/civicrm-core/pull/13152))** +- **Fix continue / break PHP 7.3 warnings + ([13066](https://github.com/civicrm/civicrm-core/pull/13066))** -- **dev/core#406 fix warnings under php 7.2 when importing ([13133](https://github.com/civicrm/civicrm-core/pull/13133))** + This change fixes some more "Did you mean to use 'continue 2'?" warnings issued for + users on PHP 7.3 with sites configured to show warnings. -- **dev/core#536 Remove duplicate call to contribution summary ([13149](https://github.com/civicrm/civicrm-core/pull/13149))** +- **Fix PHP7.2 warning when re-generating schema files + ([232](https://github.com/civicrm/civicrm-packages/pull/232))** -- **Fix test name because it is not running & doesn't pass :-( ([13143](https://github.com/civicrm/civicrm-core/pull/13143))** + This change fixes a warning when regenerating schema files (running either + ./bin/setup.sh -Dg or ./bin/regen.sh) for users on PHP7.2. -- **Fix continue / break PHP 7.3 warnings ([13066](https://github.com/civicrm/civicrm-core/pull/13066))** +- **Php 7.2 fix notice on countable + ([229](https://github.com/civicrm/civicrm-packages/pull/229))** -- **Unit test set up tweak - Set trxn_id & invoice_id in tests as needed rather than by default. ([13146](https://github.com/civicrm/civicrm-core/pull/13146))** + This change fixes an enotice for users on PHP 7.2 configured to show warnings. -- **dev/core#540 - Civicrm Contact Dashboard returns fatal error ([13140](https://github.com/civicrm/civicrm-core/pull/13140))** +- **Fix php 7.2 notice + ([13132](https://github.com/civicrm/civicrm-core/pull/13132))** -- **Export code cleanup - only construct one metadata array with all types of metadata ([13126](https://github.com/civicrm/civicrm-core/pull/13126))** + This change fixes a countable notice on the Contribution View page in PHP 7.2 + for sites configured to show warnings. -- **5.8 to master ([13145](https://github.com/civicrm/civicrm-core/pull/13145))** +- **Fix php7.2 notices on trying to count null + ([13111](https://github.com/civicrm/civicrm-core/pull/13111))** -- **5.8 ([13135](https://github.com/civicrm/civicrm-core/pull/13135))** + These changes fix a number of countable warning messages in PHP 7.2 for sites + configured to show warnings. -- **Fix php 7.2 notice ([13132](https://github.com/civicrm/civicrm-core/pull/13132))** +- **Fix warning error on php 7.2 ([13107](https://github.com/civicrm/civicrm-core/pull/13107))** -- **Fix Export when full group by mode is used ([13124](https://github.com/civicrm/civicrm-core/pull/13124))** + This change fixes a countable warning for users on php 7.2 with sites + configured to show warnings. -- **Lybunt report - improve developer support for debugging this report ([13087](https://github.com/civicrm/civicrm-core/pull/13087))** +### CiviCase -- **5.8 to master ([13130](https://github.com/civicrm/civicrm-core/pull/13130))** +- **[dev/core#321](https://lab.civicrm.org/dev/core/issues/321) Prevent + duplicate entries in civicrm_entity_file + ([12650](https://github.com/civicrm/civicrm-core/pull/12650))** -- **Export code cleanup - remove silly function ([13122](https://github.com/civicrm/civicrm-core/pull/13122))** + This change fixes a bug where editing a case activity with an attachment would + result in a duplicate entry in the civicrm_entity_file table. -- **dev/core#532 Batch search fix ([13121](https://github.com/civicrm/civicrm-core/pull/13121))** +- **[dev/core#563](https://lab.civicrm.org/dev/core/issues/563) Duplicate Case + manager role ([13188](https://github.com/civicrm/civicrm-core/pull/13188))** -- **Export code clean up - extract build row & getTransformed row off to ExportProcessor ([13117](https://github.com/civicrm/civicrm-core/pull/13117))** + This fixes a bug where editing a case manager would result in a duplicate + case manager role being created. -- **Export class cleanup - remove some unnecessary code ([13120](https://github.com/civicrm/civicrm-core/pull/13120))** +- **[dev/core#467](https://lab.civicrm.org/dev/core/issues/467) Case Start Date + and End Date don't work properly in Batch Update + ([13095](https://github.com/civicrm/civicrm-core/pull/13095))** -- **dev/core#153: Pending Pay Later /w Custom payment method ([13098](https://github.com/civicrm/civicrm-core/pull/13098))** + This change fixes a bug when attempting to batch update a case start date or + end date would result in a undefined index error so that no undefined index + error is thrown and one can select the start and end dates for cases + on the batch update form appropriately. -- **Minor Contact BAO code cleanup ([13115](https://github.com/civicrm/civicrm-core/pull/13115))** +### CiviContribute -- **Update name of icon from pencil to wrench in EventInfo help ([13119](https://github.com/civicrm/civicrm-core/pull/13119))** +- **[dev/core#153](https://lab.civicrm.org/dev/core/issues/153) Pending Pay + Later /w Custom payment method + ([13098](https://github.com/civicrm/civicrm-core/pull/13098))** -- **Fix Configure Event help grammar ([13118](https://github.com/civicrm/civicrm-core/pull/13118))** + This change fixes a bug where using a custom payment method to make a pending + pay later contribution would result in a contribution that one could not + record payments against. -- **dev/core#321: Prevent duplicate entries in civicrm_entity_file ([12650](https://github.com/civicrm/civicrm-core/pull/12650))** +- **[dev/core#193](https://lab.civicrm.org/dev/core/issues/193) Order API Throw + an error when adding tax amount on line items + ([13091](https://github.com/civicrm/civicrm-core/pull/13091))** -- **Regression: Fix delete event participant fatal error and display name if no email ([13113](https://github.com/civicrm/civicrm-core/pull/13113))** + This change fixes a bug where the Order API would fail when doing a create order + with taxes enabled so that one can use the Order API to create with taxes + enabled. -- **dev/core#527 Permit translation of Public Title field for Profiles ([13110](https://github.com/civicrm/civicrm-core/pull/13110))** +- **[dev/core#513](https://lab.civicrm.org/dev/core/issues/513) Contribution + Transact API - Use the payment processor payment method instead of the + payment_type field + ([13073](https://github.com/civicrm/civicrm-core/pull/13073))** -- **Export code cleanup - Use getComponentPaymentFields from processorClass ([13082](https://github.com/civicrm/civicrm-core/pull/13082))** + This change makes it so that the Contribute.Transact API bases the + payment_instrument_id field off of the used payment processor + payment_instrument_id instead of the payment_type field. -- **Fix php7.2 notices on trying to count null ([13111](https://github.com/civicrm/civicrm-core/pull/13111))** +- **Set currency template variable from contribution pages + ([13157](https://github.com/civicrm/civicrm-core/pull/13157))** -- **dev/core#528 - Advanced Search -> Contribution Tab and Contribution D… ([13112](https://github.com/civicrm/civicrm-core/pull/13112))** + This change ensures that the currencyId smarty variable gets populated on + contribution pages. -- **fix for issue-525: Extraneous br-tags in rendered note-fields ([13101](https://github.com/civicrm/civicrm-core/pull/13101))** +- **Fix metadata on cancel_reason so it is an exportable field + ([12775](https://github.com/civicrm/civicrm-core/pull/12775))** -- **Fix warning error on php 7.2 ([13107](https://github.com/civicrm/civicrm-core/pull/13107))** + when searching for contributions, this change makes the "Cancel Reason" + criteria searchable so that it can be exported. -- **5.8 ([13109](https://github.com/civicrm/civicrm-core/pull/13109))** +### CiviMail -- **5.8 ([13106](https://github.com/civicrm/civicrm-core/pull/13106))** +- **[dev/core#498](https://lab.civicrm.org/dev/core/issues/498) Undefined index + in mailing report for mailing_modified_date; and room for refactoring + ([13194](https://github.com/civicrm/civicrm-core/pull/13194))** + + This change fixes an undefined index notice on the $mailing_modified_date that + was showing up on all mailing reports. + +- **[CRM-19751](https://issues.civicrm.org/jira/browse/CRM-19751) Once "multiple + bulk" setting, cannot search for opt out or on hold contacts + ([12942](https://github.com/civicrm/civicrm-core/pull/12942))** + + For users with the setting "Enable multiple bulk email address for a contact" + enabled this change updates the Advanced search form "Email On Hold" field to + be a select that lists the Email on Hold options enabled by this setting + ("No", "On Hold Bounce", "On Hold Opt Out"). Users with the setting "Enable + multiple bulk email address for a contact" enabled should edit any existing + smart groups they have that filter on the "Email On Hold" field. + +- **[dev/mail#23](https://lab.civicrm.org/dev/mail/issues/23) Bounce processing + doesn't catch pattern 'user doesn't exist' + ([13200](https://github.com/civicrm/civicrm-core/pull/13200))** + + This change makes it so that the bounce pattern 'user doesn't exist' is + registered as an invalid bounce type. + +### CiviMember + +- **[dev/core#511](https://lab.civicrm.org/dev/core/issues/511) Membership + Dashboard shows incorrect month + ([13072](https://github.com/civicrm/civicrm-core/pull/13072))** + + This change ensures that the Membership Dashboard shows the correct current + month. + +### Drupal Integration + +- **[dev/drupal#31](https://lab.civicrm.org/dev/drupal/issues/31) CiviMember + Role sync is no longer syncing Pending memberships + ([543](https://github.com/civicrm/civicrm-drupal/pull/543))** + + This change fixes a bug where the drupal module CiviMember Role sync was not + syncing memberships for the role sync rule "Add when status is set to + Pending" so that this rule works as expected. + +- **Fix accidental scroll when saving/deleting CiviMail draft + ([13085](https://github.com/civicrm/civicrm-core/pull/13085))** + + This change fixes a bug where when working on a CiviMail draft, clicking save + or delete draft would result in the page scrolling to the top, so that the + page does not scroll when you click Save or Delete Draft. + +## Miscellany + +- **Add \Civi\Token\TokenProcessor::getContextValues() + ([13214](https://github.com/civicrm/civicrm-core/pull/13214))** + +- **Prototype for metadata based fields on search screens. + ([13013](https://github.com/civicrm/civicrm-core/pull/13013))** -- **[CRM-21427](https://issues.civicrm.org/jira/browse/CRM-21427) Websites are removed from the contact if their type is empty ([13097](https://github.com/civicrm/civicrm-core/pull/13097))** +- **(NFC) Add in unit test of dev/core#93 expansion to allow order by of more t… + ([13077](https://github.com/civicrm/civicrm-core/pull/13077))** -- **dev/cloud-native/issues#18: Soften messages for read-only extensionsDir ([13100](https://github.com/civicrm/civicrm-core/pull/13100))** +- **Merge 5.7 to master + ([13069](https://github.com/civicrm/civicrm-core/pull/13069))** -- **Use tab title in feedback message ([13102](https://github.com/civicrm/civicrm-core/pull/13102))** +- **5.7.0 release notes + ([12944](https://github.com/civicrm/civicrm-core/pull/12944))** -- **Add format type to Case Start and End Dates ([13095](https://github.com/civicrm/civicrm-core/pull/13095))** +- **Fix test name because it is not running & doesn't pass :-( + ([13143](https://github.com/civicrm/civicrm-core/pull/13143))** -- **dev/core#193: Ensure that tax amount is calculated when checking for order API line item ([13091](https://github.com/civicrm/civicrm-core/pull/13091))** +- **Trivial code cleanup + ([13166](https://github.com/civicrm/civicrm-core/pull/13166))** -- **5.8 to master ([13094](https://github.com/civicrm/civicrm-core/pull/13094))** +- **[NFC] Extract getUserCheckSum function + ([13167](https://github.com/civicrm/civicrm-core/pull/13167))** -- **Activity tab code refactor ([12557](https://github.com/civicrm/civicrm-core/pull/12557))** +- **(NFC) Regenerate DAO Checksums after changes to codegen + ([13204](https://github.com/civicrm/civicrm-core/pull/13204))** -- **Add merge link to duplicate contact popup ([13081](https://github.com/civicrm/civicrm-core/pull/13081))** +- **5.8 to master + ([13235](https://github.com/civicrm/civicrm-core/pull/13235))** -- **Fix Job Log entries containing links so they will display properly ([12659](https://github.com/civicrm/civicrm-core/pull/12659))** +- **5.8 ([13229](https://github.com/civicrm/civicrm-core/pull/13229))** + +- **5.8 to master + ([13145](https://github.com/civicrm/civicrm-core/pull/13145))** + +- **5.8 ([13135](https://github.com/civicrm/civicrm-core/pull/13135))** + +- **5.8 to master + ([13130](https://github.com/civicrm/civicrm-core/pull/13130))** + +- **5.8 ([13109](https://github.com/civicrm/civicrm-core/pull/13109))** + +- **5.8 ([13106](https://github.com/civicrm/civicrm-core/pull/13106))** + +- **5.8 ([13184](https://github.com/civicrm/civicrm-core/pull/13184))** -- **Fix accidental scroll when saving/deleting CiviMail draft ([13085](https://github.com/civicrm/civicrm-core/pull/13085))** +- **5.8 ([13182](https://github.com/civicrm/civicrm-core/pull/13182))** -- **Trigger post hook on Event Copy ([12990](https://github.com/civicrm/civicrm-core/pull/12990))** +- **5.8 ([13193](https://github.com/civicrm/civicrm-core/pull/13193))** -- **dev/core#503 - More accurate custom field checking before htmlEncode ([13076](https://github.com/civicrm/civicrm-core/pull/13076))** +- **5.8 to master + ([13094](https://github.com/civicrm/civicrm-core/pull/13094))** -- **Export code cleanup -remove meaningless code ([13083](https://github.com/civicrm/civicrm-core/pull/13083))** +- **5.8 to master + ([13154](https://github.com/civicrm/civicrm-core/pull/13154))** -- **dev/core#372 Remove notice on activity update due to trying to proces… ([13079](https://github.com/civicrm/civicrm-core/pull/13079))** +- **5.8 to master + ([13152](https://github.com/civicrm/civicrm-core/pull/13152))** -- **dev/core#513: Using payment_instrument_id instead of payment_type to determine the payment instrument when using the Transact API ([13073](https://github.com/civicrm/civicrm-core/pull/13073))** +- **5.8 to master + ([231](https://github.com/civicrm/civicrm-packages/pull/231))** - **5.8 ([13080](https://github.com/civicrm/civicrm-core/pull/13080))** -- **(NFC) Add in unit test of dev/core#93 expansion to allow order by of more t… ([13077](https://github.com/civicrm/civicrm-core/pull/13077))** +- **5.8 to master + ([13071](https://github.com/civicrm/civicrm-core/pull/13071))** -- **dev/core#511 Fix wrong current month showing on Membership Dashboard ([13072](https://github.com/civicrm/civicrm-core/pull/13072))** +- **Export code cleanup -remove meaningless code + ([13083](https://github.com/civicrm/civicrm-core/pull/13083))** -- **5.8 to master ([13071](https://github.com/civicrm/civicrm-core/pull/13071))** +- **Export code cleanup - remove silly function + ([13122](https://github.com/civicrm/civicrm-core/pull/13122))** -- **Merge 5.7 to master ([13069](https://github.com/civicrm/civicrm-core/pull/13069))** +- **Export class cleanup - remove some unnecessary code + ([13120](https://github.com/civicrm/civicrm-core/pull/13120))** -- **CRM_Core_I18n::setLocale should change $tsLocale for getLocale() to work correctly ([13050](https://github.com/civicrm/civicrm-core/pull/13050))** +- **Test support for fixing dev/core#397 including adding Rule api + ([13179](https://github.com/civicrm/civicrm-core/pull/13179))** -- **Display message template title on deletion form ([13058](https://github.com/civicrm/civicrm-core/pull/13058))** +- **Unit test set up tweak - Set trxn_id & invoice_id in tests as needed rather + than by default. + ([13146](https://github.com/civicrm/civicrm-core/pull/13146))** -- **Fix metadata on cancel_reason so it is an exportable field ([12775](https://github.com/civicrm/civicrm-core/pull/12775))** +- **Fixes to enable UserDashboard tests to all run + ([13147](https://github.com/civicrm/civicrm-core/pull/13147))** -- **5.7.0 release notes ([12944](https://github.com/civicrm/civicrm-core/pull/12944))** +- **[REF] Rename recently added getUrlVariables getFormVariables function… + ([13225](https://github.com/civicrm/civicrm-core/pull/13225))** -- **dev/drupal#31 - CiviMember Role sync is no longer syncing Pending mem… ([543](https://github.com/civicrm/civicrm-drupal/pull/543))** +- **[REF] refactor shared search functions in pre-Process + ([13210](https://github.com/civicrm/civicrm-core/pull/13210))** -- **Upgrade to Quickform 3.2.16 ([224](https://github.com/civicrm/civicrm-packages/pull/224))** +- **(REF) Allow subclasses of AbstractTokenSubscriber to override the + determination of active tokens. + ([13186](https://github.com/civicrm/civicrm-core/pull/13186))** -- **Fix continue / break warning under PHP 7.3 ([228](https://github.com/civicrm/civicrm-packages/pull/228))** +- **Activity tab code refactor + ([12557](https://github.com/civicrm/civicrm-core/pull/12557))** -- **5.8 to master ([231](https://github.com/civicrm/civicrm-packages/pull/231))** +- **Export code cleanup - only construct one metadata array with all types of + metadata ([13126](https://github.com/civicrm/civicrm-core/pull/13126))** -- **Fix PHP7.2 warning when re-generating schema files ([232](https://github.com/civicrm/civicrm-packages/pull/232))** +- **Export code clean up - extract build row & getTransformed row off to + ExportProcessor + ([13117](https://github.com/civicrm/civicrm-core/pull/13117))** -- **Php 7.2 fix notice on countable ([229](https://github.com/civicrm/civicrm-packages/pull/229))** +- **Export code cleanup - Use getComponentPaymentFields from processorClass + ([13082](https://github.com/civicrm/civicrm-core/pull/13082))** -### CiviMail +- **Flatten fix ([13176](https://github.com/civicrm/civicrm-core/pull/13176))** -- **[CRM-19751](https://issues.civicrm.org/jira/browse/CRM-19751) Once "multiple bulk" setting, cannot search for opt out or on hold contacts ([12942](https://github.com/civicrm/civicrm-core/pull/12942))** +- **Extract getContributionBalance function, use that rather than wrapper… + ([13151](https://github.com/civicrm/civicrm-core/pull/13151))** -## Miscellany +- **[dev/core#562](https://lab.civicrm.org/dev/core/issues/562) Remove instances + of $dao->free ([13192](https://github.com/civicrm/civicrm-core/pull/13192)) - + Work towards** + +- **Displayvalue fixes + ([13175](https://github.com/civicrm/civicrm-core/pull/13175))** + +- **Typos, simplify if statement + ([13233](https://github.com/civicrm/civicrm-core/pull/13233))** + +- **Remove Defunct Templates from CiviMail + ([13201](https://github.com/civicrm/civicrm-core/pull/13201))** + +- **Minor Contact BAO code cleanup + ([13115](https://github.com/civicrm/civicrm-core/pull/13115))** + +- **Trigger post hook on Event Copy + ([12990](https://github.com/civicrm/civicrm-core/pull/12990))** + +- **CRM_Core_I18n::setLocale should change $tsLocale for getLocale() to work + correctly ([13050](https://github.com/civicrm/civicrm-core/pull/13050))** ## Credits