From 23c647846e842297cfbacb685a5d6bd0ff7b114b Mon Sep 17 00:00:00 2001 From: eileen Date: Sat, 16 Nov 2019 16:50:00 +1300 Subject: [PATCH] Remove partially paid from statuses tested for RenewContribution We want to deprecate this as it doesn't work properly. In this case there is no need to test it as it's not really valid & hopefully soon it would trigger a deprecation notice Test that will work when we can deprecate https://github.com/civicrm/civicrm-core/pull/15855 --- tests/phpunit/api/v3/ContributionTest.php | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/phpunit/api/v3/ContributionTest.php b/tests/phpunit/api/v3/ContributionTest.php index b13ebe4d61ec..9a464b339fa4 100644 --- a/tests/phpunit/api/v3/ContributionTest.php +++ b/tests/phpunit/api/v3/ContributionTest.php @@ -2364,11 +2364,14 @@ public function testRepeatTransactionMembershipRenewCompletedContribution() { * CRM-19945 Tests that Contribute.repeattransaction DOES NOT renew a membership when contribution status=Failed * * @dataProvider contributionStatusProvider + * + * @throws \CRM_Core_Exception */ public function testRepeatTransactionMembershipRenewContributionNotCompleted($contributionStatus) { // Completed status should renew so we don't test that here - // In Progress status is only for recurring contributions so we don't test that here - if (in_array($contributionStatus['name'], ['Completed', 'In Progress'])) { + // In Progress status was never actually intended to be available for contributions. + // Partially paid is not valid. + if (in_array($contributionStatus['name'], ['Completed', 'In Progress', 'Partially paid'])) { return; } list($originalContribution, $membership) = $this->setUpAutoRenewMembership();