diff --git a/CRM/Contribute/Form/Contribution/ThankYou.php b/CRM/Contribute/Form/Contribution/ThankYou.php index 05efdae22666..f393a4c0a9a2 100644 --- a/CRM/Contribute/Form/Contribution/ThankYou.php +++ b/CRM/Contribute/Form/Contribution/ThankYou.php @@ -107,13 +107,11 @@ public function buildQuickForm() { } $params = $this->_params; - $invoiceSettings = Civi::settings()->get('contribution_invoice_settings'); - $invoicing = CRM_Utils_Array::value('invoicing', $invoiceSettings); + $invoicing = CRM_Invoicing_Utils::isInvoicingEnabled(); // Make a copy of line items array to use for display only $tplLineItems = $this->_lineItem; if ($invoicing) { $getTaxDetails = FALSE; - $taxTerm = CRM_Utils_Array::value('tax_term', $invoiceSettings); foreach ($this->_lineItem as $key => $value) { foreach ($value as $k => $v) { if (isset($v['tax_rate'])) { @@ -126,7 +124,7 @@ public function buildQuickForm() { } } $this->assign('getTaxDetails', $getTaxDetails); - $this->assign('taxTerm', $taxTerm); + $this->assign('taxTerm', CRM_Invoicing_Utils::getTaxTerm()); $this->assign('totalTaxAmount', $params['tax_amount']); } diff --git a/CRM/Event/Form/Registration/ThankYou.php b/CRM/Event/Form/Registration/ThankYou.php index 95d67d719873..600f4891b65d 100644 --- a/CRM/Event/Form/Registration/ThankYou.php +++ b/CRM/Event/Form/Registration/ThankYou.php @@ -96,9 +96,7 @@ public function buildQuickForm() { } $this->assignToTemplate(); - $invoiceSettings = Civi::settings()->get('contribution_invoice_settings'); - $taxTerm = CRM_Utils_Array::value('tax_term', $invoiceSettings); - $invoicing = CRM_Utils_Array::value('invoicing', $invoiceSettings); + $invoicing = CRM_Invoicing_Utils::isInvoicingEnabled(); $getTaxDetails = FALSE; $taxAmount = 0; @@ -129,7 +127,7 @@ public function buildQuickForm() { if ($invoicing) { $this->assign('getTaxDetails', $getTaxDetails); $this->assign('totalTaxAmount', $taxAmount); - $this->assign('taxTerm', $taxTerm); + $this->assign('taxTerm', CRM_Invoicing_Utils::getTaxTerm()); } $this->assign('totalAmount', $this->_totalAmount); diff --git a/CRM/Invoicing/Utils.php b/CRM/Invoicing/Utils.php index 907f089ad62b..bad42ae8bce4 100644 --- a/CRM/Invoicing/Utils.php +++ b/CRM/Invoicing/Utils.php @@ -94,4 +94,15 @@ public static function getDefaultPaymentPage() { return CRM_Utils_Array::value('default_invoice_page', $invoiceSettings); } + /** + * Function to get the tax term. + * + * The value is nested in the contribution_invoice_settings setting - which + * is unsupported. Here we have a wrapper function to make later cleanup easier. + */ + public static function getTaxTerm() { + $invoiceSettings = Civi::settings()->get('contribution_invoice_settings'); + return CRM_Utils_Array::value('tax_term', $invoiceSettings); + } + }