-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[macOS] Kindle Comic Converter has the version number 0.0.0 #632
Comments
Yes, I removed our info.plist since it caused tons of issues. pyinstaller provided defaults values like 0.0.0. Copying files after the fact manually into a .app causes tons of issues. |
since the app is unsigned you could also process the Info.plist after the build step e.g. using |
Changing the version number after building results in the original damaged error. The proper way to do this is to switch from building directly from the |
This comment has been minimized.
This comment has been minimized.
still not fixed in 6.2.0, it still claims to be 0.0.0 |
starting with version 5.6.3 and including version 5.6.4 the Kindle Comic Converter claims to have version "0.0.0"
previous versions up to 5.6.2 did not have this problem, so this is a regression. starting with 5.6.3, the in your
Info.plist
file theCFBundleVersion
was removed (which is a clear bug and should never happen) and theCFBundleShortVersionString
was set to "0.0.0" (which is just nonsense)screenshots from the Finder's GetInfo, ColumnView and QuickLook:
![Screenshot 2023-11-29 at 19 13 54](https://private-user-images.githubusercontent.com/1261954/286702849-c9de20e4-3a24-4606-8f64-fe10259a7ebb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NTYxODEsIm5iZiI6MTczOTY1NTg4MSwicGF0aCI6Ii8xMjYxOTU0LzI4NjcwMjg0OS1jOWRlMjBlNC0zYTI0LTQ2MDYtOGY2NC1mZTEwMjU5YTdlYmIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTVUMjE0NDQxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NDQxNWZlZjFhYmM3YTU1MDNmNjE0Y2UyNzhkODIzNGE3MTdkNzljYWUxMDE1MjE2Y2RkODMwMDBhM2NjMjgzOSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.dUDHviFx4Btodc8VFYLRPYPlzKQkpOiqgDee_SdEACo)
![Screenshot 2023-11-29 at 19 14 09](https://private-user-images.githubusercontent.com/1261954/286702854-4615afa8-cc71-45bb-be08-1de87dcd118c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NTYxODEsIm5iZiI6MTczOTY1NTg4MSwicGF0aCI6Ii8xMjYxOTU0LzI4NjcwMjg1NC00NjE1YWZhOC1jYzcxLTQ1YmItYmUwOC0xZGU4N2RjZDExOGMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTVUMjE0NDQxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZmNlYzdkYzA2ZTRlNTU0MDliYmQ3YmY4ZDQyYWNkNTBhZTczZmFiYThlYzJkNjViN2ViYjA0YTU2YWM1MGNhYSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.0jcT6W6n7isRN6gefUFN8u-YXp5okrFR5qc8a0c0xgY)
![Screenshot 2023-11-29 at 19 13 37](https://private-user-images.githubusercontent.com/1261954/286702865-12cc1bbf-72d3-48eb-8cf8-40948b055e52.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NTYxODEsIm5iZiI6MTczOTY1NTg4MSwicGF0aCI6Ii8xMjYxOTU0LzI4NjcwMjg2NS0xMmNjMWJiZi03MmQzLTQ4ZWItOGNmOC00MDk0OGIwNTVlNTIucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTVUMjE0NDQxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MGRhNmUxM2I2YmYzMThkYTU4MmM4MjEwZDVlMzdmMzdhODhjMTViNjMwNjQ2NjQxYTUxZTA2NTcxMjE1OTVkMSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.MIE5M7w91Zbi3_Hz335NCk6GnGddnV-IJZHiRT2YQwg)
The text was updated successfully, but these errors were encountered: