Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide guidance that the variable the acceptance application is set on in tests should be nulled out #26

Open
notmessenger opened this issue Apr 10, 2017 · 0 comments

Comments

@notmessenger
Copy link
Contributor

Whatever variable the application instance is assigned to in acceptance tests should also be set to null in an afterEach() to allow garbage collection to function correctly. When done in the mcp codebase the memory footprint decreased around 2.5Gb.

describe('Acceptance Test', function () {
  let application

  beforeEach(function () {
    application = startApp()
  })

  afterEach(function () {
    destroyApp(application)
    application = null
  })
@notmessenger notmessenger changed the title Provide guidance that the variable the application is set on in acceptance tests should be nulled out Provide guidance that the variable the application is set on in tests should be nulled out Apr 10, 2017
@notmessenger notmessenger changed the title Provide guidance that the variable the application is set on in tests should be nulled out Provide guidance that the variable the acceptance application is set on in tests should be nulled out Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant