Discuss where we see the value of hooks during testing

[juwara0]

Right now, we are getting a hook set on icon:

ember-frost-info-bar/addon/templates/components/frost-info-bar.hbs

Line 3 in 21648cd

<div class='frost-info-bar-icon' data-test={{hook (concat hook '-icon')}}>

Does this provide the value we want?

Would a tester rather be setting a hook on the icon component

ember-frost-info-bar/addon/templates/components/frost-info-bar.hbs

Line 4 in 21648cd

{{component icon}}

which gets applied to the <svg>.

[juwara0]

Another area we should evaluate updating:

ember-frost-info-bar/addon/templates/components/frost-info-bar.hbs

Lines 10 to 16 in 21648cd

	<div class='primary-title' data-test={{hook (concat hook '-title')}}>
	{{#if (type-of title 'object')}}
	{{component title}}
	{{else}}
	{{title}}
	{{/if}}
	</div>

{{#if (type-of title 'object')}}
  <div class='primary-title'>
    {{component title}}
  </div>
{{else}}
  <div class='primary-title' data-test={{hook (concat hook '-title')}}>
    {{title}}
  </div>
{{/if}}

[job13er]

Discussed in slack and @sglanzer agrees, the components should be getting hooks set on them. I'm opening an issue to that effect right now.

While the consumer probably doesn't care about some of the hooks, the component itself might care. For instance, if the frost-icon needs to be wrapped by a <div> with a particular class set on it, this component's tests should be able to grab that <div> with a hook.

[notmessenger]

JIRA: https://agile-jira.ciena.com/browse/FROST-771