Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change, needs major. #1590

Closed
betocantu93 opened this issue Jul 27, 2023 · 1 comment
Closed

Breaking change, needs major. #1590

betocantu93 opened this issue Jul 27, 2023 · 1 comment

Comments

@betocantu93
Copy link
Contributor

Hello, we bumped ember-power-select to 7.1.0 in our addon, ember-eui but it seems that version added a new component

power-select-multiple/input caused our tests to fail, because we used this.handleInput which was previously inside power-select-multiple/tigger backing class and now was refactored to the input.

I think it's a way better api to have another slot there (input) but I also was surprised it wasn't released as a major with breaking changes, my suggestion would be to just re-release it as a major to respect semver and also somehow mark 7.1.0 as deprecated or anything that points that it was a major instead or a minor

Also, please let me know if you need any help with this or any further maintenance, happy to help

@mkszepp
Copy link
Collaborator

mkszepp commented Jan 8, 2024

@betocantu93 sry for this incident... unfortunately, we cannot undo / deprecated the latests v7.x versions. We will take better care in the future for that.

As i have seen there was already fixed in ember-eui and there is possible to resolve in own app, we can close the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants