-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker automated build fails after change to alpine base image #7
Comments
Compared the sizes between building a container of prometheus-sql as it is right now and compared that to golang:alpine.
Size difference is quite significant. So looking into options like publish releases here in Github and then use wget/curl to get those when the automated build process is started for Docker hub. @bruth When is the automated build triggered at Docker Hub? Or is manually triggered? |
After some testing it seems prometheus-sql won't run in the alpine container probably because Alpine uses So if we publish a release here on Github for prometheus-sql then the Dockerfile could be something like this:
@bruth What do you think about this? |
@haxorof So it was automated before, but I only recently switched to a manual build (120c2f5) once I realized how big the image was. That 11.8 megs is because I cross-compiled locally and packaged it up into an alpine image.
Bah, i've run into that quite a few times. Your solution is pretty slick, I never thought about that approach, but looks great for continuing to use automated builds. |
Thanks! I will do some additional tests and later do a commit with a new Docker file. Shall see what is possible to do regarding releases here on Github to make it as easy and smooth as possible. I have used it in my own little repo before but never together with a automated Docker build. @bruth If you turn on automatic builds again will it then start building upon commit? |
Yes. I just turned it back on. |
After change to alpine:3.5 it seems the build at Docker fails.
https://hub.docker.com/r/dbhi/prometheus-sql/builds/
Reason for this is that in the golang base image everything was built during container creation. However there is a golang:alpine base image which might be possible to use that would be smaller than the golang:onbuild which might be something to try.
The text was updated successfully, but these errors were encountered: