Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why buildnumber as versionnumber? #26

Closed
ProfDrLuigi opened this issue Mar 8, 2021 · 3 comments
Closed

Why buildnumber as versionnumber? #26

ProfDrLuigi opened this issue Mar 8, 2021 · 3 comments
Assignees

Comments

@ProfDrLuigi
Copy link

Hi cholonam.

Is it possible to put the Versionnumber instead of Buildnumber into the Info.plist? Normaly that is the regular way.

grafik

I´m the Author of the "Kext Updater" and it couldn´t detect it correctly because 9 is higher than 2.x and the users always get the message that the kext is the latest version and it is not.

@ProfDrLuigi ProfDrLuigi changed the title Buildnumber as Versionnumber? Why buildnumber as versionnumber? Mar 8, 2021
@cholonam
Copy link
Owner

cholonam commented Mar 9, 2021

Hi, my understanding was that the build number is just an integer increased on every build publicly released, and the version is the semantic version (x.y.z), but I may be wrong.. are you recommending to use the semantic version also as the build number? It that's the common practice I'm ok with that.

I'll look into it as soon as I have some time. If you are familiar with the common practice and can explain it to me here, I'd appreciate it :)

@cholonam cholonam self-assigned this Mar 9, 2021
@ProfDrLuigi
Copy link
Author

ProfDrLuigi commented Mar 9, 2021

Yes, x.y.z is common usual. ;) Simply put the $(MODULE_VERSION) String as showed below:

grafik

grafik

@cholonam
Copy link
Owner

cholonam commented Mar 9, 2021

Looks good, thanks. I bumped all three versions to 9.0.0, so that kext updaters see the version increase from both 9 and 2.5. Your updater may not detect this as a new version (if it considers 9 == 9.0.0), but there are no code changes anyway, so no need to update this time. Next version upgrade, it should pick it up. Correct me if I'm wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants