Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature for legacy toolkit atom typing and NN atom typing. #14

Open
yuanqing-wang opened this issue May 26, 2020 · 0 comments
Open

Signature for legacy toolkit atom typing and NN atom typing. #14

yuanqing-wang opened this issue May 26, 2020 · 0 comments
Assignees

Comments

@yuanqing-wang
Copy link
Member

Related to discussions we have here #9

I suggested that the signature for the function for legacy atom typing frameworks as well as NN atom typing / parametrization should be the same, i.e. graph -> graph.

Nonetheless, this would mean that we'd have to carry the molecule (RDKit, OpenEye, or OpenForceField) object with the homogeneous graph. This wouldn't be very efficient.

If we have the function for legacy typing to have the signature molecule object -> graph, we need to think more about the bookkeeping efforts to make sure that the indices won't be messed up after batching, training, and debatching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants