Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(nodejs16) Migrate package #2090

Open
AdmiringWorm opened this issue Dec 19, 2022 Discussed in #2060 · 4 comments
Open

(nodejs16) Migrate package #2090

AdmiringWorm opened this issue Dec 19, 2022 Discussed in #2060 · 4 comments
Assignees
Labels
3 - Review migration Migration of package from another repository to this one

Comments

@AdmiringWorm
Copy link
Member

Discussed in #2060

Originally posted by tomchiverton November 10, 2022
I was asked by the community reviewers of my own package of Nodejs v16 to see if you would consider shipping it - essentially just a meta package that depends on the latest v16 release.

There's clearly a need for a package that pins a particular supported upstream major version, rather than tracking the latest and greatest LTS.

Their view is that ss the Chocolatey Community Chocolatey Packages repository maintains the nodejs package, I think it would make sense for this package to be owned there too.

Would you be interested in taking it on ? Attaching the meta package file here for discussion on it if required.

If not, hopefully the review team would except it independently.

nodejs16.nuspec.txt

@AdmiringWorm AdmiringWorm added 0 - Backlog migration Migration of package from another repository to this one labels Dec 19, 2022
@tomchiverton
Copy link

Happy to submit a PR. Which folder do I need to drop a nodejs16.nuspec.txt (if that is the right name) in ?

@AdmiringWorm
Copy link
Member Author

It depends on whether we would want to have this as an automatic package, or a manually updating one.

If there are no new updates for 16.x ever coming in the future, it is fine to have it as a manual package. In that case, just create a nodejs16 folder in the manual folder and drop the nuspec file in there (rename it to nodejs16.nuspec with out the .txt extension).

I haven't looked over the file itself, that will be done as part of the PR review.

If there will be updates in the future for that major version, we would need to have it as a automatic package. Similar procedure just in the automatic folder instead, but additionally a update.ps1 file is needed in that case so the appveyor build server will check for updates (take a look at the original nodejs.install/nodejs package in that case for the update script).

@pauby
Copy link
Member

pauby commented Jan 19, 2023

@tomchiverton Have you made any progress on the PR?

@tomchiverton
Copy link

#2122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Review migration Migration of package from another repository to this one
Projects
None yet
Development

No branches or pull requests

3 participants