-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error when onEnd removed component tweening state #24
Comments
I've the same problem but setting a timeout did not fix it. I use tweenState in combination with The problem is in
At method call the component is still mounted but the state changed till |
Thanks and sorry for the wait! Fortunately with React 0.13, setting state after unmounting doesn't throw anymore. The warning's still bothersome though, so I'll make the change @agidoSF suggested. (@natew: your fix didn't work for me either). |
@agidoSF @natew I just released v0.0.5, which contains the fix, because this is the last release compatible with React < 0.13 (0.13 actually breaks something in tween-state and I'm fixing it now). Seemed better than to jump straight to supporting only React 0.13+ and leaving people at 0.12 without this fix. |
This should probably work:
But if props.onClose removes the tweening element I get an error
setState
on non-mounted component. This fixes it for now:The text was updated successfully, but these errors were encountered: