From 51753119747c1a2bb2ca02ffa6c6cd6f84448fb9 Mon Sep 17 00:00:00 2001 From: Craig Gumbley <craiggumbley@gmail.com> Date: Sun, 10 Jul 2022 16:56:21 +0100 Subject: [PATCH] Refactor writer In this commit we move the template out of the method for readability. Also, because tmpl.Execute returns an error we don't actually need to do error checking in the method. We can just pass the result (error or nil) back to the caller. --- internal/writer/writer.go | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/internal/writer/writer.go b/internal/writer/writer.go index 7b529ac..b1951f5 100644 --- a/internal/writer/writer.go +++ b/internal/writer/writer.go @@ -9,8 +9,7 @@ import ( "github.com/chelnak/gh-changelog/internal/changelog" ) -func Write(writer io.Writer, changelog changelog.Changelog) error { - var tmplSrc = `# Changelog +var tmplSrc = `# Changelog All notable changes to this project will be documented in this file. @@ -77,11 +76,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) a {{- end}} {{- end}}` +func Write(writer io.Writer, changelog changelog.Changelog) error { tmpl := template.Must(template.New("changelog").Parse(tmplSrc)) - - err := tmpl.Execute(writer, changelog) - if err != nil { - return err - } - return nil + return tmpl.Execute(writer, changelog) }