fix(ansi): cut/truncate/truncateleft improperly handling new lines #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not sure this is the best way to handle this, but, without this patch, truncates would still use new lines from outside its cut target. This fixes it.
|
This is related to #351 |
aymanbagabas
approved these changes
Feb 10, 2025
|
Could you add the tests from #351 here? |
seems to be working fine to me, even added another test for it. PS: the problem was that it wasn't ignoring out of the cut new lines - so it was including all of them. |
raphamorim
reviewed
Feb 11, 2025
| @@ -142,6 +143,14 @@ func truncate(m Method, s string, length int, tail string) string { | |||
| // collects printable ASCII | |||
| curWidth++ | |||
| fallthrough | |||
| case parser.ExecuteAction: | |||
There was a problem hiding this comment.
so in case of a new line, it will be ignored?
aymanbagabas
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure this is the best way to handle this, but, without this
patch, truncates would still use new lines from outside its cut target.
This fixes it.
closes #351