Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Welcome to contribute to SRS #1

Open
winlinvip opened this issue Mar 2, 2022 · 1 comment
Open

Welcome to contribute to SRS #1

winlinvip opened this issue Mar 2, 2022 · 1 comment

Comments

@winlinvip
Copy link

Hi @JanKoppe

I'm author of SRS

Glad to see this project, I also file an issue API: Support metrics for Prometheus, do you want to contribute a patch for SRS to support promethus?

I noticed that this project is GPL, however SRS is MIT LICENSE, so please also consider about whether it's possible to switch to MIT?

Please feel free to talk with us by discord

Thanks~

@JanKoppe
Copy link
Member

JanKoppe commented Mar 2, 2022

Hello @winlinvip,

Nice that you have found this little project. We use it very happily with our tiny SRS cluster. Thank you for all the work.

Sadly, I am not good at C++. Contributing directly to SRS is too hard for me, probably. But I welcome your efforts to integrate Prometheus metrics endpoint in SRS directly.

I will think about switching the licence to MIT. It does make sense.

I would like to avoid discord as much as possible. It's a closed platform, which I dislike.

Thank you for reaching out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants