Simplify output for nested chalk tags

[ExE-Boss]

Currently, nested chalk tags in a template reset and re‑specify everything, instead of just what needs to be modified for that level of nesting.

Code

chalk`{red  red {bold  red & bold } red again }`

Expected result:

\e[31m red \e[1m red & bold \e[22m red again \e[39m

Actual result:

\e[31m red \e[39m\e[31m\e[1m red & bold \e[22m\e[39m\e[31m red again \e[39m

See also:

• test: Fix chalk tagged template literals to use nested chalk tags mdn/browser-compat-data#4265

[sindresorhus]

Yes, that would be ideal, but it's not a big problem as the visual output is still correct. PR welcome :)

[Qix-]

There's somewhat a reason for this; dim and bold have the same exit code and thus added some complexity to the implementation IIRC.

Be careful that this doesn't slow everything down.

[zerefwayne]

@sindresorhus @Qix- Is the issue still open?

[sindresorhus]

⬇️

⬆️

[Qix-]

I think this should be closed. Across all the terminal emulators that exist, with all of the different IDEs and whatnot that also try to implement this (jetbrains software, vscode, etc.) I think trying to be clever about this stuff is only going to hurt performance and break more people.

Further, I've yet to come across a case where the extra few bytes were really detrimental to performance or even on-the-wire sizes (and where completely disabling styled output wasn't also an option).

Thoughts @sindresorhus?

[sindresorhus]

I agree. It's simply not worth the added complexity and risk of breakage.