Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

While you change of Chain using a Model File Iterator node, size of previous node is kept in memory #2120

Closed
yaiol opened this issue Aug 18, 2023 · 4 comments · Fixed by #2254
Labels
bug Something isn't working

Comments

@yaiol
Copy link

yaiol commented Aug 18, 2023

Information:

  • Chainner version: 0.19.3
  • OS: Windows 11 Pro 22H02

Description
Using two Chains having a Model File Iterator node

If I close ChaiNNer and load chain A it looks like this
A

If I close ChaiNNer and load chain B it looks like this
B

If I close ChaiNNer and load chain A then next chain B, size of model file iterator node is messed up (keeping A size)
A Then B

If I close ChaiNNer and load chain B then next chain A, size of model file iterator node is messed up (keeping B size)
B then A

Probably some variable not cleaned correctly.

The two models (rename .chn.txt to .chn)
A.chn.txt
B.chn.txt

@yaiol yaiol added the bug Something isn't working label Aug 18, 2023
@joeyballentine
Copy link
Member

Oh that's really weird, thanks for reporting. There's a lot of weirdness with iterator sizing that I'd like to fix at some point, so hopefully I'll get to this soon.

@yaiol
Copy link
Author

yaiol commented Aug 18, 2023

I think I found the origin of the bug, I create model B from model A
Then into the file it has the same UUID 82f8365a-bd35-4ed8-8798-de20465330a8
Using different models created at different moment I don't have the previous issue.
Probably the variables linked to 82f8365a-bd35-4ed8-8798-de20465330a8 node are kept into memory.

Modifying all occurences of 82f8365a-bd35-4ed8-8798-de20465330a8 with 92f8365a-bd35-4ed8-8798-de20465330a8 with a text editor into model B by hand fixed the issue.

@yaiol
Copy link
Author

yaiol commented Aug 18, 2023

Oh that's really weird, thanks for reporting. There's a lot of weirdness with iterator sizing that I'd like to fix at some point, so hopefully I'll get to this soon.

Your are welcome, with the last information I just gave you i think you could fix many weird issues not only this one. Cleaning all nodes into memory before loading the new chain.

@joeyballentine
Copy link
Member

Yes that sounds like we are just not clearing some state when we load a new chain. Thanks for looking into it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants